From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#24012: 25.0.95; forward-comment backwards takes O(n^2) Date: Sun, 29 Sep 2019 07:15:22 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177138"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 24012@debbugs.gnu.org, Leo Liu To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 29 07:16:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iERZF-000jqR-Eg for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 07:16:21 +0200 Original-Received: from localhost ([::1]:36848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iERZD-0001Va-DE for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 01:16:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45262) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iERYz-0001VR-Mp for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 01:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iERYx-0001tA-Jj for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 01:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43187) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iERYx-0001sP-FH for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 01:16:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iERYw-000319-85 for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 01:16:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2019 05:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24012 X-GNU-PR-Package: emacs Original-Received: via spool by 24012-submit@debbugs.gnu.org id=B24012.156973414111561 (code B ref 24012); Sun, 29 Sep 2019 05:16:02 +0000 Original-Received: (at 24012) by debbugs.gnu.org; 29 Sep 2019 05:15:41 +0000 Original-Received: from localhost ([127.0.0.1]:52008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iERYb-00030P-FC for submit@debbugs.gnu.org; Sun, 29 Sep 2019 01:15:41 -0400 Original-Received: from mail-pf1-f194.google.com ([209.85.210.194]:33425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iERYZ-00030C-LV for 24012@debbugs.gnu.org; Sun, 29 Sep 2019 01:15:40 -0400 Original-Received: by mail-pf1-f194.google.com with SMTP id q10so3699278pfl.0 for <24012@debbugs.gnu.org>; Sat, 28 Sep 2019 22:15:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=pUka9FLAiATRGU4UPdABlpf+O+Axx3Ybw1UBNxtZ2e8=; b=EFTRaoZNB17Zsks6g4SjCkZCF4mWNW6WZjQkDWfIHJkHHS/ggJ2iUmlvH+WzrNiCR/ +tpjqPio9/qn5DjQW84BCqM0D2P7jkXeKFKwvkFKJaR3fTcuykaJCBJZE9zTVzstcg9z lTxT993rRR3A9piP5Yi6kyZGBuEU/0CWOy1oIC+erlarvP3msLhQwq8QPAhNOL6MMF+X 8VMWX0xFWLiZTHfGGwkohBzOaUPmOGFKm/N+L1QxtAgwnybyRhSN7+S9JvlAS9NF6Jif 3rww3OyXhi7L+KTkydrTrQPB2Q6CpoL5aE5z8bDgOHzP3kHaaVKMYg0Y/HuhXA4jY/Hw LoXQ== X-Gm-Message-State: APjAAAViF2eUWnOfwW3qbSQmDJv3MWW3T35wRjoGp9MJAKOkBLjK+TFc gJXr1VqkCx8vZ+ODJa5pX9IM4IYPVpVIgegq/3U= X-Google-Smtp-Source: APXvYqzUA+MVxZ9lnYw/6bfDlwdw8QNwlbhSXEEpAqDRvGxj4WZ0vW7P+jysoeHtK7n8fDm9Fu5qD0B8qprVWVeXstc= X-Received: by 2002:a17:90a:cc08:: with SMTP id b8mr19615546pju.119.1569734133836; Sat, 28 Sep 2019 22:15:33 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167599 Archived-At: Dmitry Gutov writes: > On 7/17/16 2:04 PM, Leo Liu wrote: >> 1. Use the attached file as an example, open it in emacs in ruby-mode >> 2. Move point to end of buffer and eval (forward-comment (- (point))) >> The last step takes about 0.25 seconds on my MacBook 3 GHz Intel Core >> i7. If you double the lines of comments, the time increase by 4 folds. > > FWIW, it looks fixed in the master branch now. > > Probably by 14b95587520959c5b54356547a0a69932a9bb480, so no idea what exactly > was causing it. Indeed. I only see O(n) on current master -- that is, if I use the source code from the original report, and double the amount of lines by C-x h M-w C-y, the time to evaluate this expression in a buffer only doubles: (progn (end-of-buffer) (forward-comment (- (point)))) Leo, are you still seeing this issue? If I don't hear back within a couple of weeks, I'll just assume that this has been fixed and close this bug. Best regards, Stefan Kangas