From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#53153: package-quickstart: unusual autoload form in selectrum gives byte-compilation warning Date: Sun, 9 Jan 2022 22:46:59 -0600 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29845"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier To: 53153@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 10 05:48:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n6mbP-0007ZT-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Jan 2022 05:48:15 +0100 Original-Received: from localhost ([::1]:38838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6mbO-0005Nx-2T for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jan 2022 23:48:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6mbD-0005NY-RI for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 23:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6mbD-0006ko-Ia for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 23:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n6mbC-0000nG-JD; Sun, 09 Jan 2022 23:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jan 2022 04:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53153 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.16417900282871 (code B ref -1); Mon, 10 Jan 2022 04:48:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Jan 2022 04:47:08 +0000 Original-Received: from localhost ([127.0.0.1]:51629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6maJ-0000kF-VR for submit@debbugs.gnu.org; Sun, 09 Jan 2022 23:47:08 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:40484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n6maF-0000k5-WE for submit@debbugs.gnu.org; Sun, 09 Jan 2022 23:47:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6maF-0005K2-Ne for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 23:47:03 -0500 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:38650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n6maD-0006cG-3a for bug-gnu-emacs@gnu.org; Sun, 09 Jan 2022 23:47:02 -0500 Original-Received: by mail-pl1-f170.google.com with SMTP id c3so10886661pls.5 for ; Sun, 09 Jan 2022 20:47:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=n5eUVzn3npAlDoFbI4zx4ugseASFa0yzaYmcH0rRZ6s=; b=vkb+BduhuM9hIAwBp57xe+a5Cz2/X6qYa9qLGJrFt/e6LEnOcPHOmrcn+TVI9pjSzo OEAK+S7RBXOP/YuUvzaF+Okpfo+T5yO962pwGWrZpRwMZh4aWhUssenMah9bnGoME8Fz HPeSdmMJiPYBGgoZPaFK8i4F15pEf2IBrwcB5p1Xrm7BLZ5SS+77+cNppenhgd0azFsV gTnmX+8gidXleax6p1nYnaOGK2XrKf2FsFz02RfUtlJf8XSBz8ccGvlcVgyzCoQ2ke4P PPxje40+FgrpsRoMFQRxmoG+UXhljKUFZqcf8dEBhyIkO6KTsQ8L+izQKEpZLbRDyyv4 vyoQ== X-Gm-Message-State: AOAM5337R+PAM2ks6NBJ7Z30zyHmwkgqtfCkqPcn5rX18U8gQk+r4Cd8 bp7LVIHOFW5++TszdOHwQTizaGiWqAvTXuVhWS9yoIWgC3M= X-Google-Smtp-Source: ABdhPJwDpLe2Vx3vVDX/C/HhRz/9oNdbjF7w2s5qB+D0cAVrYur9sm0ClwL/3CfKwc9LTxjGrwwlkLL/q0/7OINK+lU= X-Received: by 2002:a17:902:c104:b0:14a:259b:92 with SMTP id 4-20020a170902c10400b0014a259b0092mr6543131pli.174.1641790019689; Sun, 09 Jan 2022 20:46:59 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 9 Jan 2022 22:46:59 -0600 Received-SPF: pass client-ip=209.85.214.170; envelope-from=stefankangas@gmail.com; helo=mail-pl1-f170.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223870 Archived-At: Severity: minor I am seeing this warning whenever I install a package: Compiling file /home/skangas/.emacs.d/package-quickstart.el at Mon Jan 10 05:33:47 2022 package-quickstart.el:2060:2170: Warning: defcustom for =E2=80=98selectru= m-mode=E2=80=99 fails to specify containing group This is due to an odd hack in selectrum.el (available on MELPA or at https://github.com/raxod502/selectrum): ;; You may ask why we copy the entire minor-mode definition into the ;; autoloads file, and autoload several private functions as well. ;; This is because enabling `selectrum-mode' does not actually require ;; any of the code in Selectrum. So, to improve startup time, we avoid ;; loading Selectrum when enabling `selectrum-mode'. ;;;###autoload (progn (define-minor-mode selectrum-mode This unusual arrangement means that we end up with this interesting form in package-quickstart.el (pretty-printed): (define-minor-mode selectrum-mode "Minor mode to use Selectrum for `completing-read'." :global t (if selectrum-mode (progn (selectrum-mode -1) (setq selectrum-mode t) (setq selectrum--old-completing-read-function (default-value 'completing-read-function)) (setq-default completing-read-function #'selectrum-completing-read) (setq selectrum--old-read-buffer-function (default-value 'read-buffer-function)) (setq-default read-buffer-function #'selectrum-read-buffer) (setq selectrum--old-read-file-name-function (default-value 'read-file-name-function)) (setq-default read-file-name-function #'selectrum-read-file-name) (setq selectrum--old-completion-in-region-function (default-value 'completion-in-region-function)) (when selectrum-complete-in-buffer (setq-default completion-in-region-function #'selectrum-completion-in-region)) (advice-add #'completing-read-multiple :override #'selectrum-completing-read-multiple) (advice-add 'dired-read-dir-and-switches :around #'selectrum--fix-dired-read-dir-and-switches) (advice-add 'read-library-name :override #'selectrum-read-library-name) (advice-add #'minibuffer-message :around #'selectrum--fix-minibuffer-message) (define-key minibuffer-local-map [remap previous-matching-history-element] 'selectrum-select-from-history)) (when (equal (default-value 'completing-read-function) #'selectrum-completing-read) (setq-default completing-read-function selectrum--old-completing-read-function)) (when (equal (default-value 'read-buffer-function) #'selectrum-read-buffer) (setq-default read-buffer-function selectrum--old-read-buffer-funct= ion)) (when (equal (default-value 'read-file-name-function) #'selectrum-read-file-name) (setq-default read-file-name-function selectrum--old-read-file-name-function)) (when (equal (default-value 'completion-in-region-function) #'selectrum-completion-in-region) (setq-default completion-in-region-function selectrum--old-completion-in-region-function)) (advice-remove #'completing-read-multiple #'selectrum-completing-read-multiple) (advice-remove 'dired-read-dir-and-switches #'selectrum--fix-dired-read-dir-and-switches) (advice-remove 'read-library-name #'selectrum-read-library-name) (advice-remove #'minibuffer-message #'selectrum--fix-minibuffer-messa= ge) (when (eq (lookup-key minibuffer-local-map [remap previous-matching-history-element]) #'selectrum-select-from-history) (define-key minibuffer-local-map [remap previous-matching-history-element] nil)))) Now, I have two questions: 1. Does it make sense for Emacs to be complaining about a defcustom here? AFAICT, there is no defcustom in the above form. Do we care, or is this use case just unsupported? 2. I guess the other question is why `selectrum-mode' is not just in its own file, if startup speed is of the essence. Maybe Stefan Monnier has something to add here.