unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Andreas Schwab <schwab@suse.de>
Cc: 18555@debbugs.gnu.org, Leo Liu <sdl.web@gmail.com>
Subject: bug#18555: 24.4.50; butlast and nbutlast doesn't handle improper lists
Date: Mon, 30 Sep 2019 04:39:27 +0200	[thread overview]
Message-ID: <CADwFkm=F1rvntkRh-hLL8eZvEOLey_g=hyWvoQhybdQP2UYs_Q@mail.gmail.com> (raw)
In-Reply-To: <m3ppeke44i.fsf@gmail.com>

tags 18555 + notabug wontfix
close 18555
quit

Andreas Schwab <schwab@suse.de> writes:

> Leo Liu <sdl.web@gmail.com> writes:
>
>>   (nbutlast '(1 2 . 3))
>>
>> throws an error due to `length' which can be fixed
>> by using safe-length instead.
>>
>>   (butlast '(1 2 . 3))
>>
>> still throws an error due to copy-sequence not taking
>> improper list.
>>
>> What is the right thing to do?
>
> Don't do that then.

Agreed.  Both butlast and nbutlast are documented to work on lists, and
throwing a malformed list at them should correctly signal an error.

I'm therefore closing this bug report.

Best regards,
Stefan Kangas





      parent reply	other threads:[~2019-09-30  2:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  4:05 bug#18555: 24.4.50; butlast and nbutlast doesn't handle improper lists Leo Liu
2014-09-25  7:21 ` Andreas Schwab
2019-09-30  2:39 ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=F1rvntkRh-hLL8eZvEOLey_g=hyWvoQhybdQP2UYs_Q@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=18555@debbugs.gnu.org \
    --cc=schwab@suse.de \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).