unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 36156@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips
Date: Sun, 25 Aug 2019 14:58:42 +0200	[thread overview]
Message-ID: <CADwFkm=EkCWVUR77cytddMy5QA-f+0Fgo7H1YA-WSHtQN9U=7w@mail.gmail.com> (raw)
In-Reply-To: <83h865h3ht.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> Are we sure TOOL_BAR_ITEM_CAPTION will always produce human-readable
> text?

I think so, because we do this above (quoted to avoid gmail mangling the code):

>  /* Get the caption of the item.  If the caption is not a string,
>     evaluate it to get a string.  If we don't get a string, skip this
>     item.  */
>  caption = XCAR (item);
>  if (!STRINGP (caption))
>    {
>      caption = menu_item_eval_property (caption);
>      if (!STRINGP (caption))
>    return 0;
>    }
>  set_prop (TOOL_BAR_ITEM_CAPTION, caption);

When this function returns 0, we don't append this item to the items
that will be displayed.

Best regards,
Stefan Kangas





  reply	other threads:[~2019-08-25 12:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10  1:14 bug#36156: [PATCH] Make toolbar show keyboard equivalents in its tooltips Stefan Kangas
2019-06-10  2:06 ` Noam Postavsky
2019-06-10  3:30   ` Stefan Kangas
2019-06-10 16:54     ` Eli Zaretskii
2019-06-11 21:28       ` Stefan Kangas
2019-06-22  9:13         ` Eli Zaretskii
2019-08-24 20:40 ` Juri Linkov
2019-08-25 11:03   ` Stefan Kangas
2019-08-25 11:46     ` Eli Zaretskii
2019-08-25 12:58       ` Stefan Kangas [this message]
2019-08-25 13:10         ` Eli Zaretskii
2019-08-25 20:18           ` Juri Linkov
2019-08-26  6:26             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=EkCWVUR77cytddMy5QA-f+0Fgo7H1YA-WSHtQN9U=7w@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=36156@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).