From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#75451: scratch/igc: Enable CHECK_STRUCTS Date: Thu, 9 Jan 2025 06:44:47 -0600 Message-ID: References: <87frls47uu.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33923"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd Moellmann , Andrea Corallo , Eli Zaretskii , 75451-done@debbugs.gnu.org To: Pip Cet , Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 09 13:45:31 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVrul-0008cG-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jan 2025 13:45:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVruP-0002BK-DR; Thu, 09 Jan 2025 07:45:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVruJ-00026s-By for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 07:45:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVruJ-0006KG-2r for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 07:45:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-Reply-To:From:To:Subject; bh=/By/nNQiDNpIoWkmb6am6x6T/SKSKj43SsjP/pBJ2zo=; b=E6Wnz24jdG9B+3yayR+CYl9/geaknlCitr63o2d3WwFNDuapSw/4/at85oRcDP/3CwTMuMgSFp3ce8I7VMChcwDxp6fQw/KY77C10SoTQjqM7+tHzxAZV/gUNZAP3dMV2mM+dW/Ygk5u/BUT8Oymp1huy/D2RT66InTgkshkJiOnqpKVYhk0Ml14hET90muSP/trtnIHCA7+Buw+n6wWVTCO7S7v4Bm40ILQP93rRp22ArUHVLECkHnbnuXpO7u/ZeHui8AmzM7tHYQo8TaY3vgLkV3pFFcS9sUiMxWCd3tvBqSgkGqTxETcNy1D03ZrSt/CuNlnnX2yLlloBYtaow==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVruI-0005et-0J for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 07:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75451 X-GNU-PR-Package: emacs Original-Received: via spool by 75451-done@debbugs.gnu.org id=D75451.173642669621726 (code D ref 75451); Thu, 09 Jan 2025 12:45:01 +0000 Original-Received: (at 75451-done) by debbugs.gnu.org; 9 Jan 2025 12:44:56 +0000 Original-Received: from localhost ([127.0.0.1]:50755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVruC-0005eL-D1 for submit@debbugs.gnu.org; Thu, 09 Jan 2025 07:44:56 -0500 Original-Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:47255) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tVruA-0005e7-T0 for 75451-done@debbugs.gnu.org; Thu, 09 Jan 2025 07:44:55 -0500 Original-Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-aaeec07b705so156717266b.2 for <75451-done@debbugs.gnu.org>; Thu, 09 Jan 2025 04:44:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736426688; x=1737031488; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=/By/nNQiDNpIoWkmb6am6x6T/SKSKj43SsjP/pBJ2zo=; b=Jsyj7/DFRGKipj7aGAEoXzOvj6UFN+u3EkIdjcqYJHRdYnaByvuLtn0ffZysrsLSRZ xu07TmpFy3+lRELfllRlxdHuYlrG6k/wll8ka9QfMu63cTUAAJKKPOkv8KqBMxrANQoc inM1gGYhLEXtgYRKiduIXqoUYujb7zDFxXhqrzPTDLLOedFQM5UMKpsmQFAOh+8PjM3Z zTGv/tFGtTrMjGaOhnuCOtAz24Izxt/GNohWWAjtJakrkE0gSVbQBSNpi4+Z90sb0cPN k7uHKx1Wn4UVewNIBHjWcs2C7aBdONSddcn7AuaYrevIjHkJarwiaw+xpksLSpX9kcBH QHwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736426688; x=1737031488; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/By/nNQiDNpIoWkmb6am6x6T/SKSKj43SsjP/pBJ2zo=; b=krvkjfJ2EPuEgj/muslhsk0b7Q0paacr9KcL90/TIIgYpaGeaDP6LRvMU181jjY7NU kmit76rsdTPdH0MZnEZvrLBI6y6UXvTGWluyg5OXJJ5FrWFZn/OiMND0r7hfzdFKm+aT I8ESeEam+2Kzp3F0Htq0CVDzqx4VFLHghFyQ4HBw7BFokAtZvphka4Z31+wbAALpsvmP j/unuMiE7/S9B9rYaan5eS1oMA5pg27pbkAjV3UBp4ldmhg0hL/j3IkcS3rF0MSq7KIo U3ECs3U77y+L5AtcOt56Xz96luZsQjyjhUf6VPSG/RxkUMoskLd495UFGX7BRdL65zWn u5SQ== X-Forwarded-Encrypted: i=1; AJvYcCUPA2rp+ZwjF0krKqJEVOYD+Qvcm6PGqpX5Ny2neUNfhwWimgP4p7YFbwW+gBKbT6On4V10AQEKy9zS@debbugs.gnu.org X-Gm-Message-State: AOJu0YzBR3dbLdVXhE1FAuN1wYT0uME+ofCX7PUs29xKW/F6Wx4K182E ASOwYojw+qVflY9t32PNbMeUOGLOueBV7t1kVQLnStTX2OEFNdIpaWuDldv4UXJzxiVT+o7dI79 dJ2D5i4URp3AA7oDTkitTC1rnOms= X-Gm-Gg: ASbGnctuuXnTB+4hevkywPELRxWy4O63A1YUqMC1IiVou0qX8eimjvfExpeb/WfVKCz 5MmNs1yy5/EiYmuMB33MY1ZvBdQolvjj2Oep62xaS X-Google-Smtp-Source: AGHT+IHNecbnFj50KHnzqghQxdH90qmFgK+aI4z/R78zpQJzZs9z3RJRIkR5i/LDWN6dergULnXHBKRHZmd47j2Y6kw= X-Received: by 2002:a17:907:9711:b0:aa6:1e9a:e45a with SMTP id a640c23a62f3a-ab2abdc368emr509370766b.46.1736426687986; Thu, 09 Jan 2025 04:44:47 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 9 Jan 2025 06:44:47 -0600 In-Reply-To: <87frls47uu.fsf@protonmail.com> X-Gm-Features: AbW1kvYhkJaqwqz7IdpTPZZ8I5vUQBKWfSpShaneybNvYRdX6Y4EDBK5JQwwM9c X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298831 Archived-At: Pip Cet writes: > This isn't strictly about the scratch/igc branch, but I personally think > struct hashes should be checked in all builds, mismatches should be > downgraded to #warnings, and --enable-checking=all could include > -Werror=cpp. (So the warnings would still abort a build with > --enable-checking=all, but they'd *also* show up in regular builds.) Sounds good to me. > Also, we should include them in the nativecomp ABI hash, as nativecomp > relies on struct layout and the tagging scheme in nontrivial ways > (most-positive-fixnum, for example, is treated as a compile-time > constant by comp.el, but I'm not sure all changes to it would > automatically affect the comp abi hash). I'm copying in Andrea for this part. > Changes required might include: > > * autodetection of gawk vs awk (I think this simply means using $(AWK) > rather than "awk" in src/Makefile.in; this is important on some > machines which provide a very different "awk") Using $(AWK) instead of raw "awk" makes sense, because why not. But which awk implementations are you concerned about more specifically? I would expect us to just use POSIX awk, without any gawk extensions. For example, I have had no issues building on Debian (using mawk by default) or macOS (with the BSD awk that descends from nawk, IIUC). > * igc.o and comp.o should depend explicitly on dmpstruct.h (this is > important for re-builds; in theory, the current scratch/igc branch is > broken for highly parallel builds because dmpstruct.h might be > generated after igc.o, but that is not important). Sounds good also. > * a hash-of-hashes for nativecomp > > Proposed partial patch: (I didn't look at the patch yet, though the above sounds like it might come out to more than one patch.)