bug#65768: Bump persist.el version

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

Please bump the version now that we've fixed that hash
table issue in persist.

See patch.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Bump-version.patch --]
[-- Type: text/x-diff, Size: 644 bytes --]

From 8b5ec447c3ac0c6f5efa15737f22e984bba99992 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Tue, 5 Sep 2023 19:13:06 -0700
Subject: [PATCH] Bump version

---
 persist.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/persist.el b/persist.el
index e43171459e..8a1f746ddd 100644
--- a/persist.el
+++ b/persist.el
@@ -5,7 +5,7 @@
 ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
 ;; Maintainer: Phillip Lord <phillip.lord@russet.org.uk>
 ;; Package-Type: multi
-;; Version: 0.5
+;; Version: 0.6
 
 ;; The contents of this file are subject to the GPL License, Version 3.0.
 
-- 
2.41.0

bug#65768: Bump persist.el version

[Stefan Kangas]

Joseph Turner <joseph@breatheoutbreathe.in> writes:

> Please bump the version now that we've fixed that hash
> table issue in persist.
>
> See patch.

Phillip, what do you think?

> From 8b5ec447c3ac0c6f5efa15737f22e984bba99992 Mon Sep 17 00:00:00 2001
> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Date: Tue, 5 Sep 2023 19:13:06 -0700
> Subject: [PATCH] Bump version
>
> ---
>  persist.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/persist.el b/persist.el
> index e43171459e..8a1f746ddd 100644
> --- a/persist.el
> +++ b/persist.el
> @@ -5,7 +5,7 @@
>  ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
>  ;; Maintainer: Phillip Lord <phillip.lord@russet.org.uk>
>  ;; Package-Type: multi
> -;; Version: 0.5
> +;; Version: 0.6
>
>  ;; The contents of this file are subject to the GPL License, Version 3.0.

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ping.

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ping :)

Joseph Turner <joseph@breatheoutbreathe.in> writes:

> Ping.

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Ping :)

Stefan Kangas <stefankangas@gmail.com> writes:

> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>
>> Please bump the version now that we've fixed that hash
>> table issue in persist.
>>
>> See patch.
>
> Phillip, what do you think?
>
>> From 8b5ec447c3ac0c6f5efa15737f22e984bba99992 Mon Sep 17 00:00:00 2001
>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>> Date: Tue, 5 Sep 2023 19:13:06 -0700
>> Subject: [PATCH] Bump version
>>
>> ---
>>  persist.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/persist.el b/persist.el
>> index e43171459e..8a1f746ddd 100644
>> --- a/persist.el
>> +++ b/persist.el
>> @@ -5,7 +5,7 @@
>>  ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
>>  ;; Maintainer: Phillip Lord <phillip.lord@russet.org.uk>
>>  ;; Package-Type: multi
>> -;; Version: 0.5
>> +;; Version: 0.6
>>
>>  ;; The contents of this file are subject to the GPL License, Version 3.0.

bug#65768: Bump persist.el version

[phillip.lord]

Oh dear, you have had to ping on this many times.

Would you be interested in taking over maintainership of persist? I am 
very short of Emacs time these days.

Phil

On 2023-10-30 20:54, Joseph Turner wrote:
> Ping :)
> 
> Stefan Kangas <stefankangas@gmail.com> writes:
> 
>> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>> 
>>> Please bump the version now that we've fixed that hash
>>> table issue in persist.
>>> 
>>> See patch.
>> 
>> Phillip, what do you think?
>> 
>>> From 8b5ec447c3ac0c6f5efa15737f22e984bba99992 Mon Sep 17 00:00:00 
>>> 2001
>>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>>> Date: Tue, 5 Sep 2023 19:13:06 -0700
>>> Subject: [PATCH] Bump version
>>> 
>>> ---
>>>  persist.el | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/persist.el b/persist.el
>>> index e43171459e..8a1f746ddd 100644
>>> --- a/persist.el
>>> +++ b/persist.el
>>> @@ -5,7 +5,7 @@
>>>  ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
>>>  ;; Maintainer: Phillip Lord <phillip.lord@russet.org.uk>
>>>  ;; Package-Type: multi
>>> -;; Version: 0.5
>>> +;; Version: 0.6
>>> 
>>>  ;; The contents of this file are subject to the GPL License, Version 
>>> 3.0.

bug#65768: Bump persist.el version

[Joseph Turner]

Hi Phillip!

phillip.lord@russet.org.uk writes:

> Oh dear, you have had to ping on this many times.

No worries :)

> Would you be interested in taking over maintainership of persist? I am
> very short of Emacs time these days.

Yes, I am interested!  Stefan, Eli, what do you think?

Stefan, before I commit to maintainership of persist, please let me know
of any maintainer guidelines I should be aware of.  I have read
emacs/CONTRIBUTE and elpa/README.  Would persist.el maintainership
require subscribing to the mailing list?

Thank you!

Joseph

bug#65768: Bump persist.el version

[Eli Zaretskii]

> From: Joseph Turner <joseph@breatheoutbreathe.in>
> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Cc: Stefan Kangas <stefankangas@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
>  65768@debbugs.gnu.org
> Date: Tue, 31 Oct 2023 08:41:55 -0700
> 
> phillip.lord@russet.org.uk writes:
> 
> > Would you be interested in taking over maintainership of persist? I am
> > very short of Emacs time these days.
> 
> Yes, I am interested!  Stefan, Eli, what do you think?

I can only welcome you.  Thanks for volunteering!

> Stefan, before I commit to maintainership of persist, please let me know
> of any maintainer guidelines I should be aware of.  I have read
> emacs/CONTRIBUTE and elpa/README.  Would persist.el maintainership
> require subscribing to the mailing list?

From my POV, the only request is to subscribe to
bug-gnu-emacs@gnu.org, so that you see any bug reports about
persist.el.  Otherwise, we will have to forward the reports to you.

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>> Cc: Stefan Kangas <stefankangas@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
>>  65768@debbugs.gnu.org
>> Date: Tue, 31 Oct 2023 08:41:55 -0700
>>
>> phillip.lord@russet.org.uk writes:
>>
>> > Would you be interested in taking over maintainership of persist? I am
>> > very short of Emacs time these days.
>>
>> Yes, I am interested!  Stefan, Eli, what do you think?
>
> I can only welcome you.  Thanks for volunteering!

Thank you :)

>> Stefan, before I commit to maintainership of persist, please let me know
>> of any maintainer guidelines I should be aware of.  I have read
>> emacs/CONTRIBUTE and elpa/README.  Would persist.el maintainership
>> require subscribing to the mailing list?
>
> From my POV, the only request is to subscribe to
> bug-gnu-emacs@gnu.org, so that you see any bug reports about
> persist.el.  Otherwise, we will have to forward the reports to you.

Sounds good.  I am subscribed to bug-gnu-emacs@gnu.org.

Joseph

bug#65768: Bump persist.el version

[Stefan Kangas]

Joseph Turner <joseph@breatheoutbreathe.in> writes:

>>> Yes, I am interested!  Stefan, Eli, what do you think?
>>
>> I can only welcome you.  Thanks for volunteering!
>
> Thank you :)

Indeed, welcome and thanks.

Perhaps before releasing v0.6, it would make sense to update the
Maintainer header comment to reflect that you're now the maintainer?
If you agree, feel free to send a patch.

bug#65768: Bump persist.el version

[phillip.lord]

On 2023-10-31 17:05, Joseph Turner wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
> 
>>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>>> Cc: Stefan Kangas <stefankangas@gmail.com>, Eli Zaretskii 
>>> <eliz@gnu.org>,
>>>  65768@debbugs.gnu.org
>>> Date: Tue, 31 Oct 2023 08:41:55 -0700
>>> 
>>> phillip.lord@russet.org.uk writes:
>>> 
>>> > Would you be interested in taking over maintainership of persist? I am
>>> > very short of Emacs time these days.
>>> 
>>> Yes, I am interested!  Stefan, Eli, what do you think?
>> 
>> I can only welcome you.  Thanks for volunteering!
> 
> Thank you :)


And thank you indeed! I will be very interested to see where you take 
persist.

Phil

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

Stefan Kangas <stefankangas@gmail.com> writes:

> Perhaps before releasing v0.6, it would make sense to update the
> Maintainer header comment to reflect that you're now the maintainer?
> If you agree, feel free to send a patch.

Sounds good!  Please see attached patches.

Thank you!

Joseph


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Update-Maintainer-header.patch --]
[-- Type: text/x-diff, Size: 687 bytes --]

From ada801226c3a64d02e5178280614f513eab0f911 Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Sat, 11 Nov 2023 20:24:54 -0800
Subject: [PATCH 1/2] Update Maintainer header

---
 persist.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/persist.el b/persist.el
index e43171459e..26b8b84e2e 100644
--- a/persist.el
+++ b/persist.el
@@ -3,7 +3,7 @@
 ;; Copyright (C) 2019 Free Software Foundation, Inc.
 
 ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
-;; Maintainer: Phillip Lord <phillip.lord@russet.org.uk>
+;; Maintainer: Joseph Turner <persist-el@breatheoutbreathe.in>
 ;; Package-Type: multi
 ;; Version: 0.5
 
-- 
2.41.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-Bump-version.patch --]
[-- Type: text/x-diff, Size: 654 bytes --]

From ff168c39915f1dd3ce475ce33dfea5280746148d Mon Sep 17 00:00:00 2001
From: Joseph Turner <joseph@breatheoutbreathe.in>
Date: Tue, 5 Sep 2023 19:13:06 -0700
Subject: [PATCH 2/2] Bump version

---
 persist.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/persist.el b/persist.el
index 26b8b84e2e..19ad8bd871 100644
--- a/persist.el
+++ b/persist.el
@@ -5,7 +5,7 @@
 ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
 ;; Maintainer: Joseph Turner <persist-el@breatheoutbreathe.in>
 ;; Package-Type: multi
-;; Version: 0.5
+;; Version: 0.6
 
 ;; The contents of this file are subject to the GPL License, Version 3.0.
 
-- 
2.41.0

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

phillip.lord@russet.org.uk writes:

> On 2023-10-31 17:05, Joseph Turner wrote:
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>>>> From: Joseph Turner <joseph@breatheoutbreathe.in>
>>>> Cc: Stefan Kangas <stefankangas@gmail.com>, Eli Zaretskii
>>>> <eliz@gnu.org>,
>>>>  65768@debbugs.gnu.org
>>>> Date: Tue, 31 Oct 2023 08:41:55 -0700
>>>> phillip.lord@russet.org.uk writes:
>>>>  > Would you be interested in taking over maintainership of
>>>> persist? I am
>>>> > very short of Emacs time these days.
>>>> Yes, I am interested!  Stefan, Eli, what do you think?
>>> I can only welcome you.  Thanks for volunteering!
>> Thank you :)
>
>
> And thank you indeed! I will be very interested to see where you take
> persist.

Thank you, Phil!!

bug#65768: Bump persist.el version

[Stefan Kangas]

Joseph Turner <joseph@breatheoutbreathe.in> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Perhaps before releasing v0.6, it would make sense to update the
>> Maintainer header comment to reflect that you're now the maintainer?
>> If you agree, feel free to send a patch.
>
> Sounds good!  Please see attached patches.
>
> Thank you!
>
> Joseph

Sorry for the belayed reply here.

I was about to install this, when I noticed that this package is
actually maintained as an external package at:

    https://gitlab.com/phillord/persist

So I guess the easiest option is to continue running it externally,
unless you want to move its maintenance to elpa.git, in which case we
can arrange that.

If you want to maintain it externally, I guess Philip would either hand
over that repository to you, or you would have to create a new one.

Thoughts?

bug#65768: Bump persist.el version

[phillip.lord]

On 2024-01-10 21:39, Stefan Kangas wrote:
> Joseph Turner <joseph@breatheoutbreathe.in> writes:
> 
>> Stefan Kangas <stefankangas@gmail.com> writes:
>> 
>>> Perhaps before releasing v0.6, it would make sense to update the
>>> Maintainer header comment to reflect that you're now the maintainer?
>>> If you agree, feel free to send a patch.
>> 
>> Sounds good!  Please see attached patches.
>> 
>> Thank you!
>> 
>> Joseph
> 
> Sorry for the belayed reply here.
> 
> I was about to install this, when I noticed that this package is
> actually maintained as an external package at:
> 
>     https://gitlab.com/phillord/persist
> 
> So I guess the easiest option is to continue running it externally,
> unless you want to move its maintenance to elpa.git, in which case we
> can arrange that.
> 
> If you want to maintain it externally, I guess Philip would either hand
> over that repository to you, or you would have to create a new one.
> 


I am very easy any way. If you want me to give full maintainer control 
to someone on the gitlab repo, just let me know. Or if you want to move 
the repo elsewhere or just use ELPA, then I will archive the gitlab 
repo.

Phil

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

phillip.lord@russet.org.uk writes:

> On 2024-01-10 21:39, Stefan Kangas wrote:
>> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>>
>>> Stefan Kangas <stefankangas@gmail.com> writes:
>>>
>>>> Perhaps before releasing v0.6, it would make sense to update the
>>>> Maintainer header comment to reflect that you're now the maintainer?
>>>> If you agree, feel free to send a patch.
>>> Sounds good!  Please see attached patches.
>>> Thank you!
>>> Joseph
>> Sorry for the belayed reply here.
>> I was about to install this, when I noticed that this package is
>> actually maintained as an external package at:
>>     https://gitlab.com/phillord/persist
>> So I guess the easiest option is to continue running it externally,
>> unless you want to move its maintenance to elpa.git, in which case we
>> can arrange that.
>> If you want to maintain it externally, I guess Philip would either
>> hand
>> over that repository to you, or you would have to create a new one.
>>
>
>
> I am very easy any way. If you want me to give full maintainer control
> to someone on the gitlab repo, just let me know. Or if you want to
> move the repo elsewhere or just use ELPA, then I will archive the
> gitlab repo.
>
> Phil

I would prefer to move over to elpa.git.

Thank you for your flexibility!

Joseph

bug#65768: Bump persist.el version

[phillip.lord]

On 2024-01-12 09:15, Joseph Turner wrote:
> phillip.lord@russet.org.uk writes:
> 
>> On 2024-01-10 21:39, Stefan Kangas wrote:
>>> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>>> 
>>>> Stefan Kangas <stefankangas@gmail.com> writes:
>>>> 
>>>>> Perhaps before releasing v0.6, it would make sense to update the
>>>>> Maintainer header comment to reflect that you're now the 
>>>>> maintainer?
>>>>> If you agree, feel free to send a patch.
>>>> Sounds good!  Please see attached patches.
>>>> Thank you!
>>>> Joseph
>>> Sorry for the belayed reply here.
>>> I was about to install this, when I noticed that this package is
>>> actually maintained as an external package at:
>>>     https://gitlab.com/phillord/persist
>>> So I guess the easiest option is to continue running it externally,
>>> unless you want to move its maintenance to elpa.git, in which case we
>>> can arrange that.
>>> If you want to maintain it externally, I guess Philip would either
>>> hand
>>> over that repository to you, or you would have to create a new one.
>>> 
>> 
>> 
>> I am very easy any way. If you want me to give full maintainer control
>> to someone on the gitlab repo, just let me know. Or if you want to
>> move the repo elsewhere or just use ELPA, then I will archive the
>> gitlab repo.
>> 
>> Phil
> 
> I would prefer to move over to elpa.git.
> 
> Thank you for your flexibility!


That's fine. Let me know when you are ready and I will archive gitlab!

Phil

bug#65768: Bump persist.el version

[Stefan Kangas]

Joseph Turner <joseph@breatheoutbreathe.in> writes:

>> I am very easy any way. If you want me to give full maintainer control
>> to someone on the gitlab repo, just let me know. Or if you want to
>> move the repo elsewhere or just use ELPA, then I will archive the
>> gitlab repo.
>
> I would prefer to move over to elpa.git.

Thanks, so I changed it to be maintained in elpa.git, and installed your
patches there.

Phil, I think you can archive the old repository at your convenience.

I'm therefore closing this bug report.

bug#65768: Bump persist.el version

[Stefan Kangas]

BTW, I see the following warnings from package-lint:

1:64: warning: You should depend on (emacs "24.1") if you need lexical-binding.
228:51: error: You should depend on (emacs "26.1") if you need `recordp'.
233:64: error: You should depend on (emacs "26.1") if you need `recordp'.
236:53: error: You should depend on (emacs "26.1") if you need `recordp'.

Would the below patch be appropriate?

diff --git a/persist.el b/persist.el
index 2b96b2b7f0..6cc94b4db3 100644
--- a/persist.el
+++ b/persist.el
@@ -5,6 +5,7 @@
 ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
 ;; Maintainer: Joseph Turner <persist-el@breatheoutbreathe.in>
 ;; Package-Type: multi
+;; Package-Requires: ((emacs "26.1"))
 ;; Version: 0.6

 ;; The contents of this file are subject to the GPL License, Version 3.0.

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>
>>> I am very easy any way. If you want me to give full maintainer control
>>> to someone on the gitlab repo, just let me know. Or if you want to
>>> move the repo elsewhere or just use ELPA, then I will archive the
>>> gitlab repo.
>>
>> I would prefer to move over to elpa.git.
>
> Thanks, so I changed it to be maintained in elpa.git, and installed your
> patches there.

Thank you!!

> Phil, I think you can archive the old repository at your convenience.
>
> I'm therefore closing this bug report.

bug#65768: Bump persist.el version

[Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> BTW, I see the following warnings from package-lint:
>
> 1:64: warning: You should depend on (emacs "24.1") if you need lexical-binding.
> 228:51: error: You should depend on (emacs "26.1") if you need `recordp'.
> 233:64: error: You should depend on (emacs "26.1") if you need `recordp'.
> 236:53: error: You should depend on (emacs "26.1") if you need `recordp'.
>
> Would the below patch be appropriate?
>
> diff --git a/persist.el b/persist.el
> index 2b96b2b7f0..6cc94b4db3 100644
> --- a/persist.el
> +++ b/persist.el
> @@ -5,6 +5,7 @@
>  ;; Author: Phillip Lord <phillip.lord@russet.org.uk>
>  ;; Maintainer: Joseph Turner <persist-el@breatheoutbreathe.in>
>  ;; Package-Type: multi
> +;; Package-Requires: ((emacs "26.1"))
>  ;; Version: 0.6
>
>  ;; The contents of this file are subject to the GPL License, Version 3.0.

LGTM.  Thank you!

Joseph