From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59272: [PATCH] Make Memory Human Readable in proced Buffers Date: Mon, 14 Nov 2022 19:40:31 -0800 Message-ID: References: <87a64sew18.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22338"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59272@debbugs.gnu.org To: Visuwesh , Laurence Warne Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 15 04:41:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oumox-0005bk-Ns for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Nov 2022 04:41:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oumoq-0006Qj-NP; Mon, 14 Nov 2022 22:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oumoo-0006NE-RO for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 22:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oumoo-0007WT-Gp for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 22:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oumoo-0007NX-05 for bug-gnu-emacs@gnu.org; Mon, 14 Nov 2022 22:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2022 03:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59272-submit@debbugs.gnu.org id=B59272.166848364028321 (code B ref 59272); Tue, 15 Nov 2022 03:41:01 +0000 Original-Received: (at 59272) by debbugs.gnu.org; 15 Nov 2022 03:40:40 +0000 Original-Received: from localhost ([127.0.0.1]:52446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oumoR-0007Mi-KX for submit@debbugs.gnu.org; Mon, 14 Nov 2022 22:40:39 -0500 Original-Received: from mail-oi1-f172.google.com ([209.85.167.172]:34403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oumoP-0007MT-Kc for 59272@debbugs.gnu.org; Mon, 14 Nov 2022 22:40:38 -0500 Original-Received: by mail-oi1-f172.google.com with SMTP id n205so13627794oib.1 for <59272@debbugs.gnu.org>; Mon, 14 Nov 2022 19:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=/vAHgJH2SJaUJUp7LYLhJ918WzSqp78PWvvrMJIh5Ww=; b=Kys16KFgF1PwraRX3qh4gk33vhefn0TyC7k5++oJ28QQiFZKrxRf54KWeo80Zau1g7 2DXIQV5J8ZXzlIqkFFVgxMhY0txBfg7L8bIjLZ6rSm8Ewf6cFf5Tf5ZuIsotfN4eTwKw WOZmMFWRPU010hlEES3D34gVwBCOdcE/VFGUP+HV9o7O38i2hxSYxltDnLtXFP3eo41r 0wLdbSQ85BKdzn9ctVginY++8K+uiCpLuiN6/1O3/hPB+lWk6MbzhXAwtJRawJl5ExSi lENqRmBuI/6lR++Bius5DKrCNzmeXkJ678gHdDb7WVvyd9Vtld2jB+nJHVzqezZlD07g H4oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/vAHgJH2SJaUJUp7LYLhJ918WzSqp78PWvvrMJIh5Ww=; b=5lOvl3VUVw7+8nBt4d22deidr1sCX9uZoDPTDRQWGnwE9JX2TflIU8GWFtstawlwot xN+ZcUcnEPd2ZJK07mqr1oSZmY0900m10TfxLPNhNlf992TKEtHBSt/q1CeBQ8bE4OBI lwBcS0oYlqX62VdDCXxxW0Cf8xlVc3YxJU84d2qpsAqGFmi4aAf5HqiDyBXPLqbfKNuu Nbka/fa3KhyJO/NRl8vzBK9jk9SLHNzqL0JiqRAvu29jh4iM5qd6oDwK3y3x1eM/Mwcd gbIHwnLLl/tqdGhDicZAxEH4jJsYPJK3hvOZLf/UjeI8c+AjikkJWkHZ8TbCcTJf0B9O lS9w== X-Gm-Message-State: ANoB5pkh8OzcJxqswU/sZSer3nxMOE02RbhStwcVW7Vb7uP/HVdlYR25 ZLllYkCs3l9eKAV2czKzjD33G2bdjyDjpy4Za00= X-Google-Smtp-Source: AA0mqf5t6CfmO3V8Ur8T18Xb2EIyxIEPD9atb2Fw/xhc2njjNnGLOG9hBLvZDUwXprZUct3ijToAEFk3yHEkGzWcVzU= X-Received: by 2002:aca:915:0:b0:35a:ff6c:eb15 with SMTP id 21-20020aca0915000000b0035aff6ceb15mr70226oij.199.1668483631971; Mon, 14 Nov 2022 19:40:31 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 14 Nov 2022 19:40:31 -0800 In-Reply-To: <87a64sew18.fsf@gmail.com> X-Hashcash: 1:20:221115:laurencewarne@gmail.com::pkRzAJEgNJQN5Xmb:B9/X X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247907 Archived-At: Visuwesh writes: > [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE= =A8=E0=AE=B5=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 14, 2022] Laurenc= e Warne wrote: > >> Hi, this patch makes vsize and rss human readable in proced buffers by >> formatting them as megabytes or gigabytes according to their size, simil= ar >> as the -h flag for ls and du. >> >> The current behaviour is to show them always as kilobytes, though I'm >> unsure if this meant as 1000 bytes or 1024 bytes, this patch assumes the >> former case. > > We can leave this to the user to decide by... > >> +(defun proced-format-memory (kilobytes) >> + "Format KILOBYTES in a human readable format." > > ... using `file-size-human-readable' instead. Yes, we could do something like (defcustom proced-format-memory-function #'file-size-human-readable "..." ) Where one of the options is #'identity, which means not to use human readable sizes, and then funcall that.