From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted Date: Sat, 26 Aug 2023 13:57:22 +0200 Message-ID: References: <61352d45-21a6-466b-be7b-7755a6260356@gmail.com> <83a5uemfxy.fsf@gnu.org> <87o7iutg4i.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12607"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrey Samsonov , Eli Zaretskii , Stefan Monnier , 65475@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 26 13:58:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZrvk-000379-4Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Aug 2023 13:58:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZrvT-0005Rr-3C; Sat, 26 Aug 2023 07:57:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZrvR-0005RZ-G6 for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 07:57:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZrvR-0003Zv-8F for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 07:57:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZrvW-0002CQ-4t for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 07:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Aug 2023 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65475 X-GNU-PR-Package: emacs Original-Received: via spool by 65475-submit@debbugs.gnu.org id=B65475.16930510698430 (code B ref 65475); Sat, 26 Aug 2023 11:58:02 +0000 Original-Received: (at 65475) by debbugs.gnu.org; 26 Aug 2023 11:57:49 +0000 Original-Received: from localhost ([127.0.0.1]:41813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZrvI-0002Bu-Vn for submit@debbugs.gnu.org; Sat, 26 Aug 2023 07:57:49 -0400 Original-Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:62743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZrvF-0002Bf-9D for 65475@debbugs.gnu.org; Sat, 26 Aug 2023 07:57:47 -0400 Original-Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4ffa01fc987so3277116e87.1 for <65475@debbugs.gnu.org>; Sat, 26 Aug 2023 04:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693051054; x=1693655854; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SeWk3FOB2YrGAsg9T5j7I+ZvSPU895sazY9Qzp9dt8o=; b=EdnVtnL0o8JRxBHK6x5BEcdc7mmQaT4rBlVy1saevFeHJhrNimGXpGncds/tFMi0hy ubzmUJfr/h7tM/bhGSecsBcD5b32wXLCzwqNLw6D01qfs1C96A06etmDuHDa43c9AgKW viyBMgVtuR0bjW7BPkJeQkp5zDrGAUmQ6JDv8/cYk0TOwUGXZ8kjNQvn/GvZTskKjVeh PTbXiTqPAMOPUrnDf4GA+gfnn1uibqqjOa2yL8SDVhamz+rCHaU9+YXROxaE6ECv/AuN nRt7vstBk6VNuOsq2gegjzFOh9gA3Lb8tGSj2iKIe9gDDizsATTvtb4d+IZgigE/nBFX C2fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693051054; x=1693655854; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SeWk3FOB2YrGAsg9T5j7I+ZvSPU895sazY9Qzp9dt8o=; b=jGxOwCYQg1rvPIdsc+0zYRLBkVUOaCrF5O34ESYdy0L5OsBMU6v/iLB+AqIeXlJZSU bnGUs1bQ9KegcLAu+O1l8kL1dBdv6j8Yi9RQWNgxgAco1JFkGyPEeeDxqjM/tv2wTVrK 4q+G/uhL9+9WrZcBJlzGBhgNlj1GOxzpVq19KCGp8SEqbl/SVzG5/bUJhxs3uORpzPhn inL4DVJll782kD3SPDfxjNpkihqw1zn5cw77qpZ2lzj63P0zmNPjDilWeXq3MKEQoX2X ciGxHedwHTQE0ldWK7Fg83rcnj/yxy4e64JfITIaMaCQQR3Z3PGvBt4nwZl80tTGACbB hg4Q== X-Gm-Message-State: AOJu0YxED2bu1isAoYONLbjbNly+RgbT4YYloFDHUkqunu3dR/1lTyAg FegRzO10u2StfQf2faJjRNQzrW6b2vnXmyRVEe8= X-Google-Smtp-Source: AGHT+IG2AXrOQkRweE8uTlvCPwTmUS955ax6Km5Rbi015StHACoCe+Tgfkite2/Kmu6u8MEy1/zlUWj/BiYPUK2fVIY= X-Received: by 2002:ac2:4e01:0:b0:4f9:56b8:45e5 with SMTP id e1-20020ac24e01000000b004f956b845e5mr8133010lfr.25.1693051053767; Sat, 26 Aug 2023 04:57:33 -0700 (PDT) In-Reply-To: <87o7iutg4i.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268499 Archived-At: > The issue here is that `package--save-selected-packages' only updates > the value of `package-selected-packages', if the new value is non-nil, > presumably because the VALUE argument is optional, This was added in d0a5162fd825, fixing Bug#20855. Personally, I'm not a huge fan of that fix, as nil is clearly a valid (if infrequent) value here. Could something like this work? diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index e1172d69bf0..9f97f950e64 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -1982,7 +1982,7 @@ package--find-non-dependencies (defun package--save-selected-packages (&optional value) "Set and save `package-selected-packages' to VALUE." - (when value + (when (or value after-init-time) (setq package-selected-packages value)) (if after-init-time (customize-save-variable 'package-selected-packages package-selected-packages)