From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#17052: substitute-command-keys strips text properties Date: Sun, 18 Aug 2019 19:08:18 +0200 Message-ID: References: <871rxns0vz.fsf@mouse.gnus.org> <1xh86jb494.fsf@fencepost.gnu.org> <87tvaj6vfi.fsf@mouse.gnus.org> <83sgq2peb5.fsf@gnu.org> <87h86iuk39.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="262608"; mail-complaints-to="usenet@blaine.gmane.org" Cc: lekktu@gmail.com, 8951@debbugs.gnu.org, 17052@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 18 19:09:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzOg8-0016CA-G4 for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 19:09:16 +0200 Original-Received: from localhost ([::1]:42190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzOg6-0002yK-Rq for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 13:09:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42258) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzOfy-0002wK-6t for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:09:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzOfx-0002Dg-7u for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:09:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzOfx-0002DZ-4b for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:09:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzOfu-0001DY-3x for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 13:09:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2019 17:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17052 X-GNU-PR-Package: emacs Original-Received: via spool by 17052-submit@debbugs.gnu.org id=B17052.15661481174643 (code B ref 17052); Sun, 18 Aug 2019 17:09:02 +0000 Original-Received: (at 17052) by debbugs.gnu.org; 18 Aug 2019 17:08:37 +0000 Original-Received: from localhost ([127.0.0.1]:58474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOfV-0001Co-2v for submit@debbugs.gnu.org; Sun, 18 Aug 2019 13:08:37 -0400 Original-Received: from mail-pf1-f194.google.com ([209.85.210.194]:35596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzOfT-0001CY-NG; Sun, 18 Aug 2019 13:08:36 -0400 Original-Received: by mail-pf1-f194.google.com with SMTP id d85so5749031pfd.2; Sun, 18 Aug 2019 10:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JMFcqfbFuqHfFnXTrc3nd1wja1ihRkoSAwWLaMWR0BE=; b=Ut12Uf9JcQqrOip48Uz6t3p07TwkxGrzPxdiZHyVZ5tItQr1lbeN/YF3ZhRYzbiESB 5OMivx3JCI/IZv97wIAxVzsPpki8kqlabPbDpQazh0WPjIIp84LA9KGnepe1wIMdbOUr DGUutEmcz+qZnNYqrrc6FGQRIG09Sf0WFDr0Gtlwe7WVCOJ+SSIvs3NBo65hOF01wjik kDfSr2SdZXxB/ZIcxCp1l2lUrr6JVbITgaHiRfHVN1EEfA9y1cU++iCeED9fyq4CHMLR NVcS+0gLxdZdNc6F/Ps3+huTNDGXcrfbTvlDv16PyEhKkP6swqikAhMfMReUakuxav5T GUMg== X-Gm-Message-State: APjAAAU+yQbLP+lvI5zvT2AMVJVeqWCBB08gs8pzHco7mvo0KiOy53TV WYqZwz7j3bp0nojKgQO7+Ugm1j3vDntZFuy+dfc= X-Google-Smtp-Source: APXvYqyAY3glRKkL3hM+U9V+WjNIECBi8VmLyCAkGPYFl4lnxSIR/Zc2aIw7hu69R8UJJNkpBRvCDHQchzr7k6XBjUc= X-Received: by 2002:a62:7789:: with SMTP id s131mr20360678pfc.50.1566148110116; Sun, 18 Aug 2019 10:08:30 -0700 (PDT) In-Reply-To: <87h86iuk39.fsf@mouse.gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165341 Archived-At: [In reply to Bug#17052 and cross-posting to Bug#8951.] Lars Ingebrigtsen writes: > I had a look at that function now and, er, no. :-) Perhaps it should > be rewritten in Emacs Lisp? Then it'd be pretty trivial to fix this > stuff. The Fsubstitute_command_keys function is indeed a bit hairy, and I agree that a conversion to Lisp is the most reasonable next step. I've actually been working a patch to convert it to Lisp for Bug#8951, but it's not finished yet. The difficulty is that it has a couple of helper functions that also needs to be lifted, which makes the job bigger than just the function Fsubstitute_command_keys. My goal is to get the Lisp version to produce the same output as the C version, which currently seems to be a feasible goal. Once it's in Lisp it should be easier to make further improvements, fix bugs, etc. Thanks, Stefan Kangas