From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44471: [PATCH] Simplify text-quoting-style Date: Wed, 11 Nov 2020 14:12:24 -0500 Message-ID: References: <87zh3qjzh3.fsf@gnus.org> <831rh12ntc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1081"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 44471@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 11 20:21:53 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcvgn-00007X-19 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Nov 2020 20:21:53 +0100 Original-Received: from localhost ([::1]:52968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcvgl-0008Mp-RL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Nov 2020 14:21:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcvYE-0005j8-28 for bug-gnu-emacs@gnu.org; Wed, 11 Nov 2020 14:13:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcvYD-0003EY-Oj for bug-gnu-emacs@gnu.org; Wed, 11 Nov 2020 14:13:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcvYD-0006Td-Ka for bug-gnu-emacs@gnu.org; Wed, 11 Nov 2020 14:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Nov 2020 19:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 44471-submit@debbugs.gnu.org id=B44471.160512195324861 (code B ref 44471); Wed, 11 Nov 2020 19:13:01 +0000 Original-Received: (at 44471) by debbugs.gnu.org; 11 Nov 2020 19:12:33 +0000 Original-Received: from localhost ([127.0.0.1]:42850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcvXl-0006Sv-Eq for submit@debbugs.gnu.org; Wed, 11 Nov 2020 14:12:33 -0500 Original-Received: from mail-ej1-f47.google.com ([209.85.218.47]:46610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcvXi-0006Sh-Ur for 44471@debbugs.gnu.org; Wed, 11 Nov 2020 14:12:31 -0500 Original-Received: by mail-ej1-f47.google.com with SMTP id w13so4205182eju.13 for <44471@debbugs.gnu.org>; Wed, 11 Nov 2020 11:12:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=aRn4RbSZJUGSr3wrsU0+tIBn0kIZmPDN5bJm5nc/Fv0=; b=Pkigzsb8ajGx9HkILvXToAwqUx7zpTRE78FKzrBA4SQrbwEn8gspTAPJcwJjPqH4E+ pbhE9JdLqNBRC8jJGettuOyacd687Z6CZBlc/5MnLYRLnbch1vLKhbFcn4tbv62B0wr2 9UvekKIZ0GPUfvqsuORBaRvJMAoVACCz7CY0ILM3W8eHPnKfHxnvxJtdT0JjK4R86uJ2 QMwZnaKehLM7ghRP/orrRqTzEV+LtH6G7f+wXtZcDLBjUA+Qps/iz/JNDQNrCIy0t2yF 5eONJoW9PiglwDIrsXNvE6DzTzXOrfPvs083GMBT5cxKeERoCL+FwjVCTboKwFvsQZaA 5ZCQ== X-Gm-Message-State: AOAM531HzX5StH4OK9Obiu3v8XDtkBPCAAlAp1tlapC2Ogezfh1eXgC6 b41rkSh4rVzToge29pljF0ZSCWmVJXswUXqJD7g= X-Google-Smtp-Source: ABdhPJxbMeAPSswu1QnxaorNerb40K+2xh5AaiYhwZ42xhl3kBAHYYHjkPPBk5epin6Z2GO5/epv1J3A8J+OD93MsFc= X-Received: by 2002:a17:906:1246:: with SMTP id u6mr26351503eja.432.1605121945122; Wed, 11 Nov 2020 11:12:25 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 11 Nov 2020 14:12:24 -0500 In-Reply-To: <831rh12ntc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193127 Archived-At: Eli Zaretskii writes: > Please in the future allow more than just a couple of days for people > to comment on non-trivial patches. OK. > As it happens, I do have a few issues with the change: > > . it slows down code of two very popular functions, because we now > use EQ instead of a C-level equality operator; If I understand correctly, EQ(x, y) ends up in a C-level equality operator and a typecast. Is that correct? If yes, is it the typecast that you think will cause a slowdown, or is it something else? I naively thought that this would not make much of a difference, and that, to the extent that it did, the relevant functions are hardly called often enough to matter in the end. But I assume you know more than me here, so please tell me where I'm wrong. > . it introduces a function that has the same name as a variable, > which adds a bit to confusion, and also defeats our method of > reporting in what version was the function/variable introduced > (try "C-h f"); and This is not without precedent, see e.g. `user-full-name'. But if we want to keep my patch we could of course just use the previous name `get-text-style' instead. > . I don't think I see the simplification that justifies these > (admittedly quite minor) downsides I agree it is minor, but I see one function less, one less enum, and overall fewer lines of code. I'm happy to revert it if the change is not wanted.