unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Juri Linkov <juri@linkov.net>, 41410@debbugs.gnu.org
Cc: ej32u@protonmail.com
Subject: bug#41410: Patch: Add function ffap-other-tab
Date: Sun, 24 May 2020 15:26:31 -0700	[thread overview]
Message-ID: <CADwFkm=AbeJmmhmvHWjtJ=QGfUSJiK78bgi2nVFnpVemoh3O1Q@mail.gmail.com> (raw)
In-Reply-To: <87d06tugyl.fsf@mail.linkov.net>

Juri Linkov <juri@linkov.net> writes:

>>> Attached is a patch to add a function to open files at point in another
>>> tab. It is basically the same as the function ffap-other-window.
>>>
>>> +(defun ffap-other-tab (filename)
>>> +  "Like `ffap', but put buffer in another tab.
>>> +Only intended for interactive use."
>>> +  (interactive (list (ffap-prompter nil " other tab")))
>>> +  (pcase (save-window-excursion (find-file-at-point filename))
>>> +    ((or (and (pred bufferp) b) `(,(and (pred bufferp) b) . ,_))
>>> +     (switch-to-buffer-other-tab b))))
>>> +
>>>  (defun ffap--toggle-read-only (buffer-or-list)
>>>    (dolist (buffer (if (listp buffer-or-list)
>>>  		      buffer-or-list
>>> @@ -2013,6 +2023,7 @@ ffap-bindings
>>>
>>>       (global-set-key [remap find-file-other-window] 'ffap-other-window)
>>>       (global-set-key [remap find-file-other-frame] 'ffap-other-frame)
>>> +     (global-set-key [remap find-file-other-tab] 'ffap-other-tab)
>>>       (global-set-key [remap find-file-read-only-other-window] 'ffap-read-only-other-window)
>>>       (global-set-key [remap find-file-read-only-other-frame] 'ffap-read-only-other-frame)
>>
>> Thanks, this is a useful addition.  Please push it to master.
>
> Maybe someone could check if this requires papers and
> could push it to master when I'm away from computer.

OK.

I could find no previous commit by ej32u@protonmail.com, and this patch
is only 11 lines.  I therefore believe we could safely install it as
Copyright-paperwork-exempt.  Unless anyone disagrees with that analysis,
I'll push this to master in the next couple of days.

Best regards,
Stefan Kangas





  reply	other threads:[~2020-05-24 22:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 21:43 bug#41410: Patch: Add function ffap-other-tab ej32u--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-05-19 22:31 ` Juri Linkov
2020-05-24 22:05   ` Juri Linkov
2020-05-24 22:26     ` Stefan Kangas [this message]
2020-05-25  0:46       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=AbeJmmhmvHWjtJ=QGfUSJiK78bgi2nVFnpVemoh3O1Q@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=41410@debbugs.gnu.org \
    --cc=ej32u@protonmail.com \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).