From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists Date: Fri, 25 Nov 2022 12:34:38 +0100 Message-ID: References: <87wn7ujpdh.fsf@web.de> <83edtz84wl.fsf@gnu.org> <87pmdctsf8.fsf@web.de> <83edtswi35.fsf@gnu.org> <87fse8tona.fsf@web.de> <83cz9cwg5z.fsf@gnu.org> <87bkowtmmr.fsf@web.de> <83a64gwfhv.fsf@gnu.org> <877czktlvr.fsf@web.de> <838rk0wak3.fsf@gnu.org> <87wn7jfjrg.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18382"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , jonas@bernoul.li, 59328@debbugs.gnu.org, larsi@gnus.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 12:35:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyWzH-0004cu-DP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 12:35:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyWz3-0007NJ-EC; Fri, 25 Nov 2022 06:35:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyWz0-0007Mr-Gp for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 06:35:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyWz0-0004Ol-1b for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 06:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyWyz-0000Of-S2 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 06:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 11:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59328 X-GNU-PR-Package: emacs Original-Received: via spool by 59328-submit@debbugs.gnu.org id=B59328.16693760971511 (code B ref 59328); Fri, 25 Nov 2022 11:35:01 +0000 Original-Received: (at 59328) by debbugs.gnu.org; 25 Nov 2022 11:34:57 +0000 Original-Received: from localhost ([127.0.0.1]:33734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyWyv-0000OI-2F for submit@debbugs.gnu.org; Fri, 25 Nov 2022 06:34:57 -0500 Original-Received: from mail-oi1-f181.google.com ([209.85.167.181]:40717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyWyt-0000O5-La for 59328@debbugs.gnu.org; Fri, 25 Nov 2022 06:34:55 -0500 Original-Received: by mail-oi1-f181.google.com with SMTP id n186so4112068oih.7 for <59328@debbugs.gnu.org>; Fri, 25 Nov 2022 03:34:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HO9H08x/LHZF6bBeIMyaG5hqKbRbT+UJTWvqE3A/iYc=; b=HDiJ2mJiU2fwnyBDUP2qXrGNliF0IhyQGtj2CqEvkR3bkm21AMSHq3Lhyvbgnly9+/ kgJkUsgNNBUpzbL2IVmQ4ScZ/CqSf3CC6n8QvxL+Ka2d6/+RRnREhuwu+dE1t5dv0GA8 rL5Sv2vHpk26g2EUPpHLcSXq0PDNFHV4V8DIPOCw5I50uG7s6Air3w3xW0iiSi43WRko EdhADEFvBCmF01f7x59iqnyBwo4gcVzRdSNJsq5qykkIFjHCeFuR7An0fayrf0dxSQhf PkevD+M//DZIWI69pCHQi11YPlePmE+IkgelFPFqzMbVYMqfiVSDa/XUWYA5BFMsnYAA ClzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HO9H08x/LHZF6bBeIMyaG5hqKbRbT+UJTWvqE3A/iYc=; b=V2O6wAawTNoVKJ3K2h06V8v61T1t01BqTVgFZm4MM2O7bMPbpY3b+XijN6KQ6Sfc4A g8NGmhq4DK8jMzD5DOMKBcdlArnLwVNQaxP5723ztJEiTad0C3QCleNmmzLhf42gDRiE PeoWzWNahu9vZwndus2piIkZHCXzeFOAzo6WwTcle6PXKzg5XuiO2pOM31A9MGYlnahI 19EGGMEk5bboQUvyZYYghK5RYth5IwcncY9qqMWDWL6xYeKebtWAAq6kOYd4aUp/volf BuPzlbEhy8YUF2bsllI6vHExONp1e+KADP6wnQ9ku+MvbvlSEa8eKX08YRpfZuh0e73i 35wQ== X-Gm-Message-State: ANoB5pnHS1V7dIj5eHa7teDj1UOJpwinltPzoZcc7HvWqwhZ2DgU4Fdq 7C9Z5kZyeGZcIW9Kf7fQTU37p7JqHTY4Ks5jEms= X-Google-Smtp-Source: AA0mqf45GjycRLgH6Up/ch2nTMmkszZ0EGWkM/qCCo8CV0qs77bm0jVeXkWjjMJbF4aoHuiWKhfOd+LlUtFBKrUliwg= X-Received: by 2002:a05:6808:1287:b0:359:dc32:4f9e with SMTP id a7-20020a056808128700b00359dc324f9emr9708193oiw.92.1669376089863; Fri, 25 Nov 2022 03:34:49 -0800 (PST) In-Reply-To: <87wn7jfjrg.fsf@web.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248990 Archived-At: Michael Heerdegen writes: > #+begin_src emacs-lisp > (progn > (defvar gensym) > (let ((gensym (make-symbol "foo"))) > (eval `(cl-defmethod seq-map (function (thing (head ,gensym))) > (append (list (car thing) (cadr thing)) (seq-map function (cddr thing)))) > t) > (equal (list gensym nil 4 46) > (seq-keep (lambda (x) (and (integerp x) (* 2 x))) > (list gensym nil 2 'x gensym 23))))) > #+end_src > > returns t with my patch installed and nil else and works without relying > on something external. I'm not sure if defining methods (for seq-map in > this case) that are globally visible is allowed in tests, so I > implemented the example above in a way that the change of the generic > function is not visible from the outside (thus the "secret" gensym). We allow things that are globally visible, yes, as that will only affect testing sessions. So I think dropping the gensym will be an improvement. > Would something like that be acceptable? Makes sense to me. Perhaps we should do something similar for other seq.el tests.