From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#56969: Should erc--download-directory be named eww--download-directory? Date: Thu, 4 Aug 2022 08:49:16 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18301"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen To: 56969@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 04 10:51:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJWZv-0004cT-Dy for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Aug 2022 10:51:39 +0200 Original-Received: from localhost ([::1]:33416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJWZt-0000ZA-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Aug 2022 04:51:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJWYN-0000W2-34 for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 04:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJWYM-0007tK-O7 for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 04:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJWYM-0001qX-CV; Thu, 04 Aug 2022 04:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Aug 2022 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56969 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.16596029737051 (code B ref -1); Thu, 04 Aug 2022 08:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Aug 2022 08:49:33 +0000 Original-Received: from localhost ([127.0.0.1]:51119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWXp-0001pc-KH for submit@debbugs.gnu.org; Thu, 04 Aug 2022 04:49:33 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:48898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWXk-0001pQ-Cu for submit@debbugs.gnu.org; Thu, 04 Aug 2022 04:49:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJWXk-0000TQ-42 for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 04:49:24 -0400 Original-Received: from mail-ua1-f46.google.com ([209.85.222.46]:39652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJWXe-0007jG-HS for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 04:49:23 -0400 Original-Received: by mail-ua1-f46.google.com with SMTP id c19so7989301uat.6 for ; Thu, 04 Aug 2022 01:49:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=F0iWB03VKW9qSgOV5OQX1QXw5+vb9mOHpcrrhOAgjmo=; b=aBCSfBMNUYzlUPnA2TNXdHsTK1R59q7hPbk4MrOlRriPMwYOboRzeMSumpfpu+5Blb lSfBGUbSLMrkzmX+rGKPG8qx5rttsw5GUezIexvTtLJb3GMLBqatZKOQvNsVplTiS2th 16IdW1jpbbs7U9h6fSU5+SusgCVAuTjmJvrL/w09D0IUDL3gL9kYfk4IS3cu0Aizs/3k G4d5Ns7Z14PXw6tR9gPIZWBqDJRHD56Da6BuxS+0h00eRpt/fJNQNXL7sw+JlYoV+igc baZCDfLZLEWoQw6b97k+GK00N0r5geSTjYHkMTW0DhIYEpA1+X4mMl9FD+aDjmXfGajn kzsw== X-Gm-Message-State: ACgBeo3ZWCpyI/d9dMaNdX4fF2jDXpjgvTCTHeT/FmO4TQXf1QD5yHKi /dno7RfrJOgbGrg9u3oHqQKXH12VE960wqVTzhaYhDxb X-Google-Smtp-Source: AA6agR4fMKu2YhtQebO+SiK5vKhY7PQFTdyDS8Z9pIW7xeTxHIfyHCNzktXFPUB3X4Z8w+F5JSOojf4drqaXxc71Qzc= X-Received: by 2002:ab0:6197:0:b0:387:8e6e:91b8 with SMTP id h23-20020ab06197000000b003878e6e91b8mr281282uan.26.1659602957252; Thu, 04 Aug 2022 01:49:17 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 4 Aug 2022 08:49:16 +0000 Received-SPF: pass client-ip=209.85.222.46; envelope-from=stefankangas@gmail.com; helo=mail-ua1-f46.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238701 Archived-At: Severity: wishlist Lars, is there a particular reason why erc--download-directory in eww.el is named that way? It seems to me that it should be eww--download-directory instead. Is it just a typo? It was added in: commit 76f71e39f583b7f8bb47a47b315f49af6f23886e Author: Lars Ingebrigtsen Date: Wed Jul 29 07:13:56 2020 +0200 Make eww use the XDG download directory * lisp/net/eww.el (erc--download-directory): New function (bug#41030). (eww-download-directory): Use it. (eww-download): Use it. (eww-download-callback): Adjust parameters.