unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Thierry Volpiatto <thierry.volpiatto@gmail.com>
Cc: 18632@debbugs.gnu.org
Subject: bug#18632: 24.3.94; image-dired fail when `image-dired-dir' doesn't exist
Date: Fri, 30 Aug 2019 00:32:52 +0200	[thread overview]
Message-ID: <CADwFkm=9aQNqiuZ_oT2GoP7k7DU45j+cvjBAgRDyE-4YVhrHnA@mail.gmail.com> (raw)
In-Reply-To: <871tqmskw1.fsf@gmail.com>

Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:

>> If `image-dired-dir' doesn't exists, image-dired fail with
>> something like "could not resize image" with no indications on what is happening.
>> IOW image-dired should create its directory when this one doesn't
>> exists, or at least send a helpful message to notify user he have first
>> to create manually this directory.
>
> diff --git a/lisp/image-dired.el b/lisp/image-dired.el
> index 114deab..01f88c2 100644
> --- a/lisp/image-dired.el
> +++ b/lisp/image-dired.el
> @@ -1800,7 +1800,8 @@ should feel snappy enough.
>
>  If optional argument ORIGINAL-SIZE is non-nil, display image in its
>  original size."
> -  (let ((new-file (expand-file-name image-dired-temp-image-file))
> +  (let ((new-file (expand-file-name image-dired-temp-image-file
> +                                    (image-dired-dir)))
>          width height command ret
>          (image-type 'jpeg))
>      (setq file (expand-file-name file))

I can reproduce this on current master.  The problem happens when the
user removes the image-dired-dir directory (normally
~/.emacs.d/image-dired).

Steps to reproduce:

0. emacs -Q
1. C-x C-f ~/my-image-dir
2. (in shell) rm -rf ~/.emacs.d/image-dired/  # value of (image-dired-dir)
3. (in emacs): RET

Now I see the error message "Unable to resize".

However, I think the above patch is only part of the solution.  After
applying it, I can indeed open an image successfully.  But I'm now
seeing a different problem: After opening an image (step 3 above), all
the thumbnails are suddenly missing from the *image-dired* buffer.

I subjectively think that the original error is less severe than the
new one.  Without the fix, at least the images stay as they are in the
*image-dired* buffer.

If anyone disagrees, they could easily install the above patch on
master and we would arguably be no worse off than we are now.  But we
would still need to fix the second problem.

Thanks,
Stefan Kangas





  parent reply	other threads:[~2019-08-29 22:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-05 13:31 bug#18632: 24.3.94; image-dired fail when `image-dired-dir' doesn't exist Thierry Volpiatto
2014-10-05 14:12 ` Thierry Volpiatto
2019-08-29 22:32 ` Stefan Kangas [this message]
2019-08-30  5:34   ` Thierry Volpiatto
2019-08-30 10:39     ` Stefan Kangas
2019-08-30  6:31   ` Eli Zaretskii
2019-08-30 10:41     ` Stefan Kangas
2019-09-26 16:37       ` Lars Ingebrigtsen
2022-09-16  0:39   ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=9aQNqiuZ_oT2GoP7k7DU45j+cvjBAgRDyE-4YVhrHnA@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=18632@debbugs.gnu.org \
    --cc=thierry.volpiatto@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).