From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#47879: [PATCH] Ignore mode hooks when analysing diffs Date: Wed, 21 Apr 2021 09:45:52 -0500 Message-ID: References: <878s5fpg1a.fsf@posteo.net> <837dkztmy0.fsf@gnu.org> <87o8ebz77g.fsf@posteo.net> <83zgxrpvh2.fsf@gnu.org> <87o8e7aemx.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33205"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47879@debbugs.gnu.org To: Philip Kaludercic , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 21 16:47:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lZE8T-0008S6-7b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 16:47:25 +0200 Original-Received: from localhost ([::1]:42126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZE8S-0000aM-C6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Apr 2021 10:47:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZE86-0000LR-Pj for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47832) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lZE86-0001HR-Hz for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lZE86-0003NO-G1 for bug-gnu-emacs@gnu.org; Wed, 21 Apr 2021 10:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Apr 2021 14:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47879 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47879-submit@debbugs.gnu.org id=B47879.161901636612894 (code B ref 47879); Wed, 21 Apr 2021 14:47:02 +0000 Original-Received: (at 47879) by debbugs.gnu.org; 21 Apr 2021 14:46:06 +0000 Original-Received: from localhost ([127.0.0.1]:59373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZE78-0003LS-K0 for submit@debbugs.gnu.org; Wed, 21 Apr 2021 10:46:06 -0400 Original-Received: from mail-pf1-f177.google.com ([209.85.210.177]:43945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lZE74-0003Ko-Gv for 47879@debbugs.gnu.org; Wed, 21 Apr 2021 10:46:02 -0400 Original-Received: by mail-pf1-f177.google.com with SMTP id p67so24098167pfp.10 for <47879@debbugs.gnu.org>; Wed, 21 Apr 2021 07:45:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=t7m/tPDATKOBbOclKjRUGn2XAF1ZuCbK9PqMOEl1vaI=; b=OObHBwOzIYZ0axCsJAnNbZrxFTcydA8KI5ZDsrqBnLNgLdexkCGXspiWvDcldELh6G v+j/f0cL8atcuLPN5SJybd1TFCirXgZ9dLclkYgVhp1fswQ6BOlrcP2//HcM23GHIiS7 iP2ahvO5Bti2SIIfrGB0jqUSijByUMmk5f3mvTkH2DF09Nb9ALxnEYPCxbWsPjDDzvt5 pNn4Bkkwh2FKBIy7ESAuifYG89AUubnNG2v1e3fZLV8yhz9Y8JNcLYUheb9ojvOw1tJW mXk4+/GhecYlAeF9SUV+WQGycLVN4xkHTgkdz2lGQhY3zkV4sn9TK8gpzGmjrvMMTDyc QOvw== X-Gm-Message-State: AOAM532bcPvz0mgwCIr1HQ63O5Y+O5HywS6VZcAFN+e+BnDKrt3Ibtah 2p66yiUuW3PdQY5Tbw13dKuoQmQM2oGr3Cosu7A= X-Google-Smtp-Source: ABdhPJy7+EU273ATV/nA/q6A7XvhYcxnJSeTyaIX+n1ZVkXFCuTHSBBZcRjay2acYoJadGb+dx9glECSCkbcsduuQf8= X-Received: by 2002:a17:90b:f0b:: with SMTP id br11mr11368600pjb.179.1619016352656; Wed, 21 Apr 2021 07:45:52 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 21 Apr 2021 09:45:52 -0500 In-Reply-To: <87o8e7aemx.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204624 Archived-At: Philip Kaludercic writes: > Eli Zaretskii writes: > >>> From: Stefan Kangas >>> Date: Wed, 21 Apr 2021 09:12:45 -0500 >>> Cc: Eli Zaretskii , 47879@debbugs.gnu.org >>> >>> >> I rather think that the bug is either in the hook you added or in >>> >> paredit-mode, and should be solved there. >>> > >>> > Ok, I'll try that too. >>> >>> So is this a notabug or a wontfix, or is there more to do here? >> >> Too early to say, I think. Let's give Philip some time to try to fix >> it as I suggested. > > I looked into the code, and Philipp Stephani's suggestion to set > paredit-override-check-parens-function to (lambda (_) t) seems to be the > cleanest solution. I'd say this is not really a bug, but an issue in my > configuration. It might be worth considering sending paredit a patch to > only check the syntax if invoked interactively, but my suggestion was > certainly too broad. Thanks. Should this bug remain open, or can it therefore be closed?