From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 2 Nov 2021 08:26:12 -0700 Message-ID: References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000f038d105cfcfe9f8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28858"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 16:27:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhvgv-0007IW-Fu for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 16:27:13 +0100 Original-Received: from localhost ([::1]:45212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhvgu-0004HY-DD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 11:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40372) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhvgk-0004Dq-5J for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 11:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54527) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhvgj-0000cR-OG for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 11:27:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhvgj-0006IL-Jg for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 11:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 15:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163586678124124 (code B ref 51556); Tue, 02 Nov 2021 15:27:01 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 15:26:21 +0000 Original-Received: from localhost ([127.0.0.1]:37839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvg4-0006H2-HJ for submit@debbugs.gnu.org; Tue, 02 Nov 2021 11:26:20 -0400 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhvg3-0006Gq-4P for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 11:26:19 -0400 Original-Received: by mail-pg1-f178.google.com with SMTP id p17so841542pgj.2 for <51556@debbugs.gnu.org>; Tue, 02 Nov 2021 08:26:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=llBWaXMuFuZ6SVfQ57KZlqJ6QUtaIGQpt3mnvBN6F8Q=; b=ay3RobKYhSwayi6bJ9f0hgeiBTKGSf0fTxLvWLHDZSElf45YQCygU7W9xu63GttpYk hOkNZLZxVdmSBIcIL/M95TQlgYyPvbKSPgHHY8EaGZ8kqFoYWWdVqM1lo1lOA2kVQe+P vG4W67vVq9+TQM4JcVTXR23TDfbINKed8hJSEL7axzBIcJK4t/jfoMcxNQnUS22LzTPB p0iVWX0/p1RP+IcXqLdNTxVULlv50qmjRbtX0hWIf46oLz5JU4L8oUEfqSu7p/EIqP63 rQnkQ20obr/k9xJ8mM/K7ZNc34PVMaMcXk+4n4pRsn/6n5Y/bkLpYE8TQxDTde9oRyPv OtAw== X-Gm-Message-State: AOAM533j3JUn+jO5V6E0GKSTNoSiHAhcQ4bn6yyFeCEsBILzLaibcl8R /zApjFDTbI6LtJsfgfA8fnOMqMC/Y7T5IL6Vf2Q= X-Google-Smtp-Source: ABdhPJzCEkhLQyDgivN/frmqMnUsmQI6cyYONQIinfY+OquVn8WXPXWEGh1TK6CpEhy00n5F18lTOaLYtifGUeHkg+A= X-Received: by 2002:a63:370c:: with SMTP id e12mr27997458pga.359.1635866773562; Tue, 02 Nov 2021 08:26:13 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Nov 2021 08:26:12 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218813 Archived-At: --000000000000f038d105cfcfe9f8 Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: >> As for foreground: what does it mean to remove the foreground from an >> image? (I realize that I didn't answer this part in my previous reply.) SVG is a special case, where we just use the foreground of the current face. In this case, I think the fix is as simple as the attached patch. I've tested this with several themes, and it looks very good to my eyes. I suggest that we install this fix on emacs-28. --000000000000f038d105cfcfe9f8 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Use-current-face-foreground-for-SVG-icons-in-customi.patch" Content-Disposition: attachment; filename="0001-Use-current-face-foreground-for-SVG-icons-in-customi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: e39d20218651906_0.1 RnJvbSBiNjY4MmJiNGYzZDc5OTJmMDU5NGI4NDg2MDU5MzdmMzU4ZjkzYTMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVHVlLCAyIE5vdiAyMDIxIDE2OjIxOjE5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gVXNlIGN1 cnJlbnQgZmFjZSBmb3JlZ3JvdW5kIGZvciBTVkcgaWNvbnMgaW4gY3VzdG9taXplCgoqIGV0Yy9p bWFnZXMvZG93bi5zdmc6CiogZXRjL2ltYWdlcy9sZWZ0LnN2ZzoKKiBldGMvaW1hZ2VzL3JpZ2h0 LnN2ZzoKKiBldGMvaW1hZ2VzL3VwLnN2ZzogRG9uJ3QgZGVmaW5lIGZvcmVncm91bmQ7IHRoaXMg bWVhbnMgdGhleSB3aWxsIHVzZQp0aGUgZm9yZWdyb3VuZCBvZiB0aGUgY3VycmVudGx5IGRlZmlu ZWQgZmFjZSBpbnN0ZWFkLiAgKEJ1ZyM1MTU1NikKLS0tCiBldGMvaW1hZ2VzL2Rvd24uc3ZnICB8 IDIgKy0KIGV0Yy9pbWFnZXMvbGVmdC5zdmcgIHwgMiArLQogZXRjL2ltYWdlcy9yaWdodC5zdmcg fCAyICstCiBldGMvaW1hZ2VzL3VwLnN2ZyAgICB8IDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9pbWFnZXMvZG93 bi5zdmcgYi9ldGMvaW1hZ2VzL2Rvd24uc3ZnCmluZGV4IGUyNzYwNDI3ZDcuLjcwN2NkMjNlYTQg MTAwNjQ0Ci0tLSBhL2V0Yy9pbWFnZXMvZG93bi5zdmcKKysrIGIvZXRjL2ltYWdlcy9kb3duLnN2 ZwpAQCAtMjUsNyArMjUsNyBAQAogICA8dGl0bGUgaWQ9J3RpdGxlODQ3Myc+R25vbWUgU3ltYm9s aWMgSWNvbnM8L3RpdGxlPgogICA8ZGVmcyBpZD0nZGVmczczODYnLz4KICAgPGcgaW5rc2NhcGU6 Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVyMTAnIGlua3NjYXBlOmxhYmVsPSd1aScgdHJhbnNm b3JtPSd0cmFuc2xhdGUoLTE1Mi4wMDU4NiwtOTUyKSc+Ci0gICAgPHBhdGggaW5rc2NhcGU6Y29u bmVjdG9yLWN1cnZhdHVyZT0nMCcgZD0nbSAxNjYsOTU3IC01Ljk5NDE0LDUuOTk5OTkgTCAxNTQs OTU3IFonIGlkPSdwYXRoNjQyNCcgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmls bDojMmUzNDM2O2ZpbGwtb3BhY2l0eToxO3N0cm9rZTpub25lJy8+CisgICAgPHBhdGggaW5rc2Nh cGU6Y29ubmVjdG9yLWN1cnZhdHVyZT0nMCcgZD0nbSAxNjYsOTU3IC01Ljk5NDE0LDUuOTk5OTkg TCAxNTQsOTU3IFonIGlkPSdwYXRoNjQyNCcgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHls ZT0nZmlsbC1vcGFjaXR5OjE7c3Ryb2tlOm5vbmUnLz4KICAgPC9nPgogICA8ZyBpbmtzY2FwZTpn cm91cG1vZGU9J2xheWVyJyBpZD0nbGF5ZXIxJyBpbmtzY2FwZTpsYWJlbD0nc3RhdHVzJyB0cmFu c2Zvcm09J3RyYW5zbGF0ZSgtMTUyLjAwNTg2LC04ODgpJy8+CiAgIDxnIGlua3NjYXBlOmdyb3Vw bW9kZT0nbGF5ZXInIGlkPSdsYXllcjExJyBpbmtzY2FwZTpsYWJlbD0nbGVnYWN5JyB0cmFuc2Zv cm09J3RyYW5zbGF0ZSgtMTUyLjAwNTg2LC05NTIpJy8+CmRpZmYgLS1naXQgYS9ldGMvaW1hZ2Vz L2xlZnQuc3ZnIGIvZXRjL2ltYWdlcy9sZWZ0LnN2ZwppbmRleCBkNjQyOWJjNDEwLi44OTM1MTVk MmRmIDEwMDY0NAotLS0gYS9ldGMvaW1hZ2VzL2xlZnQuc3ZnCisrKyBiL2V0Yy9pbWFnZXMvbGVm dC5zdmcKQEAgLTI1LDcgKzI1LDcgQEAKICAgPHRpdGxlIGlkPSd0aXRsZTg0NzMnPkdub21lIFN5 bWJvbGljIEljb25zPC90aXRsZT4KICAgPGRlZnMgaWQ9J2RlZnM3Mzg2Jy8+CiAgIDxnIGlua3Nj YXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlkPSdsYXllcjEwJyBpbmtzY2FwZTpsYWJlbD0ndWknIHRy YW5zZm9ybT0ndHJhbnNsYXRlKC05Mi4wMDU4NDgsLTk1MS45OTk5OSknPgotICAgIDxwYXRoIGlu a3NjYXBlOmNvbm5lY3Rvci1jdXJ2YXR1cmU9JzAnIGQ9J00gMTAzLDk2NiA5Ny4wMDU4NSw5NTku OTk5OTkgMTAzLDk1NCBaJyBpZD0ncGF0aDY0MDAnIHNvZGlwb2RpOm5vZGV0eXBlcz0nY2NjYycg c3R5bGU9J2ZpbGw6IzJlMzQzNjtmaWxsLW9wYWNpdHk6MTtzdHJva2U6bm9uZScvPgorICAgIDxw YXRoIGlua3NjYXBlOmNvbm5lY3Rvci1jdXJ2YXR1cmU9JzAnIGQ9J00gMTAzLDk2NiA5Ny4wMDU4 NSw5NTkuOTk5OTkgMTAzLDk1NCBaJyBpZD0ncGF0aDY0MDAnIHNvZGlwb2RpOm5vZGV0eXBlcz0n Y2NjYycgc3R5bGU9J2ZpbGwtb3BhY2l0eToxO3N0cm9rZTpub25lJy8+CiAgIDwvZz4KICAgPGcg aW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVyMScgaW5rc2NhcGU6bGFiZWw9J3N0 YXR1cycgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTkyLjAwNTg0OCwtODg3Ljk5OTk5KScvPgogICA8 ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVyJyBpZD0nbGF5ZXIxMScgaW5rc2NhcGU6bGFiZWw9 J2xlZ2FjeScgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTkyLjAwNTg0OCwtOTUxLjk5OTk5KScvPgpk aWZmIC0tZ2l0IGEvZXRjL2ltYWdlcy9yaWdodC5zdmcgYi9ldGMvaW1hZ2VzL3JpZ2h0LnN2Zwpp bmRleCBkNThjZDM2NDM1Li42YzdkNzE1OTM5IDEwMDY0NAotLS0gYS9ldGMvaW1hZ2VzL3JpZ2h0 LnN2ZworKysgYi9ldGMvaW1hZ2VzL3JpZ2h0LnN2ZwpAQCAtMjUsNyArMjUsNyBAQAogICA8dGl0 bGUgaWQ9J3RpdGxlODQ3Myc+R25vbWUgU3ltYm9saWMgSWNvbnM8L3RpdGxlPgogICA8ZGVmcyBp ZD0nZGVmczczODYnLz4KICAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSdsYXllcicgaWQ9J2xheWVy MTAnIGlua3NjYXBlOmxhYmVsPSd1aScgdHJhbnNmb3JtPSd0cmFuc2xhdGUoLTExMi4wMDU4NSwt OTUxLjk5OTk5KSc+Ci0gICAgPHBhdGggaW5rc2NhcGU6Y29ubmVjdG9yLWN1cnZhdHVyZT0nMCcg ZD0nbSAxMTcsOTY2IDYuMDA1ODUsLTYuMDAwMDEgTCAxMTcsOTU0IFonIGlkPSdwYXRoNjQxMicg c29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmlsbDojMmUzNDM2O2ZpbGwtb3BhY2l0 eToxO3N0cm9rZTpub25lJy8+CisgICAgPHBhdGggaW5rc2NhcGU6Y29ubmVjdG9yLWN1cnZhdHVy ZT0nMCcgZD0nbSAxMTcsOTY2IDYuMDA1ODUsLTYuMDAwMDEgTCAxMTcsOTU0IFonIGlkPSdwYXRo NjQxMicgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmlsbC1vcGFjaXR5OjE7c3Ry b2tlOm5vbmUnLz4KICAgPC9nPgogICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVyJyBpZD0n bGF5ZXIxJyBpbmtzY2FwZTpsYWJlbD0nc3RhdHVzJyB0cmFuc2Zvcm09J3RyYW5zbGF0ZSgtMTEy LjAwNTg1LC04ODcuOTk5OTkpJy8+CiAgIDxnIGlua3NjYXBlOmdyb3VwbW9kZT0nbGF5ZXInIGlk PSdsYXllcjExJyBpbmtzY2FwZTpsYWJlbD0nbGVnYWN5JyB0cmFuc2Zvcm09J3RyYW5zbGF0ZSgt MTEyLjAwNTg1LC05NTEuOTk5OTkpJy8+CmRpZmYgLS1naXQgYS9ldGMvaW1hZ2VzL3VwLnN2ZyBi L2V0Yy9pbWFnZXMvdXAuc3ZnCmluZGV4IDllMWEyNDViZTcuLmUzNThjMjk5MTIgMTAwNjQ0Ci0t LSBhL2V0Yy9pbWFnZXMvdXAuc3ZnCisrKyBiL2V0Yy9pbWFnZXMvdXAuc3ZnCkBAIC0yNSw3ICsy NSw3IEBACiAgIDx0aXRsZSBpZD0ndGl0bGU4NDczJz5Hbm9tZSBTeW1ib2xpYyBJY29uczwvdGl0 bGU+CiAgIDxkZWZzIGlkPSdkZWZzNzM4NicvPgogICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xh eWVyJyBpZD0nbGF5ZXIxMCcgaW5rc2NhcGU6bGFiZWw9J3VpJyB0cmFuc2Zvcm09J3RyYW5zbGF0 ZSgtMTMyLjAwNTg1LC05NTIpJz4KLSAgICA8cGF0aCBpbmtzY2FwZTpjb25uZWN0b3ItY3VydmF0 dXJlPScwJyBkPSdNIDE0Niw5NjMgMTQwLjAwNTg1LDk1Ni45OTk5OSAxMzQsOTYzIFonIGlkPSdw YXRoNjQxOCcgc29kaXBvZGk6bm9kZXR5cGVzPSdjY2NjJyBzdHlsZT0nZmlsbDojMmUzNDM2O2Zp bGwtb3BhY2l0eToxO3N0cm9rZTpub25lJy8+CisgICAgPHBhdGggaW5rc2NhcGU6Y29ubmVjdG9y LWN1cnZhdHVyZT0nMCcgZD0nTSAxNDYsOTYzIDE0MC4wMDU4NSw5NTYuOTk5OTkgMTM0LDk2MyBa JyBpZD0ncGF0aDY0MTgnIHNvZGlwb2RpOm5vZGV0eXBlcz0nY2NjYycgc3R5bGU9J2ZpbGwtb3Bh Y2l0eToxO3N0cm9rZTpub25lJy8+CiAgIDwvZz4KICAgPGcgaW5rc2NhcGU6Z3JvdXBtb2RlPSds YXllcicgaWQ9J2xheWVyMScgaW5rc2NhcGU6bGFiZWw9J3N0YXR1cycgdHJhbnNmb3JtPSd0cmFu c2xhdGUoLTEzMi4wMDU4NSwtODg4KScvPgogICA8ZyBpbmtzY2FwZTpncm91cG1vZGU9J2xheWVy JyBpZD0nbGF5ZXIxMScgaW5rc2NhcGU6bGFiZWw9J2xlZ2FjeScgdHJhbnNmb3JtPSd0cmFuc2xh dGUoLTEzMi4wMDU4NSwtOTUyKScvPgotLSAKMi4zMC4yCgo= --000000000000f038d105cfcfe9f8--