From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string' Date: Wed, 25 Nov 2020 16:39:10 -0500 Message-ID: References: <6F768DED-2E1B-4D06-A776-FFA162AC32AD@acm.org> <97535AF5-D542-4267-A5A9-1483C32A61AC@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10989"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44861@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Shigeru Fukaya Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 25 22:43:55 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ki2Zv-0002m1-HT for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 22:43:55 +0100 Original-Received: from localhost ([::1]:59684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ki2Zu-0002uk-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Nov 2020 16:43:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ki2WA-0005za-Dr for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 16:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ki2WA-0002RN-5d for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 16:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ki2WA-0003qe-1S for bug-gnu-emacs@gnu.org; Wed, 25 Nov 2020 16:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Nov 2020 21:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44861 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 44861-submit@debbugs.gnu.org id=B44861.160634035914737 (code B ref 44861); Wed, 25 Nov 2020 21:40:01 +0000 Original-Received: (at 44861) by debbugs.gnu.org; 25 Nov 2020 21:39:19 +0000 Original-Received: from localhost ([127.0.0.1]:37330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki2VT-0003pd-5S for submit@debbugs.gnu.org; Wed, 25 Nov 2020 16:39:19 -0500 Original-Received: from mail-ej1-f43.google.com ([209.85.218.43]:45915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ki2VR-0003pO-Fl for 44861@debbugs.gnu.org; Wed, 25 Nov 2020 16:39:18 -0500 Original-Received: by mail-ej1-f43.google.com with SMTP id lv15so5044500ejb.12 for <44861@debbugs.gnu.org>; Wed, 25 Nov 2020 13:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc:content-transfer-encoding; bh=OWaipFu4bAJe1wHaEkytAfsTkNDpbpm6fvH4omjdzkk=; b=agRcITfuJmOanKXudiNfyZeC23l9LijcLYufZZIqzOeOECLRcF7aa9bmw/ix7a7WUG AZiKB8EtSaZgP5Na7hXavWMvsEzqJ1lq7AMNfQ1hIrXYz+DwJwvh94Dn9N7t2BbyLRXA gQt7BXXLzpI4GxCY43H/IYo0NK+p7Xwj0mqy4uSzVyLxT832jffgi8vCbher0KSgOrsH fDrUrZ6Z/TSVIPqjeMStEj/L4IoOb/yXk5bLkhV6rsIpc3pWpK4qvsNXRmz9Upph/1Bs jj7VDv88t+sIRd27ZrTgccaJl9Evm/Sp0RhIDdjIP/L+tcvslALLl2INt1ZUk+9VNHAD t/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=OWaipFu4bAJe1wHaEkytAfsTkNDpbpm6fvH4omjdzkk=; b=IFR/PcaeqnLFhclxP5EpvdIxeAe3p2RN4+2K/cwGK/yPP0GrzrBdNVUWZFqHkcYaGy Gd1hITBpayr3MNw4UulUCLeYoAy0P0pludjnPdLz6p3eFasrxMfc/sD3vMlzqf3nAcIE r15tkqPnDZIv129ShnvQP0ZCoC+j3BrNEHqLnEnsQeRZJ9sFzyURhOPtNjNlJZ7lDdon RArW4tF1rhBslaov2i+EjUz9FPl9OSxz4wA9mvNogB/tSNXISymC5DdrnxxgneTYhBs/ OTc3xXmnQSXjxeeUfzKp2inU9hZxIocmivO3ENcEYhSIIxNz/idY03aP3qrGUxAv9dP4 0mMQ== X-Gm-Message-State: AOAM533gK+b5ptYyezD/I/m2jX5iGMDzco3f71Z6GhnKnBuPf0v8E3Qd mrK9Q8EpURA9dVOe9IDQ1xDd/glwyFskRECRmlc= X-Google-Smtp-Source: ABdhPJzAC24+N/yebfEaqZXuB/xvkJERWz03q12yMla/4NPH8RU7k18MlqcW3kW/3JisokGb9ycyH6melPNcqalc2kw= X-Received: by 2002:a17:906:eb50:: with SMTP id mc16mr4289825ejb.420.1606340351521; Wed, 25 Nov 2020 13:39:11 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 25 Nov 2020 16:39:10 -0500 In-Reply-To: <97535AF5-D542-4267-A5A9-1483C32A61AC@acm.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194248 Archived-At: Mattias Engdeg=C3=A5rd writes: > It is basically your patch but slightly optimised; it turned out that > the function call and allocation overhead of the original patch made > it a tad too expensive (a pity, because it was very neat). Now > performance is about the same as before when the pattern contains no > submatches, and slightly above (< 10% slower) with one submatch. It > seems worth the correctness. Presumably this hasn't worked correctly for a long time, if ever. Is that correct? I personally worry about the performance here. Since we use regexps heavily all over, it is not clear (to me) that 10 % overall performance drop with subexpressions is worth it to work correctly in these rare edge-cases. I suppose we do have to fix the bug here, but is it feasible to solve this in a way that has less performance impact?