From: Stefan Kangas <stefankangas@gmail.com>
To: Mauro Aranda <maurooaranda@gmail.com>, 66635@debbugs.gnu.org
Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did)
Date: Fri, 20 Oct 2023 14:08:05 -0700 [thread overview]
Message-ID: <CADwFkm=4Xoa+h1dx5hbY0J0EQHiB8m0Zmw1PAEuV7qB=fW1aZQ@mail.gmail.com> (raw)
In-Reply-To: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com>
Mauro Aranda <maurooaranda@gmail.com> writes:
> I attach a patch to address the more important issues for now. That is,
> at least have a working State button and rudimentary state checking.
>
> Setting and Saving icon specifications through the State button should
> work now, by adding the custom-icon-action function.
Thanks for working on this.
Do you propose this patch for emacs-29? It seems quite intrusive on the
face of it, but OTOH `customize-icon' is new in Emacs 29, so there is no
risk of regressions if this stuff never worked in the first place. Or
is that wrong?
> From ab4fabf48665ddc142ad95a26898eb6207cd2bdc Mon Sep 17 00:00:00 2001
> From: Mauro Aranda <maurooaranda@gmail.com>
> Date: Thu, 19 Oct 2023 08:46:35 -0300
> Subject: [PATCH] Fix State button for customize-icon (Bug#66635)
>
> * lisp/cus-edit.el (custom-icon-action): New function.
> (custom-icon): Use it as the :action. Otherwise, clicking the State
> button is a noop. Remove irrelevant stuff from the docstring and
> comment out some copy-pasta.
> (custom-icon-extended-menu): New variable, the menu to show upon
> :action.
> (custom-icon-set): Really redraw the widget with the new settings.
> Comment out strange call to custom-variable-backup-value.
> (custom-icon-save): New function.
>
> * lisp/emacs-lisp/icons.el (icons--merge-spec): Fix call to plist-get
> and avoid infloop.
> ---
> lisp/cus-edit.el | 71 +++++++++++++++++++++++++++++++++-------
> lisp/emacs-lisp/icons.el | 6 ++--
> 2 files changed, 62 insertions(+), 15 deletions(-)
>
> diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
> index 706e08d5657..953b8b8b80f 100644
> --- a/lisp/cus-edit.el
> +++ b/lisp/cus-edit.el
> @@ -5366,11 +5366,6 @@ 'custom-icon
> :hidden-states should be a list of widget states for which the
> widget's initial contents are to be hidden.
>
> -:custom-form should be a symbol describing how to display and
> - edit the variable---either `edit' (using edit widgets),
> - `lisp' (as a Lisp sexp), or `mismatch' (should not happen);
> - if nil, use the return value of `custom-variable-default-form'.
> -
> :shown-value, if non-nil, should be a list whose `car' is the
> variable value to display in place of the current value.
>
> @@ -5383,11 +5378,34 @@ 'custom-icon
> :custom-category 'option
> :custom-state nil
> :custom-form nil
> - :value-create 'custom-icon-value-create
> + :value-create #'custom-icon-value-create
> :hidden-states '(standard)
> - :custom-set 'custom-icon-set
> - :custom-reset-current 'custom-redraw
> - :custom-reset-saved 'custom-variable-reset-saved)
> + :action #'custom-icon-action
> + :custom-set #'custom-icon-set
> + :custom-reset-current #'custom-redraw)
> + ;; Not implemented yet.
> + ;; :custom-reset-saved 'custom-icon-reset-saved)
> +
> +(defvar custom-icon-extended-menu
> + (let ((map (make-sparse-keymap)))
> + (define-key-after map [custom-icon-set]
> + '(menu-item "Set for Current Session" custom-icon-set
> + :enable (eq (widget-get custom-actioned-widget :custom-state)
> + 'modified)))
> + (when (or custom-file init-file-user)
> + (define-key-after map [custom-icon-save]
> + '(menu-item "Save for Future Sessions" custom-icon-save
> + :enable (memq
> + (widget-get custom-actioned-widget :custom-state)
> + '(modified set changed)))))
> + (define-key-after map [custom-redraw]
> + '(menu-item "Undo Edits" custom-redraw
> + :enable (memq
> + (widget-get custom-actioned-widget :custom-state)
> + '(modified changed))))
> + map)
> + "A menu for `custom-icon' widgets.
> +Used in `custom-icon-action' to show a menu to the user.")
>
> (defun custom-icon-value-create (widget)
> "Here is where you edit the icon's specification."
> @@ -5517,6 +5535,24 @@ custom-icon-value-create
> (custom-add-parent-links widget))
> (custom-add-see-also widget)))))
>
> +(defun custom-icon-action (widget &optional event)
> + "Show the menu for `custom-icon' WIDGET.
> +Optional EVENT is the location for the menu."
> + (if (eq (widget-get widget :custom-state) 'hidden)
> + (custom-toggle-hide widget)
> + (unless (eq (widget-get widget :custom-state) 'modified)
> + (custom-icon-state-set widget))
> + (custom-redraw-magic widget)
> + (let* ((completion-ignore-case t)
> + (custom-actioned-widget widget)
> + (answer (widget-choose (concat "Operation on "
> + (custom-unlispify-tag-name
> + (widget-get widget :value)))
> + custom-icon-extended-menu
> + event)))
> + (when answer
> + (funcall answer widget)))))
> +
> (defun custom-toggle-hide-icon (visibility-widget &rest _ignore)
> "Toggle the visibility of a `custom-icon' parent widget.
> By default, this signals an error if the parent has unsaved
> @@ -5553,10 +5589,21 @@ custom-icon-set
> (user-error "Cannot update hidden icon"))
>
> (setq val (custom--icons-widget-value child))
> - (unless (equal val (icon-complete-spec symbol))
> - (custom-variable-backup-value widget))
> + ;; FIXME: What was the intention here?
> + ;; (unless (equal val (icon-complete-spec symbol))
> + ;; (custom-variable-backup-value widget))
Is there any reason to not just remove this outright?
It'd still be there in git history, in the unlikely event that we should
need it again.
> (custom-push-theme 'theme-icon symbol 'user 'set val)
> - (custom-redraw-magic widget)))
> + (custom-redraw widget)))
> +
> +(defun custom-icon-save (widget)
> + "Save value of icon edited by widget WIDGET."
> + (custom-set-icons (cons (widget-value widget)
> + (list
> + (custom--icons-widget-value
> + (car (widget-get widget :children))))))
> + (custom-save-all)
> + (custom-icon-state-set widget)
> + (custom-redraw-magic widget))
>
> ;;;###autoload
> (defun customize-icon (icon)
> diff --git a/lisp/emacs-lisp/icons.el b/lisp/emacs-lisp/icons.el
> index cb08c1a6b81..9a6d26243c7 100644
> --- a/lisp/emacs-lisp/icons.el
> +++ b/lisp/emacs-lisp/icons.el
> @@ -181,9 +181,9 @@ icons--merge-spec
> (let ((parent-keywords (icon-spec-keywords elem))
> (current-keywords (icon-spec-keywords current)))
> (while parent-keywords
> - (unless (plist-get (car parent-keywords) current-keywords)
> - (nconc current (take 2 parent-keywords))
> - (setq parent-keywords (cddr parent-keywords))))))))
> + (unless (plist-get current-keywords (car parent-keywords))
> + (nconc current (take 2 parent-keywords)))
> + (setq parent-keywords (cddr parent-keywords)))))))
> merged)
>
> (cl-defmethod icons--create ((_type (eql 'image)) icon keywords)
> --
> 2.34.1
next prev parent reply other threads:[~2023-10-20 21:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 11:18 bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Mauro Aranda
2023-10-19 11:53 ` Mauro Aranda
2023-10-20 21:08 ` Stefan Kangas [this message]
2023-10-21 0:21 ` Mauro Aranda
2023-10-21 7:35 ` Eli Zaretskii
2023-10-21 10:18 ` Mauro Aranda
2023-10-21 11:09 ` Mauro Aranda
2023-10-21 11:17 ` Stefan Kangas
2023-10-21 11:33 ` Eli Zaretskii
2023-10-21 11:51 ` Stefan Kangas
2023-10-21 12:28 ` Mauro Aranda
2023-10-22 12:09 ` Stefan Kangas
2023-10-22 12:46 ` Mauro Aranda
2023-10-22 16:51 ` Stefan Kangas
2023-10-21 11:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=4Xoa+h1dx5hbY0J0EQHiB8m0Zmw1PAEuV7qB=fW1aZQ@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=66635@debbugs.gnu.org \
--cc=maurooaranda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).