From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#37856: 27.0.50; 'next-error' advised with 'recenter' signals error when run from "*grep*" buffer Date: Mon, 21 Oct 2019 20:38:47 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="169256"; mail-complaints-to="usenet@blaine.gmane.org" To: 37856@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 21 20:40:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMcbE-000hrp-HW for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 20:40:12 +0200 Original-Received: from localhost ([::1]:46762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMcbD-0004nI-0e for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Oct 2019 14:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55068) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMcb7-0004n9-0K for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 14:40:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMcb5-0007Er-1o for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 14:40:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49005) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMcb4-0007Ed-BR for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 14:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMcb4-0001oD-5i for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 14:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2019 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37856 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15716831466874 (code B ref -1); Mon, 21 Oct 2019 18:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Oct 2019 18:39:06 +0000 Original-Received: from localhost ([127.0.0.1]:57826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMca9-0001mo-Ps for submit@debbugs.gnu.org; Mon, 21 Oct 2019 14:39:06 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMca7-0001mc-Fu for submit@debbugs.gnu.org; Mon, 21 Oct 2019 14:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMca6-0004iq-6Y for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 14:39:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMca4-00070J-SH for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 14:39:01 -0400 Original-Received: from mail-pf1-f169.google.com ([209.85.210.169]:33778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMca4-0006zV-NE for bug-gnu-emacs@gnu.org; Mon, 21 Oct 2019 14:39:00 -0400 Original-Received: by mail-pf1-f169.google.com with SMTP id q10so8978793pfl.0 for ; Mon, 21 Oct 2019 11:38:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=cju5zD5fcjOCm/rF9AMi9ImBg28HRa4EnOyPrnfd4eU=; b=Q4flMABbouhg5HqBHyYJ1F/7/ZPfU3Ub21IpH7F0kpKMTWwKmIxxfDRVUQHmc/HbDs TGrsB39p+oYhA4c1Ys8GA2s4taL1HHcVb890rdIvvqBQ6bHITLgVRTOLHaOLPSbkTm/E UYTwybkA7TaQLmtesL7oQh1ksgQ7oEXmA3ZHyUnC4gSeL29GuYB4OFbH5tq86G9ZpZjd 4rj0xC0967MSed7vlYFGP3BYDu2G4c2fz0ZB4EdqZmtlPcqlGyQD3goM6v6NkOGApwe1 MNuMYKGtExeRDza365YtY9WUkTRG9HJiqpSKWLLIW4VrEXq+XuwqyxAouvwjgvWVeJDq WWXw== X-Gm-Message-State: APjAAAWeUorUcbOiu4yXvK7YBwiAOmBDgtUeqhbhn60ZROsEviXMe95B 8NAqDFy+mZUG5bsx/hT4jmUfpy5Rp8LGPMsh+B3RicdW X-Google-Smtp-Source: APXvYqwxBF+hdYSxjkf6uAqbVwqCc+OANSlYgD7ZvYVh/seUOJLDt9HZVJeB4etFhgXFKKzDE+t/TineNpIJ4I+Jg1A= X-Received: by 2002:a17:90a:f491:: with SMTP id bx17mr31262818pjb.106.1571683138145; Mon, 21 Oct 2019 11:38:58 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169938 Archived-At: I get an error when advising 'next-error' with 'recenter'. Steps to reproduce: 1. Under "emacs -Q", evaluate: (defun my-advice (&rest args) (recenter)) (advice-add 'next-error :after #'my-advice) 2. M-x rgrep RET [... grep for something] 3. Run 'next-error' (M-g M-n) from the "*grep*" buffer. Result: I get the error: recenter-top-bottom: =E2=80=98recenter=E2=80=99ing a window that does n= ot display current-buffer. (I also get the error when I run it in the second window when 'next-error' would take you to a different file.) Expected result: I get no error. --- Backtrace: Debugger entered--Lisp error: (error "=E2=80=98recenter=E2=80=99ing a windo= w that does not display curre...") recenter() my-advice(nil) apply(my-advice nil) next-error(nil) funcall-interactively(next-error nil) #(next-error nil nil) apply(# next-error (nil nil)) call-interactively@ido-cr+-record-current-command(# next-error nil nil) apply(call-interactively@ido-cr+-record-current-command # (next-error nil nil)) call-interactively(next-error nil nil) command-execute(next-error) --- This seems to be due to this code in window.c: /* For reasons why we signal an error here, see https://lists.gnu.org/r/emacs-devel/2014-06/msg00053.html, https://lists.gnu.org/r/emacs-devel/2014-06/msg00094.html. */ if (buf !=3D current_buffer) error ("`recenter'ing a window that does not display current-buffer."); This code was added here: 3da983f8c4 2014-06-06 Stefan Monnier * src/window.c (Frecenter): Signal an error if window-buffer is not current-buffer. --- In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin17.7.0, NS appkit-1561.61 Version 10.13.6 (Build 17G8037)) of 2019-10-21 built on Stefans-MBP Repository revision: 0e6f4628d8fff53505e4399e71da9f531a64fff7 Repository branch: master Windowing system distributor 'Apple', version 10.3.1561 System Description: Mac OS X 10.13.6