From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41852: 27.0.50; text-scale commands don't scale header of tabulated-list-mode Date: Fri, 30 Oct 2020 20:22:58 +0000 Message-ID: References: <955fe4fe-a64d-b7c6-fe31-7efd810f97a5@ims.co.at> <83mu553e0x.fsf@gnu.org> <953c6df9-59b4-8b57-0be3-600d147fe9c7@ims.co.at> <83y2k2pabb.fsf@gnu.org> <83wnzmnioj.fsf@gnu.org> <83lfg1nfv1.fsf@gnu.org> <83d01dnegn.fsf@gnu.org> <2ae49edc-098f-9ace-595d-9e29bf3d2c8b@gmx.at> <83h7qba6jb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15121"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41852@debbugs.gnu.org, thomas.hisch@ims.co.at To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 30 21:30:53 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYb2x-0003ol-Fs for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 21:30:51 +0100 Original-Received: from localhost ([::1]:44970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYb2w-0005Hv-Dn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Oct 2020 16:30:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYawM-0003lR-TO for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 16:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYawM-0007t3-IR for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 16:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYawM-0000MS-El for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 16:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 20:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41852 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41852-submit@debbugs.gnu.org id=B41852.16040893871323 (code B ref 41852); Fri, 30 Oct 2020 20:24:02 +0000 Original-Received: (at 41852) by debbugs.gnu.org; 30 Oct 2020 20:23:07 +0000 Original-Received: from localhost ([127.0.0.1]:59862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYavT-0000LH-HS for submit@debbugs.gnu.org; Fri, 30 Oct 2020 16:23:07 -0400 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:35228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYavR-0000KN-7T for 41852@debbugs.gnu.org; Fri, 30 Oct 2020 16:23:06 -0400 Original-Received: by mail-ed1-f50.google.com with SMTP id w25so7972889edx.2 for <41852@debbugs.gnu.org>; Fri, 30 Oct 2020 13:23:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=SCVyttfTIrkPIfxtmtEPjRfzW1frSoRtNjWJq51jGHo=; b=j95ddDbK+eu0Y4JP7nz5F69yVKIDmmuS75sljRbk6042mRSPyS586Ht/WIy27dshyH f5qGe2CD0l7MCLSIkmQOTV1QVZxDrQZP/0s8bui5Tmajco2SfLPgEFtjFPWyHADqk5CU S7+XhshTrT2z+G9UptLoV/HM5KR5jmw8w18bdhn2w6caphyOZeLNFlJplFmRUmpxKSgb QET6W+qxkwrXd5gxKVP5MzLtMYdzl/MFRNstns+vZibuAeTZwlQrZa6z8O9z9n61DtJP 9Q/N+vhzQqiUlchmGI/xKRTPZWzqyTNmOotG91v6v1Yt+Wfa6uU92WmqutDC1yIgCnkn g51A== X-Gm-Message-State: AOAM531ZmQe5p1NGVJEibOgayzvdK32nAibYTxHCm9ZrdkIiX+l4XUMu ZzAgQpkK4IUenid6+C+m6leXKCGHsH2CtRxCIg0= X-Google-Smtp-Source: ABdhPJwH9So8uoUpZL5zZyt4mWm7SUL9D0mS3D0/t58VYmxUG5En6NdrLubLCaU0uh9VhnhWkXil9tORwNvvG24j7+g= X-Received: by 2002:aa7:d783:: with SMTP id s3mr4478260edq.214.1604089379458; Fri, 30 Oct 2020 13:22:59 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 30 Oct 2020 20:22:58 +0000 In-Reply-To: <83h7qba6jb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192193 Archived-At: Eli Zaretskii writes: >> > (2) that text in the header line or elsewhere in such a buffer not >> > inheriting from (the remapped) header line face is unaffected, and >> >> I'm not sure I understand what you mean. If text-scale-mode is enabled, >> typically through running e.g. `text-scale-increase', the `default' face >> is scaled. The result, AFAICT, is that all faces in the buffer change >> size (well, not the mode line). > > No, only faces that inherit from 'default' are scaled. And now so > will the faces that inherit from 'header-line'. When I use my patch in emacs -Q, say `M-x list-buffer' and then evaluate this in that buffer: (setq-local header-line-format (concat (propertize "foo" 'face 'mode-line) " " (propertize "bar" 'face 'bold))) Both "foo" and "bar" in the header line is scaled with the rest of the buffer. But I don't think either of those faces inherits from the header-line face. Is this the scenario you had in mind? >> And that makes sense since all other implicitly inherits from it, >> right? > > No, not every face inherits from 'default', only those that inherit > explicitly. `(elisp) Basic Faces' says that they do: =E2=80=98default=E2=80=99 The default face, whose attributes are all specified. All other faces implicitly inherit from it: any unspecified attribute defaults to the attribute on this face (*note Face Attributes::). So I'm not sure I understand what you are saying. I'm probably still missing something. > A random face that is defined with defface isn't affected by > text-scale-*. What do you mean by "random face" here? When I do this, the text "bar" is scaled along with the rest: (progn (defface foo-face '((t :weight bold)) "") (pop-to-buffer (get-buffer-create "*test*")) (insert "foo\n") (insert (propertize "bar\n" 'face 'foo-face)) (insert "baz\n") (text-scale-increase 1)) Or could you give an example of where this does not happen? >> This works even for anonymous faces, e.g.: >> >> (progn >> (fundamental-mode) >> (insert (propertize "foo" 'face '(:height 1.5))) >> (text-scale-increase)) >> >> What am I missing? > > See above. Could you elaborate? What I see is that this anonymous face is scaled. Are you saying that you see something different? >> > Wrt (3) I assume that 'tabulated-list-mode' can already get derailed >> > when a user customizes header line face to use some large or small fon= t >> > size (a scenario where face remapping is not involved at all). >> >> I tried customizing the `Height' for the `header-line' face, and it >> seems to work as expected: >> >> With no text-scale-mode it is as big as it is customized to be. When I >> run `text-scale-increase', it scales up accordingly (relative to its >> customized size). So I don't know what, if anything, should be added >> here. Since it works as expected, perhaps there is nothing to add? > > What Martin means, I think, is that using a larger font in header-line > face might make the text below the header line in tabulated-list-mode > fail to align. Oh, okay. Yes, that is true. Is there anything we can or should do about that?