From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#65128: 30.0.50; Strange code in help-fns.el Date: Tue, 8 Aug 2023 03:43:53 +0200 Message-ID: References: <87leemstkv.fsf@localhost> <83edkeojy0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10040"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ihor Radchenko , 65128-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 03:45:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTBms-0002Oi-1h for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 03:45:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTBmS-0000Fc-2Z; Mon, 07 Aug 2023 21:45:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTBmQ-0000FJ-I5 for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 21:45:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTBmQ-00014P-7W for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 21:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTBmP-0000XQ-Ta for bug-gnu-emacs@gnu.org; Mon, 07 Aug 2023 21:45:01 -0400 Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 01:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65128 X-GNU-PR-Package: emacs Mail-Followup-To: 65128@debbugs.gnu.org, stefankangas@gmail.com, yantar92@posteo.net Original-Received: via spool by 65128-done@debbugs.gnu.org id=D65128.16914590591988 (code D ref 65128); Tue, 08 Aug 2023 01:45:01 +0000 Original-Received: (at 65128-done) by debbugs.gnu.org; 8 Aug 2023 01:44:19 +0000 Original-Received: from localhost ([127.0.0.1]:34601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTBlf-0000Vu-Va for submit@debbugs.gnu.org; Mon, 07 Aug 2023 21:44:19 -0400 Original-Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]:53294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTBla-0000VX-AE for 65128-done@debbugs.gnu.org; Mon, 07 Aug 2023 21:44:14 -0400 Original-Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-99c353a395cso697542366b.2 for <65128-done@debbugs.gnu.org>; Mon, 07 Aug 2023 18:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691459044; x=1692063844; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M6F5cmgLz6uma9rkrH6npJbFda0+5TaKaAhUsx/ytlk=; b=hnWEpb+OrMv2tA2p+vPKIrdiim692zlZiTfiu3VWAmMVSAHUI94FwXCN1LF/9YF6h9 gTknTzWoaacGZNs6jxm+WJ9QhG3K+XTRKTXmI85hetoTC93qKE5Jyqm6QbUukkfMxnOS 3qIa3JgutHyONLehL2KmIOhnxboNmqaAc3//VRcGJtUa1g6od12GK/oxq/hcyKixNN9W Pr4nLDsl1JOC/8q3dPR2vI1X5BcpkrxTe195O3j6FzT1PZKa7LmsWRFx3H7JcQJZM+UC QeqxxI6WNZ89q3TmybuTeVe8CuE99I3OaCIDAiR4RlB/ef69BTnvvbrk2TLDHjErxFCS eKGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691459044; x=1692063844; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M6F5cmgLz6uma9rkrH6npJbFda0+5TaKaAhUsx/ytlk=; b=OiX6diFun2ShXvQZJAosZLMn2p8G7xwYkyYzcvYuSaIbhRK8IK1idogbeEI8z9/0UA JfzLn7G2qDb3KDNPs1LJey/9gQdjfzjGFZ+rd50ICzpZWFc9Bg0EpyZYJkIwtd98wLGO SVU38yPIXwPem2Su+5L1yi4FNi7eylAZ+hHucIy+FX460thqF8V8+Si9cL+YNBsSE3/s DELqtwqUiZ9lhsSnRwrqtreLjNeH0U6yG8yFpQdn4ikPNmmnyT8aTrhpkobH9F82JiyW T+h8xy5AKrth82WezG4xb8z4hoqK2u2LLUQ+hG7dchHJbIXkBqrgUfwkmK5uEiD3s6y/ +TNA== X-Gm-Message-State: AOJu0YylFoUA0iv0itK/N3OVMlQjJGGWLgnQ/PZBtlGuX4tATifb+sYS ZWfkAQoA9kruSXAz9WJFrdhIuV3Da1hrLpvY83o= X-Google-Smtp-Source: AGHT+IGkDHvgss0aW+sErOjsVvTbsHZX6oHFfoI2UgvSQUOPxEaFH1F9/1RlNd4aBxXrkmYboaGjJVAlIrM7B/FRfhs= X-Received: by 2002:a05:6402:d4:b0:522:4cd7:efb0 with SMTP id i20-20020a05640200d400b005224cd7efb0mr7383757edu.17.1691459044365; Mon, 07 Aug 2023 18:44:04 -0700 (PDT) In-Reply-To: <83edkeojy0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266910 Archived-At: Eli Zaretskii writes: > > I am looking at lisp/help-fns.el:describe-keymap and seeing > > > > (let ((sym nil)) > > (unless sym > > ... > > > > It looks like an oversight - sym will always be nil there. > > Adding Stefan, who wrote that function. Thanks, now fixed on master. PS. For the record, this function was originally written by Drew, and integrated into Emacs by me. I do get credit for the stylistic mistake here, however.