unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Ihor Radchenko <yantar92@posteo.net>, 65128-done@debbugs.gnu.org
Subject: bug#65128: 30.0.50; Strange code in help-fns.el
Date: Tue, 8 Aug 2023 03:43:53 +0200	[thread overview]
Message-ID: <CADwFkm=3n2OTboyba_GCcPzo=Vhp+qUB460KSQ0P=8iGgqX2-A@mail.gmail.com> (raw)
In-Reply-To: <83edkeojy0.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

> > I am looking at lisp/help-fns.el:describe-keymap and seeing
> >
> >  (let ((sym nil))
> >     (unless sym
> >     ...
> >
> > It looks like an oversight - sym will always be nil there.
>
> Adding Stefan, who wrote that function.

Thanks, now fixed on master.

PS. For the record, this function was originally written by Drew, and
integrated into Emacs by me.  I do get credit for the stylistic
mistake here, however.





  reply	other threads:[~2023-08-08  1:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 16:30 bug#65128: 30.0.50; Strange code in help-fns.el Ihor Radchenko
2023-08-07 17:12 ` Eli Zaretskii
2023-08-08  1:43   ` Stefan Kangas [this message]
2023-08-08 15:50     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=3n2OTboyba_GCcPzo=Vhp+qUB460KSQ0P=8iGgqX2-A@mail.gmail.com' \
    --to=stefankangas@gmail.com \
    --cc=65128-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).