From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#62677: Merge flyspell-mode with flyspell-prog-mode Date: Sun, 24 Sep 2023 09:29:23 -0700 Message-ID: References: <87mt3mv5e9.fsf@web.de> <076460cb-f203-de49-c949-bdc213fd1965@gmail.com> <83y1n5r0i9.fsf@gnu.org> <83o7if35x5.fsf@gnu.org> <83bkef15rx.fsf@gnu.org> <83lecv37f4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36214"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, jporterbugs@gmail.com, 62677@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 24 18:30:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkRzs-0009DQ-47 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Sep 2023 18:30:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkRzV-000747-Mn; Sun, 24 Sep 2023 12:29:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkRzT-00073j-AO for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 12:29:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkRzT-0008H0-2P for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 12:29:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkRze-0006Rb-TC for bug-gnu-emacs@gnu.org; Sun, 24 Sep 2023 12:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Sep 2023 16:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62677 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy Original-Received: via spool by 62677-submit@debbugs.gnu.org id=B62677.169557299124725 (code B ref 62677); Sun, 24 Sep 2023 16:30:02 +0000 Original-Received: (at 62677) by debbugs.gnu.org; 24 Sep 2023 16:29:51 +0000 Original-Received: from localhost ([127.0.0.1]:43522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkRzQ-0006Qe-Dn for submit@debbugs.gnu.org; Sun, 24 Sep 2023 12:29:51 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:50612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkRzK-0006QK-Nm for 62677@debbugs.gnu.org; Sun, 24 Sep 2023 12:29:46 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-502fd1e1dd8so8305852e87.1 for <62677@debbugs.gnu.org>; Sun, 24 Sep 2023 09:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695572965; x=1696177765; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=xJBh7YAHP9gW3KfmRwRJMc1qnc5vrwZt9tNLiwXnydM=; b=gv6EvukwQGYpOSv78vJDkirLgoL7qK07TnMpVtMqNwBlkFrOok4td1zvfaJ7McHDuR As9Yv+4CqgSVzy3SCFd8SoDLB7S7ee8u3D2WZ6qA+fEOt4cBuwmNbmavzs+B5+FksIN2 zE47x3FOcKCwvik1R/6Fpkw+hT6eWoxPLSJv5BP0l39IQBqu9KysDAYhM3ZAT/M8h2I+ peWt+xuxQd4KLwzfB3QtHLbxfx+4ehWTdfiq71NMVQzglDnFCavLYfS7oL8yj6RBiVdX BO3t6UUuRCDdNFpVQd5hkSiWgv9LPVFGUSH/F67lwkg6DcXy8ZS1kR/+bJrkRnO6aKy/ e2UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695572965; x=1696177765; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xJBh7YAHP9gW3KfmRwRJMc1qnc5vrwZt9tNLiwXnydM=; b=lLXd8gNNRsEevwaYpkDqxLOguts6EMwVs3xOn4sBadXvQFexG/hY6+oqtgavfclxcr +t2C5CFQKOPYS34pCQEHhUNFhGsHJTCycHeEfh1g3DgVURmqGIibfNlj7SSZmyYIXF1O EShxvDVQkjezkqvKEftnI/rEcbwrr/ot5io0U1rRkIE2BdfsUhpw6wogViMqcB4K9cb1 JAx4ycpyHim6FEiJ0yeHPz9pp6ypDjUTaD0sCwwIthEEcI8VrAEmSClGPH+P3DI5noeq 8wuElzXGG2oPPRlnKqTNpyg36wIcfMylEpqLbjSMFpadpmLOTcd4BHBD0Jfdj+1kR4kR j80g== X-Gm-Message-State: AOJu0Yx0tvU6h85ogx10Pxdr75o+1mOxUT2PGy/bS7eLEWkCcoYS0Ftw qmWoAySbJwhriG9UAJ9Op+O8MFLwwFqKb0UD/9g= X-Google-Smtp-Source: AGHT+IEu2hZYignOmBE3CMjHH0HxleIOBnQjt4Dy07Ycv7FDVf2PgmQ0T4KdDV6a9IYJ6hjKFTnoYG4CVSahvBoLlVc= X-Received: by 2002:a05:6512:694:b0:503:5cd:998b with SMTP id t20-20020a056512069400b0050305cd998bmr4996404lfe.28.1695572964550; Sun, 24 Sep 2023 09:29:24 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 24 Sep 2023 09:29:23 -0700 In-Reply-To: <83lecv37f4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271262 Archived-At: Eli Zaretskii writes: > Looks good in general, but why deprecate and de-document > flyspell-prog-mode? I can easily envision a major mode that doesn't > inherit from prog-mode, but still has defined syntax for comments and > strings: why not let users invoke flyspell-prog-mode in those cases? Shouldn't such modes simply be added to the new `flyspell-programming-mode-list' variable? Or do you envision situations where which one is "best" will be a matter of user preference? If yes, we should of course keep them both. If not, I think it makes sense to have just the one command, because it is simpler. This is what I had in mind. > Moreover, users might have customizations that reference > flyspell-prog-mode, and I see no reason to annoy them with obsoletion > warnings. This will not be relevant if we're keeping both commands, but just in case: You're right that such warnings would be a nuisance, and not really worth it. That's why I chose to document it as deprecated, without any warnings. We could also remove the sentence saying that it will be marked as obsolete. > IOW, we just made the users' lives easier by automatically activating > flyspell-prog-mode when we know it's appropriate, we are not saying > that what flyspell-prog-mode does is incorrect or suboptimal. This seems to suggest that you envision that users might want to use one or the other, at least in some cases. That's perfectly fine by me, if that's the case.