From: Stefan Kangas <stefankangas@gmail.com>
To: Evgeny Gagauz <evgenij.gagauz@gmail.com>, 69066@debbugs.gnu.org
Subject: bug#69066: [PATCH] Fix compilation filtration if carriage is moved
Date: Mon, 19 Feb 2024 00:58:05 -0500 [thread overview]
Message-ID: <CADwFkm=2eov6t1bU2MDDVDu_Rf=yNemPVTVSXNY=tH56mBbNrg@mail.gmail.com> (raw)
In-Reply-To: <20240212003041.178-1-evgenij.gagauz@gmail.com>
Evgeny Gagauz <evgenij.gagauz@gmail.com> writes:
> * lisp/progmodes/compile.el (compilation-filter): If a process produces
> carriage cotrol characters then `compilation-filter-start' could point
> to a wrong place after applying `comint-carriage-motion'
> function. So its value is recalculated.
Thanks for the patch.
Could you provide more details about the issue you see?
Perhaps even a way to reproduce it?
> ---
> lisp/progmodes/compile.el | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
> index 11d400e145a..90ff414ad41 100644
> --- a/lisp/progmodes/compile.el
> +++ b/lisp/progmodes/compile.el
> @@ -2600,7 +2600,10 @@ and runs `compilation-filter-hook'."
> (when compilation-hidden-output
> (compilation--hide-output compilation-filter-start))
> (unless comint-inhibit-carriage-motion
> - (comint-carriage-motion (process-mark proc) (point)))
> + (comint-carriage-motion (process-mark proc) (point))
> + ;; `compilation-filter-start' could be moved after
> + ;; interpreting carriage control characters
> + (setq compilation-filter-start (marker-position (process-mark proc))))
> (set-marker (process-mark proc) (point))
> ;; Update the number of errors in compilation-mode-line-errors
> (compilation--ensure-parse (point))
> --
> 2.39.3 (Apple Git-145)
next prev parent reply other threads:[~2024-02-19 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 0:30 bug#69066: [PATCH] Fix compilation filtration if carriage is moved Evgeny Gagauz
2024-02-19 5:58 ` Stefan Kangas [this message]
2024-02-22 8:33 ` Gagauz Evgenij Vladimirovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=2eov6t1bU2MDDVDu_Rf=yNemPVTVSXNY=tH56mBbNrg@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=69066@debbugs.gnu.org \
--cc=evgenij.gagauz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).