From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#42168: 26.1; cperl-mode: Bad interpretation of $a++ / $b Date: Fri, 14 Aug 2020 02:06:46 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000091fb7f05acd2bdfa" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22728"; mail-complaints-to="usenet@ciao.gmane.io" To: Harald =?UTF-8?Q?J=C3=B6rg?= , 42168@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 14 11:07:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6Vg7-0005ny-Gd for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 11:07:11 +0200 Original-Received: from localhost ([::1]:54158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6Vg6-0002v4-73 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Aug 2020 05:07:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40090) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6Vfy-0002uh-UN for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 05:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40245) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6Vfy-0001xl-L8 for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 05:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6Vfy-0006KQ-G1 for bug-gnu-emacs@gnu.org; Fri, 14 Aug 2020 05:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Aug 2020 09:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42168 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed patch Original-Received: via spool by 42168-submit@debbugs.gnu.org id=B42168.159739601524313 (code B ref 42168); Fri, 14 Aug 2020 09:07:02 +0000 Original-Received: (at 42168) by debbugs.gnu.org; 14 Aug 2020 09:06:55 +0000 Original-Received: from localhost ([127.0.0.1]:51791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Vfr-0006Jz-55 for submit@debbugs.gnu.org; Fri, 14 Aug 2020 05:06:55 -0400 Original-Received: from mail-yb1-f172.google.com ([209.85.219.172]:35979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6Vfo-0006Jd-O9 for 42168@debbugs.gnu.org; Fri, 14 Aug 2020 05:06:53 -0400 Original-Received: by mail-yb1-f172.google.com with SMTP id g3so4851428ybc.3 for <42168@debbugs.gnu.org>; Fri, 14 Aug 2020 02:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to; bh=6SlZmQ077A2etCRhegaU2pt5kyoyGC3z9AP3ID317hw=; b=EipNWIT1NKhqYiPvDVuk1zgzXwFMoKwUtcFBXx2hS7JltDRXe7FzEjLB+5evhpRbcF u5S97CI0Ph7s3czFSiY2n2JblDUNEP3PRG4x+Rxj4BAnLvFKGVeYpo+qv5DmtZVaF6an EfqkowkE2pWUIupBT/9X8csn7ijGYbgiu+dik28pe3Nwht7/j1AiWrIL2cnm/Q/NoSyj B/1e7fZRma2E85ge9QQEZGfN+QHYyn9JaKYmIwM6si5s6hBmxwizQjOvtObJel7+2Z3D 4PH2DPjfzfyHuTr1C089+iTVb7950VAyw+wK9cYVj1WK3+jgkCz0/IofslQclSlHVuQd vqmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=6SlZmQ077A2etCRhegaU2pt5kyoyGC3z9AP3ID317hw=; b=PVI43O2Dlma2mj0ebUfQ0Z8+z9bwuyCvYCXUl/f4GV0qCsO8j4F95qP6SEqUwiO7RQ qkV67DoAnnwz6PwNerJTpBprV/053SSxWppfNh0HyIUPneoxKZKZm0s6m+HOdWLcHXL1 mSiJfP3vPuBOFtxZodIO6b4kHtwGSBZBDq4ZGcTBmCRqVrD8ptKR1hB2T7LT2xQA0eeS 809blsbbrqGoYqnqyCBKmKyYmJY1U+QEUslAm8tMv8CSUJRdtcqLjoNrX++jgXiH/bps +lliXTCRrf1JebQUnuOnm+p790Yrl6zQPmOFRWH9nu0ccexKtsKPh4H3M5PqtfEcX6gi ncUg== X-Gm-Message-State: AOAM5314I4IUEczsLDsj6N+0txzj+Af7Gq6dI2bmueNrP5ymhJCGI+pC WnCSe50wnROQPg4JUxVqGXa50Ml7B+ibRNccNOg= X-Google-Smtp-Source: ABdhPJxFeQ4VmmUXgBvuqL0yPW8W6VyGPcw+rzAo87A80pGIv2LfAgG4VJa8Z2WDUPfZrCAOoYJXMM0+fIvAk0vzhqQ= X-Received: by 2002:a25:9843:: with SMTP id k3mr2445033ybo.466.1597396007114; Fri, 14 Aug 2020 02:06:47 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Aug 2020 02:06:46 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185084 Archived-At: --00000000000091fb7f05acd2bdfa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable close 42168 28.1 thanks Hi Harald, Harald J=C3=B6rg writes: > Thank you for your thorough review. I'm rather new to Emacs Lisp, and > also to the Emacs development workflows, so this is highly > appreciated. Happy to help, we've all been there at one point. >> lisp/progmodes/cperl-mode-tests.el > > I guess this was meant to read test/lisp/progmodes/cperl-mode-tests.el. Indeed. > Also, I've added a ChangeLog-style attachment, as suggested by Lars > Ingebrigtsen in his comment to Bug#42355. Thanks. Your diff looks good, so I've installed the attached patch with some minor fixes, and I'm closing the bug with this message. Next time, could you please add the ChangeLog entry to the git commit message and send the result of `git format-patch -1` as an attachment? That saves time when installing the change. Please see the attached for an example, and you can read more in CONTRIBUTE in emacs.git. It is also useful to consult the git log for more examples. Welcome again as an Emacs contributor! Best regards, Stefan Kangas --00000000000091fb7f05acd2bdfa Content-Type: text/x-diff; charset="utf-8"; name="0001-cperl-mode-Highlight-a-b-correctly.patch" Content-Disposition: attachment; filename="0001-cperl-mode-Highlight-a-b-correctly.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: acda5e10cee4eb2a_0.1 RnJvbSBmM2ZmNTEyODhmYTAzNzBhOWVhMzMzMTJiMTg4NTY1ZTRmMmI1OTVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/SGFyYWxkPTIwSj1DMz1CNnJnPz0gPGhhakBw b3N0ZW8uZGU+CkRhdGU6IEZyaSwgMTQgQXVnIDIwMjAgMTA6MDE6MzAgKzAyMDAKU3ViamVjdDog W1BBVENIXSBjcGVybC1tb2RlOiBIaWdobGlnaHQgJ3skYSsrIC8gJGJ9JyBjb3JyZWN0bHkKCiog bGlzcC9wcm9nbW9kZXMvY3BlcmwtbW9kZS5lbCAoY3BlcmwtZmluZC1wb2RzLWhlcmVzKToKUmVj b2duaXplIHskYSsrIC8gJGJ9IGNvcnJlY3RseSBhcyBkaXZpc2lvbi4gIChCdWcjNDIxNjgpCiog dGVzdC9saXNwL3Byb2dtb2Rlcy9jcGVybC1tb2RlLXRlc3RzLmVsOiBOZXcgZmlsZSB3aXRoIHRl c3QKdmVyaWZ5aW5nIHRoZSBmaXguCi0tLQogbGlzcC9wcm9nbW9kZXMvY3BlcmwtbW9kZS5lbCAg ICAgICAgICAgIHwgIDMgKysKIHRlc3QvbGlzcC9wcm9nbW9kZXMvY3BlcmwtbW9kZS10ZXN0cy5l bCB8IDUwICsrKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNTMgaW5z ZXJ0aW9ucygrKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9wcm9nbW9kZXMvY3Blcmwt bW9kZS10ZXN0cy5lbAoKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUuZWwg Yi9saXNwL3Byb2dtb2Rlcy9jcGVybC1tb2RlLmVsCmluZGV4IDYxMjJjYWY1MTguLjJkMjcxM2Ez NmEgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUuZWwKKysrIGIvbGlzcC9w cm9nbW9kZXMvY3BlcmwtbW9kZS5lbApAQCAtMzk3OSw2ICszOTc5LDkgQEAgY3BlcmwtZmluZC1w b2RzLWhlcmVzCiAJCQkJICAgIChhbmQgKGVxIChwcmVjZWRpbmctY2hhcikgPy4pCiAJCQkJCSAo ZXEgKGNoYXItYWZ0ZXIgKC0gKHBvaW50KSAyKSkgPy4pKQogCQkJCSAgICAoYm9icCkpCisJCQkJ OzsgeyAkYSsrIC8gJGIgfSBkb2Vzbid0IHN0YXJ0IGEgcmVnZXgsIG5vciBkb2VzICRhLS0KKwkJ CQkobm90IChhbmQgKG1lbXEgKHByZWNlZGluZy1jaGFyKSAnKD8rID8tKSkKKwkJCQkJICAoZXEg KHByZWNlZGluZy1jaGFyKSAoY2hhci1iZWZvcmUgKDEtIChwb2ludCkpKSkpKQogCQkJCTs7ICBt fGJsYWh8ID8gZm9vIDogYmFyOwogCQkJCShub3QKIAkJCQkgKGFuZCAoZXEgYyA/XD8pCmRpZmYg LS1naXQgYS90ZXN0L2xpc3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUtdGVzdHMuZWwgYi90ZXN0L2xp c3AvcHJvZ21vZGVzL2NwZXJsLW1vZGUtdGVzdHMuZWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMC4uZjM5ZjFiYTY1OAotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3QvbGlzcC9w cm9nbW9kZXMvY3BlcmwtbW9kZS10ZXN0cy5lbApAQCAtMCwwICsxLDUwIEBACis7OzsgY3Blcmwt bW9kZS10ZXN0cyAtLS0gVGVzdCBmb3IgY3BlcmwtbW9kZSAgLSotIGxleGljYWwtYmluZGluZzog dCAtKi0KKworOzsgQ29weXJpZ2h0IChDKSAyMDIwIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwg SW5jLgorCis7OyBBdXRob3I6IEhhcmFsZCBKw7ZyZyA8aGFqQHBvc3Rlby5kZT4KKzs7IE1haW50 YWluZXI6IEhhcmFsZCBKw7ZyZworOzsgS2V5d29yZHM6IGludGVybmFsCis7OyBIb21lcGFnZTog aHR0cHM6Ly9naXRodWIuY29tL0hhcmFsZEpvZXJnL2NwZXJsLW1vZGUKKworOzs7IENvbW1lbnRh cnk6CisKKzs7IFRoaXMgaXMgYSBjb2xsZWN0aW9uIG9mIHRlc3RzIGZvciB0aGUgZm9udGlmaWNh dGlvbiBvZiBDUGVybC1tb2RlLgorCis7OyBSdW4gdGhlc2UgdGVzdHMgaW50ZXJhY3RpdmVseToK Kzs7IChlcnQtcnVuLXRlc3RzLWludGVyYWN0aXZlbHkgJyh0YWcgOmZvbnRpZmljYXRpb24pKQor Cis7OzsgQ29kZToKKworKGRlZnVuIGNwZXJsLXRlc3QtZmFjZSAodGV4dCByZWdleHApCisgICJS ZXR1cm5zIHRoZSBmYWNlIG9mIHRoZSBmaXJzdCBjaGFyYWN0ZXIgbWF0Y2hlZCBieSBSRUdFWFAg aW4gVEVYVC4iCisgIChpbnRlcmFjdGl2ZSkKKyAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgIChp bnNlcnQgdGV4dCkKKyAgICAgIChjcGVybC1tb2RlKQorICAgICAgKGZvbnQtbG9jay1lbnN1cmUg KHBvaW50LW1pbikgKHBvaW50LW1heCkpCisgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQor ICAgICAgKHJlLXNlYXJjaC1mb3J3YXJkIHJlZ2V4cCkKKyAgICAgIChnZXQtdGV4dC1wcm9wZXJ0 eSAobWF0Y2gtYmVnaW5uaW5nIDApICdmYWNlKSkpCisKKyhlcnQtZGVmdGVzdCBjcGVybC1tb2Rl LXRlc3QtYnVnLTQyMTY4ICgpCisgICJWZXJpZnkgdGhhdCAnLycgaXMgYSBkaXZpc2lvbiBhZnRl ciArKyBvciAtLSwgbm90IGEgcmVnZXhwLgorUmVwb3J0ZWQgaW4gaHR0cHM6Ly9naXRodWIuY29t L2pyb2Nrd2F5L2NwZXJsLW1vZGUvaXNzdWVzLzQ1LgorSWYgc2VlbiBhcyByZWd1bGFyIGV4cHJl c3Npb24sIHRoZW4gdGhlIHNsYXNoIGlzIGRpc3BsYXllZCB1c2luZworZm9udC1sb2NrLWNvbnN0 YW50LWZhY2UuICBJZiBzZWVuIGFzIGEgZGl2aXNpb24sIHRoZW4gaXQgZG9lc24ndAoraGF2ZSBh IGZhY2UgcHJvcGVydHkuIgorICA6dGFncyAnKDpmb250aWZpY2F0aW9uKQorICA7OyBUaGUgbmV4 dCB0d28gUGVybCBleHByZXNzaW9ucyBoYXZlIGRpdmlzaW9ucy4gIFBlcmwgInB1bmN0dWF0aW9u IgorICA7OyBvcGVyYXRvcnMgZG9uJ3QgZ2V0IGEgZmFjZS4KKyAgKGxldCAoKGNvZGUgInsgJGEr KyAvICRiIH0iKSkKKyAgICAoc2hvdWxkIChlcXVhbCAoY3BlcmwtdGVzdC1mYWNlIGNvZGUgIi8i ICkgbmlsKSkpCisgIChsZXQgKChjb2RlICJ7ICRhLS0gLyAkYiB9IikpCisgICAgKHNob3VsZCAo ZXF1YWwgKGNwZXJsLXRlc3QtZmFjZSBjb2RlICIvIiApIG5pbCkpKQorICA7OyBUaGUgbmV4dCB0 d28gUGVybCBleHByZXNzaW9ucyBoYXZlIHJlZ3VsYXIgZXhwcmVzc2lvbnMuICBUaGUKKyAgOzsg ZGVsaW1pdGVyIG9mIGEgUkUgaXMgZm9udGlmaWVkIHdpdGggZm9udC1sb2NrLWNvbnN0YW50LWZh Y2UuCisgIChsZXQgKChjb2RlICJ7ICRhKyAvICRiIH0gIyAvIikpCisgICAgKHNob3VsZCAoZXF1 YWwgKGNwZXJsLXRlc3QtZmFjZSBjb2RlICIvIiApIGZvbnQtbG9jay1jb25zdGFudC1mYWNlKSkp CisgIChsZXQgKChjb2RlICJ7ICRhLSAvICRiIH0gIyAvIikpCisgICAgKHNob3VsZCAoZXF1YWwg KGNwZXJsLXRlc3QtZmFjZSBjb2RlICIvIiApIGZvbnQtbG9jay1jb25zdGFudC1mYWNlKSkpKQor Cis7OzsgY3BlcmwtbW9kZS10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMjguMAoK --00000000000091fb7f05acd2bdfa--