unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43792@debbugs.gnu.org
Subject: bug#43792: [PATCH] Add ert macros to get resource file names
Date: Fri, 16 Oct 2020 02:47:45 -0700	[thread overview]
Message-ID: <CADwFkm=1SWmEKTpuKuyfNieAY9i=GgpCa9-GX4e8W8X_rKGHyA@mail.gmail.com> (raw)
In-Reply-To: <877ds5qgec.fsf@gnus.org>

close 43792 28.1
thanks

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> There's a lot of repetitive code to get at the resource directories for
>> tests.  That's obviously boring, so I'd propose something like the
>> following two macros to make it easier:
>>
>> (ert-resource-directory)
>> (ert-resource-file NAME)
>>
>> Please see the attached patch, the second of which uses the macros in
>> our test suite.  Not sure if they should be in ert.el, so I put them in
>> ert-x.el for now to play it safe.
>
> Looks good to me.

Thanks for reviewing; pushed to master as commit f52a775ae2 and
1f44a77672.





      reply	other threads:[~2020-10-16  9:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04 12:40 bug#43792: [PATCH] Add ert macros to get resource file names Stefan Kangas
2020-10-04 17:25 ` Michael Albinus
2020-10-16  9:47   ` Stefan Kangas
2020-10-05  7:30 ` Lars Ingebrigtsen
2020-10-16  9:47   ` Stefan Kangas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADwFkm=1SWmEKTpuKuyfNieAY9i=GgpCa9-GX4e8W8X_rKGHyA@mail.gmail.com' \
    --to=stefan@marxist.se \
    --cc=43792@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).