From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#59290: 29.0.50; [PATCH] Buffer-localize temporary-goal-column Date: Sun, 3 Sep 2023 02:36:06 -0700 Message-ID: References: <87o7t76g39.fsf@dick> <83pmdngk8i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28392"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59290@debbugs.gnu.org, dick To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 11:37:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcjXS-00079O-4g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 11:37:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcjXJ-0002MB-O5; Sun, 03 Sep 2023 05:36:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcjXH-0002L3-Q9 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 05:36:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcjXH-0006GU-Dt for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 05:36:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcjXR-0001fI-Lm for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 05:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 09:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59290 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 59290-submit@debbugs.gnu.org id=B59290.16937337846338 (code B ref 59290); Sun, 03 Sep 2023 09:37:01 +0000 Original-Received: (at 59290) by debbugs.gnu.org; 3 Sep 2023 09:36:24 +0000 Original-Received: from localhost ([127.0.0.1]:39504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcjWq-0001eA-DG for submit@debbugs.gnu.org; Sun, 03 Sep 2023 05:36:24 -0400 Original-Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:58516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcjWo-0001dw-Qf for 59290@debbugs.gnu.org; Sun, 03 Sep 2023 05:36:23 -0400 Original-Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50078eba7afso833523e87.0 for <59290@debbugs.gnu.org>; Sun, 03 Sep 2023 02:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693733767; x=1694338567; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=1+Uyv0nonpTwqneqguY0ilYH9sXIL25MA36Wi1kEZHY=; b=lDPv3K+MgCj0MdVfnGgextL8Yx/gajwBFVNFdxUUBWNzhfWATN0mOOon5wZUH4Qpx3 CDDOLKmrvE1BuswouvgI9lHThXAoX9p7zVuAPxjggS6Yn/Cxp2EsAfuMk4TQwZGDTs5l YQphGeU3Zy3QYHzYjYAGRbQHKMdlJiWDg4wgfwmG2OchsxE0kBsyPlri8O5nefOz9uHw rKOhgm3qPlnBghjbq9AxQ7NIgq6d6zydNUO4YBpJbowTyHKdjeQOAQrZ5hqWgIoPgmIb 08YUZoChW+TcxmZn+DKYIgjLGsw0ZAeLGkgUFZeq7Q96eLZQLA5ByAGs+Kupz2JUUz4X d3WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693733767; x=1694338567; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1+Uyv0nonpTwqneqguY0ilYH9sXIL25MA36Wi1kEZHY=; b=bDv0Thjs3nDiFUWwQix+zcKCRLV6IcfDVlWm1crZNjdbpejWCVFg+X1jWv2+G5YRdF W7wMMBo4X9SYQxgKTKWYXufkNkOPPBoQqcpZsgmKmEO6W0GFU9pNoReoDt46krS2CzqX A4+H9JcISSgU/i3dz0enjWtQRcERFVNKI1LQcmuCyoZZctpg58uGLHhfHRz1vesE0gkY 0Rk8OMjP6caaeeh1libn+q99zCObIgBsPxt6yx5OICKicJRVowc0ZUr1dsxE+qZfANuP uSOXlxOsz3t1gLGiqM5xBXJ14AnKp7HmE0OmR7Nj7f+YsP0Tq5Zkk2oMOmxiOv5UJDVu 6JFA== X-Gm-Message-State: AOJu0Yxun686vsNa/rYBLqDEwcL9a0+RGP6tkB9M792vzuha/te8V5xi m1+baq0wUK5jEPAaPG8lbdm8nkRQ1beTtFmaBdw= X-Google-Smtp-Source: AGHT+IHatZod1q4zpl/iTkTnZuodGmyVnciTCnUQaLjOHQOoGdapGry369Kty0x2XCgBtMcUKolu2dMKsYGDQjdSm2I= X-Received: by 2002:a05:6512:340a:b0:500:af82:7dd4 with SMTP id i10-20020a056512340a00b00500af827dd4mr5300023lfr.3.1693733766600; Sun, 03 Sep 2023 02:36:06 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 3 Sep 2023 02:36:06 -0700 In-Reply-To: <83pmdngk8i.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 16 Nov 2022 14:24:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269115 Archived-At: Eli Zaretskii writes: >> From: dick >> Date: Tue, 15 Nov 2022 16:52:10 -0500 >> >> emacs -Q -l cl-lib --eval " \ >> (with-temp-buffer \ >> (save-excursion \ >> (insert \"=D7=A2=D6=B4=D7=91=D6=B0=D7=A8=D6=B4=D7=99=D7=AA\n=D7=A2= =D6=B4=D7=91=D6=B0=D7=A8=D6=B4=D7=99=D7=AA\")) \ >> (call-interactively (function next-line)) \ >> (with-temp-buffer \ >> (save-excursion (insert \"English\nEnglish\")) \ >> (call-interactively (function next-line)) \ >> (cl-assert (zerop (current-column)))))" >> >> >> >From 44ca27270bdd7786ddb36469149128b6d18aac9a Mon Sep 17 00:00:00 2001 >> From: dickmao >> Date: Tue, 15 Nov 2022 16:03:48 -0500 >> Subject: [PATCH] Temporary goal column leaks >> >> * lisp/simple.el (temporary-goal-column): Buffer-localize. >> * test/lisp/simple-tests.el (line-move-visual-goal-column-leakage): >> Test it. > > Thanks, but please provide a meaningful commit log message with an > explanation of the problem and the solution. AFAIU, it isn't > self-evident. For example, if I invoke the program interactively in a > running Emacs session, the problem doesn't happen. Your test seems to > acknowledge that, as is evidenced by this: > >> +(ert-deftest line-move-visual-goal-column-leakage () >> + (skip-unless (not noninteractive)) <<<<<<<<<<<<<<<<<<<<<<< > > but without any explanation. > > With the root cause of this stated explicitly, it might be that we > will want or at least consider a different solution. dick, could you please provide the information Eli is asking for above? Thanks in advance.