From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wang Diancheng Newsgroups: gmane.emacs.bugs Subject: bug#64590: Patch: fix gud-go in gdb-mi.el Date: Fri, 14 Jul 2023 11:06:32 +0800 Message-ID: References: <834jm85gsi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000950915060069ae37" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2503"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64590@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 14 05:03:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qK95a-0000QO-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jul 2023 05:03:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qK95E-0002aY-AZ; Thu, 13 Jul 2023 23:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qK95D-0002ZC-5m for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 23:03:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qK95C-0006Zm-Tp for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 23:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qK95C-0004ep-GP for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 23:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wang Diancheng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jul 2023 03:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64590 X-GNU-PR-Package: emacs Original-Received: via spool by 64590-submit@debbugs.gnu.org id=B64590.168930377417888 (code B ref 64590); Fri, 14 Jul 2023 03:03:02 +0000 Original-Received: (at 64590) by debbugs.gnu.org; 14 Jul 2023 03:02:54 +0000 Original-Received: from localhost ([127.0.0.1]:41178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK953-0004eR-Iy for submit@debbugs.gnu.org; Thu, 13 Jul 2023 23:02:53 -0400 Original-Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]:55766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qK94y-0004e4-Bw for 64590@debbugs.gnu.org; Thu, 13 Jul 2023 23:02:52 -0400 Original-Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b6f0508f54so21428631fa.3 for <64590@debbugs.gnu.org>; Thu, 13 Jul 2023 20:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689303761; x=1691895761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8Fd5ZVegXFV1dFBcN9a2OoKRqjBfgShQW4f/J1MlRG4=; b=Qt96MXxN3NUJ5qR8dSojKGt5uWufblvcpCNp7fvT+Owq+BDxjt4wbShTfxpxtj4t2k jw08rkxUjVorkGDCOxmLWl6lCaQ08OrIIEBZl1ZU+vvYhZGDLEc3VgsIyqRGIAFMd8T9 C32tlsVBhWLsMiPumZ2/0fxEHnvoAiY9y2izbPw3pzOrjVs/qB53xZtwQjX5ztFTeWWG GtgWKUuxlmmOCJjTaeTOlorniV1I+adDWxB9yCfVccSOFpHsm+lhUNcAIIZjOyebqa37 EMYclUAda52PJ0GePnoBKnveAnPnq78fh0UJYnfE2qjQ9K4LIbKnYfNoeWH/+tX52mDi nLig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689303761; x=1691895761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Fd5ZVegXFV1dFBcN9a2OoKRqjBfgShQW4f/J1MlRG4=; b=TP8DbXFkn//zfNrRWo9L8s5Xn2b/IUVvWz8QpTe8qzG5W4PnrH0/rEfhyI6+ttYvZu sJnWSpaeokiSrkoe2WR/8cJYnTCEbQQomL/6J0OY/ZpUlvKoWIfsHsf4CbgAbyIYNDfm K9JQy+mtULnO/IHmxrMqPBnsZFXcm/gL+s5k9GywP0xVq9bLkIPFVbJ2mzwmM7vflz+D gPwiGRLg1VzwAoULacfaMrw8U+Cn8jRp+rl3pOB4AEIkfJaS484SOSB6DfD71HrovPsV vOcPlWaECq7qpa+blLtpioIBDmND0yJ3UJtg0OwNvhXOaytQ/kfZFBsrEGsPbRDdcOxm ongg== X-Gm-Message-State: ABy/qLbJhAY8FtHn8rdTm31cbyg4rHPV63jR8Pie0DrZtZcIQX2xo8lN KHgb1pmWwCSk86b6GhLY58dn+7/Rld0GwQeMXdg= X-Google-Smtp-Source: APBJJlGaLktUiTjreGnQlbgB+UhVT8HZI1DtMKvm67CJPRiMnkMLTBHMAf7PFAh32jwXRBf3XwMKQ0Rxmn7bKWbhL2k= X-Received: by 2002:a05:651c:d6:b0:2b7:310:65da with SMTP id 22-20020a05651c00d600b002b7031065damr2879647ljr.24.1689303760826; Thu, 13 Jul 2023 20:02:40 -0700 (PDT) In-Reply-To: <834jm85gsi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265065 Archived-At: --000000000000950915060069ae37 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii =E4=BA=8E2023=E5=B9=B47=E6=9C=8813=E6=97=A5=E5= =91=A8=E5=9B=9B 16:58=E5=86=99=E9=81=93=EF=BC=9A > > > From: Wang Diancheng > > Date: Thu, 13 Jul 2023 12:40:58 +0800 > > > > document of gud-go says "Start or continue execution. Use a prefix to > > specify arguments." but it always prompts for program arguments > > regardless of whether "C-u" is pressed because arg is numeric prefix > > here. > > Right, gud-def specifies '(interactive "p")'. > > > The attachment is a patch to change gud-go just prompts if > > prefix is not 1. > > This will have the subtlety that "C-u 1 C-v" will fail to ask for > program arguments. Shouldn't we instead look at current-prefix-arg? > Thanks. Yes, I think it's a good idea. the patch is updated as that. > Thanks. --000000000000950915060069ae37 Content-Type: text/x-patch; charset="US-ASCII"; name="gud-go-v2.patch" Content-Disposition: attachment; filename="gud-go-v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lk1zy0be0 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2dkYi1taS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dk Yi1taS5lbAppbmRleCAxOTliZTMzMThhMS4uYTEwOTFkZTQzZTkgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2dkYi1taS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9nZGItbWkuZWwKQEAgLTk4 Nyw3ICs5ODcsNyBAQCBnZGIKIAkgICAiXEMtdSIgIkNvbnRpbnVlIHRvIGN1cnJlbnQgbGluZSBv ciBhZGRyZXNzLiIpCiAgIChndWQtZGVmCiAgICBndWQtZ28gKHByb2duCi0gICAgICAgICAgICAo d2hlbiBhcmcKKyAgICAgICAgICAgICh3aGVuIChhbmQgY3VycmVudC1wcmVmaXgtYXJnIGFyZykK ICAgICAgICAgICAgICAgKGd1ZC1jYWxsIChjb25jYXQgIi1leGVjLWFyZ3VtZW50cyAiCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChyZWFkLXN0cmluZyAiQXJndW1lbnRzIHRvIGV4 ZWMtcnVuOiAiKSkpKQogICAgICAgICAgICAgKGd1ZC1jYWxsCg== --000000000000950915060069ae37--