From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Wang Diancheng Newsgroups: gmane.emacs.bugs Subject: bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el Date: Fri, 7 Jul 2023 14:25:58 +0800 Message-ID: References: <87pm5q4mwc.fsf@yahoo.com> <83352m73g3.fsf@gnu.org> <83wmzx3qoj.fsf@gnu.org> <83leg2u7e6.fsf@gnu.org> <83sfa1ikhc.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 64186-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 08:23:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHesA-0005LM-OH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 08:23:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHerv-0001Zg-Ub; Fri, 07 Jul 2023 02:23:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHeru-0001W1-B8 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 02:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHeru-0006h8-39 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 02:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHert-0007ZT-MS for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 02:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Wang Diancheng Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jul 2023 06:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64186 X-GNU-PR-Package: emacs Original-Received: via spool by 64186-done@debbugs.gnu.org id=D64186.168871093829033 (code D ref 64186); Fri, 07 Jul 2023 06:23:01 +0000 Original-Received: (at 64186-done) by debbugs.gnu.org; 7 Jul 2023 06:22:18 +0000 Original-Received: from localhost ([127.0.0.1]:42432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHerB-0007YC-Td for submit@debbugs.gnu.org; Fri, 07 Jul 2023 02:22:18 -0400 Original-Received: from mail-lj1-f182.google.com ([209.85.208.182]:58452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHer8-0007Xw-Tv for 64186-done@debbugs.gnu.org; Fri, 07 Jul 2023 02:22:16 -0400 Original-Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-2b6afc1ceffso23617411fa.0 for <64186-done@debbugs.gnu.org>; Thu, 06 Jul 2023 23:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688710929; x=1691302929; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6llzpYEZhVwzqoj/7lxvdtrrSYP1GxNa10KuABr+IYQ=; b=XWoDvcqUOyAKhzRHwiJvnklnShbx5L+qbnz0hfbEyxn/YS2y4aWwIBvUarDzNYwopQ MdUJoIA5zcVy/l1pLeAkNzMb2091lLih/3QNPfZNTIWng/oO4GjEaqC2zJBTdL9TzSws zqB1RnpTbYfOw2SVoHrqJRJR1/rUtBF9XqPax3cgdRoa6/CS/Q3D5eXwuffYQTO5Bssa XuOSakZVQrcuG/qNjwqwuUsEoUTOGxiDm3JIgye45ky5F9gTXhka3DaBkM2pdM90zlQU jeqhqkVwQeyQwss/k8EU0u4dq0eiWwGGeY8vit/exiMHyTnzseISi7mGL4EhfMHOBret 3C1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688710929; x=1691302929; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6llzpYEZhVwzqoj/7lxvdtrrSYP1GxNa10KuABr+IYQ=; b=AIp742Adn6Mwwte/XNCD1o5YpRK1iC2VKH0oiD1chGftMXsySgiuSPz6XuPbtEfmE0 w0vLWX+abaqpLjbH3dQvM36m3+edvcrmXCDRQrDwAT5BHUQBX6nX2jJ+VNDHqv3JYXC5 F1ER0aIzupjlOac1T+U6HIa31p91Bl9XwrBSKDEbiyGBO5K1AS3SmpM1WaU0lfrg9cNK 6ZeckGJ4GnMOiCqQpbKap+3Gl1yi7rZgDZ2InOIzVF98YJhldTlWR8f7pS0JRftx5pil qFZw5CWzEz5kKw1TPJylgM8D/RXF7lPMafS2hNk/79a3Y4M4XW/hsf2d4rCzN25dd+MT nsWg== X-Gm-Message-State: ABy/qLYLJZsF55bL7G44RX9DfQeqvOOiNgHK15nMIBqs8rvQqOj3A5cK 4eSc4O0AB+Yuv796yYfQeynOivOlhYFCr279/bw= X-Google-Smtp-Source: APBJJlF3xk1zQ1hUu2A2fbKtn5o3ctHAgJ+UmwVCVKDMG+cb5Ww7iNgPqXSLWE9IUhUXboyrBV4NbyXI26nJiHcv8Fw= X-Received: by 2002:a2e:9b47:0:b0:2b6:ffd1:165a with SMTP id o7-20020a2e9b47000000b002b6ffd1165amr3089189ljj.30.1688710928729; Thu, 06 Jul 2023 23:22:08 -0700 (PDT) In-Reply-To: <83sfa1ikhc.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264704 Archived-At: Eli Zaretskii =E4=BA=8E2023=E5=B9=B47=E6=9C=886=E6=97=A5=E5= =91=A8=E5=9B=9B 15:10=E5=86=99=E9=81=93=EF=BC=9A > > > From: Wang Diancheng > > Date: Fri, 30 Jun 2023 15:08:18 +0800 > > Cc: luangruo@yahoo.com, 64186@debbugs.gnu.org > > > > Thanks for your comments.I think what exactly the value of > > `gdb-last-command=E2=80=99 is not essential for us. > > We just need to know whether `gdb-last-command' is a CLI command in > > the background or a MI command, > > since here we have already got its "running" status. We must check > > the target "async" feature after stopping > > the debuggee at the first time in function `gdb-stopped' if > > `gdb-last-command' is not a background CLI command or a MI command. > > > > > > + ;; Set `gdb-non-stop` when `gdb-last-command` is a CLI backgroun= d > > > > + ;; `run` command e.g. r& or MI command `-exec-run` > > > > + (when (or (string-match "&\s*$" gdb-last-command) > > > > + (string-match "-exec-run" gdb-last-command)) > > > > + (gdb-try-check-target-async-support)) > > > > > > And I'm not sure I understand the idea behind this part: > > > > > > > @@ -2722,6 +2744,9 @@ gdb-stopped > > > > > > > > ;; Print "(gdb)" to GUD console > > > > (when gdb-first-done-or-error > > > > + ;; If run target with CLI foreground command `run`, `target > > > > + ;; async` can only be checked when target is stopped > > > > + (gdb-try-check-target-async-support) > > > > (setq gdb-filter-output (concat gdb-filter-output gdb-prompt= -name))) > > > > > > Can you elaborate? > > > > Thanks for your questions, according to my comments above, If the > > debuggee has been started by > > a non-background CLI command e.g. =E2=80=9Crun" or "attach" (no trailin= g "&") > > commands, we can only > > check the target "async" feature at the code stack. > > > > > > > > Finally, please don't quote symbols `like this` in comments. Our > > > conventions are to quote symbols 'like this' or `like this'. > > > > I updated the patch, see the attachment. > > Thanks, installed on the master branch, and closing the bug. > > Note that, with this patch you have exhausted the amount of changes we > can accept from you without copyright assignment to the FSF. Would > you like to start the copyright assignment paperwork at this time, so > that we could accept more changes from you in the future? If you are > willing to start the assignment process, I will send you the form to > fill and the instructions to go with it. I'd like to start the copyright assignment paperwork, send me the form please. Thank you.