From: Wang Diancheng <dianchengwang@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, 64186-done@debbugs.gnu.org
Subject: bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el
Date: Fri, 7 Jul 2023 14:25:58 +0800 [thread overview]
Message-ID: <CADmgXh4b16Hj2XLuKbw3ymJEK6hBam4TUz+tKa_n4xaTKTMLgw@mail.gmail.com> (raw)
In-Reply-To: <83sfa1ikhc.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> 于2023年7月6日周四 15:10写道:
>
> > From: Wang Diancheng <dianchengwang@gmail.com>
> > Date: Fri, 30 Jun 2023 15:08:18 +0800
> > Cc: luangruo@yahoo.com, 64186@debbugs.gnu.org
> >
> > Thanks for your comments.I think what exactly the value of
> > `gdb-last-command’ is not essential for us.
> > We just need to know whether `gdb-last-command' is a CLI command in
> > the background or a MI command,
> > since here we have already got its "running" status. We must check
> > the target "async" feature after stopping
> > the debuggee at the first time in function `gdb-stopped' if
> > `gdb-last-command' is not a background CLI command or a MI command.
> >
> > > > + ;; Set `gdb-non-stop` when `gdb-last-command` is a CLI background
> > > > + ;; `run` command e.g. r& or MI command `-exec-run`
> > > > + (when (or (string-match "&\s*$" gdb-last-command)
> > > > + (string-match "-exec-run" gdb-last-command))
> > > > + (gdb-try-check-target-async-support))
> > >
> > > And I'm not sure I understand the idea behind this part:
> > >
> > > > @@ -2722,6 +2744,9 @@ gdb-stopped
> > > >
> > > > ;; Print "(gdb)" to GUD console
> > > > (when gdb-first-done-or-error
> > > > + ;; If run target with CLI foreground command `run`, `target
> > > > + ;; async` can only be checked when target is stopped
> > > > + (gdb-try-check-target-async-support)
> > > > (setq gdb-filter-output (concat gdb-filter-output gdb-prompt-name)))
> > >
> > > Can you elaborate?
> >
> > Thanks for your questions, according to my comments above, If the
> > debuggee has been started by
> > a non-background CLI command e.g. “run" or "attach" (no trailing "&")
> > commands, we can only
> > check the target "async" feature at the code stack.
> >
> > >
> > > Finally, please don't quote symbols `like this` in comments. Our
> > > conventions are to quote symbols 'like this' or `like this'.
> >
> > I updated the patch, see the attachment.
>
> Thanks, installed on the master branch, and closing the bug.
>
> Note that, with this patch you have exhausted the amount of changes we
> can accept from you without copyright assignment to the FSF. Would
> you like to start the copyright assignment paperwork at this time, so
> that we could accept more changes from you in the future? If you are
> willing to start the assignment process, I will send you the form to
> fill and the instructions to go with it.
I'd like to start the copyright assignment paperwork, send me the form
please. Thank you.
next prev parent reply other threads:[~2023-07-07 6:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 2:21 bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el Wang Diancheng
2023-06-20 7:24 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-20 9:25 ` Wang Diancheng
2023-06-20 9:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-20 11:55 ` Eli Zaretskii
2023-06-21 6:49 ` Wang Diancheng
2023-06-21 13:12 ` Eli Zaretskii
2023-06-28 3:51 ` Wang Diancheng
2023-06-29 6:09 ` Eli Zaretskii
2023-06-30 7:08 ` Wang Diancheng
2023-07-06 7:10 ` Eli Zaretskii
2023-04-25 19:18 ` bug#63084: 30.0.50; gud: set breakpoint while program is running tatrics
2023-04-26 6:10 ` Eli Zaretskii
2023-04-26 8:48 ` TatriX
2023-04-26 9:44 ` Eli Zaretskii
2023-04-26 11:19 ` Eli Zaretskii
2023-04-26 11:49 ` TatriX
2023-05-05 5:52 ` Eli Zaretskii
2023-05-05 5:53 ` Eli Zaretskii
2023-05-05 7:15 ` TatriX
2023-05-06 11:43 ` Eli Zaretskii
2023-05-27 21:22 ` TatriX
2023-05-28 5:28 ` Eli Zaretskii
2023-05-28 21:10 ` TatriX
2023-05-29 11:45 ` Eli Zaretskii
[not found] ` <handler.63084.D64186.168862741914107.notifdone@debbugs.gnu.org>
2023-07-11 7:31 ` bug#63084: closed (Re: bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el) TatriX
2023-07-11 12:24 ` Eli Zaretskii
2023-07-11 15:30 ` TatriX
2023-07-11 15:56 ` Eli Zaretskii
2023-07-11 17:49 ` TatriX
2023-07-13 6:26 ` Eli Zaretskii
2023-07-07 6:25 ` Wang Diancheng [this message]
2023-07-07 6:42 ` bug#64186: Patch: Suppress deprecated '-gdb-set target-async' warning message in gdb-mi.el Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADmgXh4b16Hj2XLuKbw3ymJEK6hBam4TUz+tKa_n4xaTKTMLgw@mail.gmail.com \
--to=dianchengwang@gmail.com \
--cc=64186-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).