unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Allen Li <darkfeline@felesatra.moe>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Allen Li <vianchielfaura@gmail.com>, 29575@debbugs.gnu.org
Subject: bug#29575: 25.3; Secret Service API treats labels as unique
Date: Sat, 8 Sep 2018 16:58:20 -0700	[thread overview]
Message-ID: <CADbSrJzoEBn53qz6GVRQTLraL8WNe7O56QgqOCrpbt0bELDcTA@mail.gmail.com> (raw)
In-Reply-To: <87in3kgvz9.fsf@gmx.de>

Yes, it works. I think this needs to be documented in the auth-source
manual, but otherwise all the functionality seems to be there and
working, thanks.
On Wed, Sep 5, 2018 at 2:00 AM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Michael Albinus <michael.albinus@gmx.de> writes:
>
> Hi Allen,
>
> >> Thanks.  It doesn't look like there is a way to get the object path by
> >> searching attributes?  That means there's no way to get the object path for
> >> a secret added from a cooperating application (that may not have a unique
> >> label).  secrets-search-items returns labels.  Ideally there would be a
> >> variant of secrets-search-items that returned object paths.
> >
> > Indeed. I've added the function `secrets-search-item-paths'.
> >
> >> Also, the docstring for secrets-create-items now has this line which I
> >> think is misleading:
> >>
> >> The label ITEM must not be unique in COLLECTION.
> >>
> >> Should it be:
> >>
> >> The label ITEM does not have to be unique in COLLECTION.
> >
> > Yes, sounds better. I've adapted the docstring.
> >
> > All changes are pushed to master. Thanks for your feedback!
>
> Does it work for you? I'd like to close bugs which are fixed for a long
> time; this is one of them.
>
> Best regards, Michael.





  reply	other threads:[~2018-09-08 23:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05  5:42 bug#29575: 25.3; Secret Service API treats labels as unique Allen Li
2017-12-11 13:02 ` Michael Albinus
2017-12-11 19:47   ` Allen Li
2017-12-12  8:35     ` Michael Albinus
2017-12-13  3:41       ` Allen Li
2017-12-13 14:41         ` Ted Zlatanov
2018-05-15 12:56       ` Michael Albinus
2018-05-21  7:51         ` Allen Li
2018-05-22  9:35           ` Michael Albinus
2018-09-05  9:00             ` Michael Albinus
2018-09-08 23:58               ` Allen Li [this message]
2018-09-11  9:49                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADbSrJzoEBn53qz6GVRQTLraL8WNe7O56QgqOCrpbt0bELDcTA@mail.gmail.com \
    --to=darkfeline@felesatra.moe \
    --cc=29575@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    --cc=vianchielfaura@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).