From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#46884: [PATCH] 27.1; Cannot run find-dired with -maxdepth Date: Sat, 13 Mar 2021 21:38:11 +0000 Message-ID: References: <83k0qo699n.fsf@gnu.org> <83ft1c62hk.fsf@gnu.org> <80ft1bed4g.fsf@felesatra.moe> <87r1kv8dnt.fsf@mail.linkov.net> <808s72e14s.fsf@felesatra.moe> <835z26ysa5.fsf@gnu.org> <831rcjjsht.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ff991e05bd71d58a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21839"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46884@debbugs.gnu.org, Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 13 22:39:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLByZ-0005X4-Ne for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 22:39:11 +0100 Original-Received: from localhost ([::1]:44194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLByY-0003Qo-Ou for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Mar 2021 16:39:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLByR-0003Qe-E3 for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 16:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49273) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lLByR-0007Rd-6f for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 16:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lLByR-0000Xj-54 for bug-gnu-emacs@gnu.org; Sat, 13 Mar 2021 16:39:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Mar 2021 21:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46884 X-GNU-PR-Package: emacs Original-Received: via spool by 46884-submit@debbugs.gnu.org id=B46884.16156715112022 (code B ref 46884); Sat, 13 Mar 2021 21:39:03 +0000 Original-Received: (at 46884) by debbugs.gnu.org; 13 Mar 2021 21:38:31 +0000 Original-Received: from localhost ([127.0.0.1]:60814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLBxu-0000WY-M9 for submit@debbugs.gnu.org; Sat, 13 Mar 2021 16:38:31 -0500 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:43848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lLBxs-0000WH-Dc for 46884@debbugs.gnu.org; Sat, 13 Mar 2021 16:38:30 -0500 Original-Received: by mail-oi1-f171.google.com with SMTP id d20so30667487oiw.10 for <46884@debbugs.gnu.org>; Sat, 13 Mar 2021 13:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xo+aWq4t4yC7FSa/+4gUoFCj912giGtv8LAg7NExQLI=; b=AkHibBmUWLh6TEpJK5GaYDPOUtiwceeJkchtl02w/ACP7a3QCGfRXYXKv0/7lxq7R9 5HIJvD8c/ZglTax7qP/wBr8T1mK2r0k6vizzxeekBz0pDgyrZxqPm8m6P8la8B/mO7Ns gehKLCdJLw9piodXrznrl38WjzaPNlT/3KrGyb+VFWrl5zvZhNIdnfxPeyUVMFc8+nrW Zrsf77m/c0rELC1BT2aGrzKZv5AbiHx1HqWjAyB+X8/J2zRHU2qAcvim2AI7wu5AJ/8s kAUlZMXjaZe1Zwa0Bpp4PsdImvK9DYzFAXNZLWnOBBhfhBuy+cJH0d8x3B4+6LW7uCRc LnBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xo+aWq4t4yC7FSa/+4gUoFCj912giGtv8LAg7NExQLI=; b=k/Xxu3X1qt5ptKMNjcKRG0nNqCN/XVoU+YqfAsta20/6t3K3eQ2DsbALneSrxwghU2 UIp0Aee0dLo4/BgQpQT3yg3VS8vQMSI0oHRPAvHEm4bVWkzlapIly8nDRNmmUEtfiyYI Y6PCpETecQE03fe0Qj18UuYRnwc+j2ZC1kQq8bS5V4jOyAhcWp5HdtFJ/LIg6wnPqyLU WAkaUuWp9XV0YPB9Y9lTCfKkdL/XzUcWrlKymXtKNZGxFoDEIwO/qj/eLISFDIMqzE+9 ZmgUuucR/JxSNxSYnlVNTDvluEB3Rz+xlbzZlmeinrRNkwR22mNWmlhB73lDx0y010SU 4LAQ== X-Gm-Message-State: AOAM532wOLFka0Qe0kcPWMt6hPiJq6YWFjPD+tksSeUVh3TBcTYqdI/u nlY5qPtUPgseYXlAbwZi3CjMIg/yJ75501kX8f05DhbX5ym0ogBU X-Google-Smtp-Source: ABdhPJzkocKiRK5AgXYrlloHnhypIBLC/KYqFNSvQbEvZaYOWp0kk/K7PCNr24hXhYWEyyxewdUxqtAB6V6LT7y9CH4= X-Received: by 2002:a05:6808:249:: with SMTP id m9mr14416827oie.170.1615671502795; Sat, 13 Mar 2021 13:38:22 -0800 (PST) In-Reply-To: <831rcjjsht.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202312 Archived-At: --000000000000ff991e05bd71d58a Content-Type: text/plain; charset="UTF-8" Sorry, I attached the wrong patch, here's the one for the rgrep approach. On Sat, Mar 13, 2021 at 9:46 AM Eli Zaretskii wrote: > > > From: Allen Li > > Date: Fri, 12 Mar 2021 08:08:55 +0000 > > Cc: Juri Linkov , 46884@debbugs.gnu.org > > > > Attached patch, does this approach look good? > > I guess my suggestion to additionally allow specification of > GLOBAL-ARGS interactively (via prefix arg) got voted down? > > > +--- > > +*** Optional 'global-args' parameter added to 'find-dired'. > > +This allows passing find global options like -maxdepth. > > "find" should be in quotes: 'find' > > > @@ -202,6 +203,7 @@ find-dired > > (setq default-directory dir > > find-args args ; save for next interactive call > > args (concat find-program " . " > > + (if global-args global-args "") > > 'concat' knows how to handle nil arguments, so you don't need the > empty string alternative here. Just (if global-args global-args) > should do. --000000000000ff991e05bd71d58a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-find-dired-Add-command-editing-like-rgrep.patch" Content-Disposition: attachment; filename="0001-find-dired-Add-command-editing-like-rgrep.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_km8937ye0 RnJvbSBhOGRjZTczY2EwYWUxNDgyZGJmYjhjMTBhODJmNTE1MjlmYmUxMjI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBGcmksIDEyIE1hciAyMDIxIDAwOjA3OjIyIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gZmlu ZC1kaXJlZDogQWRkIGNvbW1hbmQgZWRpdGluZyBsaWtlIHJncmVwCgpUaGUgb3JpZ2luYWwgZmlu ZC1kaXJlZCBkb2VzIG5vdCBhbGxvdyBmb3IgY29uc3RydWN0aW5nIHF1ZXJpZXMgbGlrZQoKIGZp bmQgLiAtbWF4ZGVwdGggMyBcKCBPVEhFUi1BUkdTIFwpIC1scwoKKiBsaXNwL2ZpbmQtZGlyZWQu ZWwgKGZpbmQtZGlyZWQpOiBBZGRlZCBjb21tYW5kIGVkaXRpbmcgYW5kCmNvbmZpcm1hdGlvbi4K LS0tCiBsaXNwL2ZpbmQtZGlyZWQuZWwgfCA3OSArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygrKSwgMjUg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9maW5kLWRpcmVkLmVsIGIvbGlzcC9maW5k LWRpcmVkLmVsCmluZGV4IGFkYzU2NzJlY2EuLmQyNjNiZWY3MDYgMTAwNjQ0Ci0tLSBhL2xpc3Av ZmluZC1kaXJlZC5lbAorKysgYi9saXNwL2ZpbmQtZGlyZWQuZWwKQEAgLTE1MSwxMyArMTUxLDE2 IEBAIGZpbmQtZGlyZWQtcmVmaW5lLWZ1bmN0aW9uCiAoZGVmdmFyIGZpbmQtYXJncyBuaWwKICAg Ikxhc3QgYXJndW1lbnRzIGdpdmVuIHRvIGBmaW5kJyBieSBcXFtmaW5kLWRpcmVkXS4iKQogCi07 OyBIaXN0b3J5IG9mIGZpbmQtYXJncyB2YWx1ZXMgZW50ZXJlZCBpbiB0aGUgbWluaWJ1ZmZlci4K LShkZWZ2YXIgZmluZC1hcmdzLWhpc3RvcnkgbmlsKQorKGRlZnZhciBmaW5kLWFyZ3MtaGlzdG9y eSBuaWwKKyAgIkhpc3RvcnkgbGlzdCBmb3IgYXJncyBwcm92aWRlZCB0byBgZmluZC1kaXJlZCcu IikKKworKGRlZnZhciBmaW5kLWRpcmVkLWhpc3RvcnkgbmlsCisgICJIaXN0b3J5IGxpc3QgZm9y IGBmaW5kLWRpcmVkJy4iKQogCiAoZGVmdmFyIGRpcmVkLXNvcnQtaW5oaWJpdCkKIAogOzs7IyMj YXV0b2xvYWQKLShkZWZ1biBmaW5kLWRpcmVkIChkaXIgYXJncykKKyhkZWZ1biBmaW5kLWRpcmVk IChkaXIgJm9wdGlvbmFsIGFyZ3MgY29uZmlybSkKICAgIlJ1biBgZmluZCcgYW5kIGdvIGludG8g RGlyZWQgbW9kZSBvbiBhIGJ1ZmZlciBvZiB0aGUgb3V0cHV0LgogVGhlIGNvbW1hbmQgcnVuIChh ZnRlciBjaGFuZ2luZyBpbnRvIERJUikgaXMgZXNzZW50aWFsbHkKIApAQCAtMTY2LDExICsxNjks MjkgQEAgZmluZC1kaXJlZAogZXhjZXB0IHRoYXQgdGhlIGNhciBvZiB0aGUgdmFyaWFibGUgYGZp bmQtbHMtb3B0aW9uJyBzcGVjaWZpZXMgd2hhdCB0bwogdXNlIGluIHBsYWNlIG9mIFwiLWxzXCIg YXMgdGhlIGZpbmFsIGFyZ3VtZW50LgogCitXaXRoIFxcW3VuaXZlcnNhbC1hcmd1bWVudF0gcHJl Zml4LCB5b3UgY2FuIGVkaXQgdGhlIGNvbnN0cnVjdGVkIHNoZWxsIGNvbW1hbmQgbGluZQorYmVm b3JlIGl0IGlzIGV4ZWN1dGVkLgorV2l0aCB0d28gXFxbdW5pdmVyc2FsLWFyZ3VtZW50XSBwcmVm aXhlcywgZGlyZWN0bHkgZWRpdCBhbmQgcnVuIGBncmVwLWZpbmQtY29tbWFuZCcuCisKIENvbGxl Y3Qgb3V0cHV0IGluIHRoZSBcIipGaW5kKlwiIGJ1ZmZlci4gIFRvIGtpbGwgdGhlIGpvYiBiZWZv cmUKLWl0IGZpbmlzaGVzLCB0eXBlIFxcW2tpbGwtZmluZF0uIgotICAoaW50ZXJhY3RpdmUgKGxp c3QgKHJlYWQtZGlyZWN0b3J5LW5hbWUgIlJ1biBmaW5kIGluIGRpcmVjdG9yeTogIiBuaWwgIiIg dCkKLQkJICAgICAocmVhZC1zdHJpbmcgIlJ1biBmaW5kICh3aXRoIGFyZ3MpOiAiIGZpbmQtYXJn cwotCQkJCSAgJyhmaW5kLWFyZ3MtaGlzdG9yeSAuIDEpKSkpCitpdCBmaW5pc2hlcywgdHlwZSBc XFtraWxsLWZpbmRdLgorCitXaGVuIGNhbGxlZCBwcm9ncmFtbWF0aWNhbGx5IGFuZCBBUkdTIGlz IG5pbCwgRElSIGlzIGV4cGVjdGVkIHRvCitzcGVjaWZ5IGEgY29tbWFuZCB0byBydW4uCisKK0lm IENPTkZJUk0gaXMgbm9uLW5pbCwgdGhlIHVzZXIgd2lsbCBiZSBnaXZlbiBhbiBvcHBvcnR1bml0 eSB0byBlZGl0IHRoZQorY29tbWFuZCBiZWZvcmUgaXQncyBydW4uIgorICAoaW50ZXJhY3RpdmUK KyAgIChjb25kCisgICAgKChhbmQgZ3JlcC1maW5kLWNvbW1hbmQgKGVxdWFsIGN1cnJlbnQtcHJl Zml4LWFyZyAnKDE2KSkpCisgICAgIChsaXN0IChyZWFkLWZyb20tbWluaWJ1ZmZlciAiUnVuOiAi IChjb25zIChmb3JtYXQgIiVzIC4gLWxzIiBmaW5kLXByb2dyYW0pCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgrIChsZW5ndGggZmluZC1wcm9ncmFtKSAz KSkKKwkJCQkgbmlsIG5pbCAnZmluZC1kaXJlZC1oaXN0b3J5KSkpCisgICAgKHQgKGxldCogKChk aXIgKHJlYWQtZGlyZWN0b3J5LW5hbWUgIlJ1biBmaW5kIGluIGRpcmVjdG9yeTogIiBuaWwgIiIg dCkpCisgICAgICAgICAgICAgIChhcmdzIChyZWFkLXN0cmluZyAiUnVuIGZpbmQgKHdpdGggYXJn cyk6ICIgZmluZC1hcmdzCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnKGZpbmQt YXJncy1oaXN0b3J5IC4gMSkpKQorCSAgICAgIChjb25maXJtIChlcXVhbCBjdXJyZW50LXByZWZp eC1hcmcgJyg0KSkpKQorCSAobGlzdCBkaXIgYXJncyBjb25maXJtKSkpKSkKICAgKGxldCAoKGRp cmVkLWJ1ZmZlcnMgZGlyZWQtYnVmZmVycykpCiAgICAgOzsgRXhwYW5kIERJUiAoIiIgbWVhbnMg ZGVmYXVsdC1kaXJlY3RvcnkpLCBhbmQgbWFrZSBzdXJlIGl0IGhhcyBhCiAgICAgOzsgdHJhaWxp bmcgc2xhc2guCkBAIC0xOTksMjMgKzIyMCwzMSBAQCBmaW5kLWRpcmVkCiAgICAgKGtpbGwtYWxs LWxvY2FsLXZhcmlhYmxlcykKICAgICAoc2V0cSBidWZmZXItcmVhZC1vbmx5IG5pbCkKICAgICAo ZXJhc2UtYnVmZmVyKQotICAgIChzZXRxIGRlZmF1bHQtZGlyZWN0b3J5IGRpcgotCSAgZmluZC1h cmdzIGFyZ3MJICAgICAgOyBzYXZlIGZvciBuZXh0IGludGVyYWN0aXZlIGNhbGwKLQkgIGFyZ3Mg KGNvbmNhdCBmaW5kLXByb2dyYW0gIiAuICIKLQkJICAgICAgIChpZiAoc3RyaW5nPSBhcmdzICIi KQotCQkJICAgIiIKLQkJCSAoY29uY2F0Ci0JCQkgIChzaGVsbC1xdW90ZS1hcmd1bWVudCAiKCIp Ci0JCQkgICIgIiBhcmdzICIgIgotCQkJICAoc2hlbGwtcXVvdGUtYXJndW1lbnQgIikiKQotCQkJ ICAiICIpKQotCQkgICAgICAgKGlmIChzdHJpbmctbWF0Y2ggIlxcYFxcKC4qXFwpIHt9IFxcKFxc XFw7XFx8XFwrXFwpXFwnIgotCQkJCQkgKGNhciBmaW5kLWxzLW9wdGlvbikpCi0JCQkgICAoZm9y bWF0ICIlcyAlcyAlcyIKLQkJCQkgICAobWF0Y2gtc3RyaW5nIDEgKGNhciBmaW5kLWxzLW9wdGlv bikpCi0JCQkJICAgKHNoZWxsLXF1b3RlLWFyZ3VtZW50ICJ7fSIpCi0JCQkJICAgZmluZC1leGVj LXRlcm1pbmF0b3IpCi0JCQkgKGNhciBmaW5kLWxzLW9wdGlvbikpKSkKKyAgICAoc2V0cSBkZWZh dWx0LWRpcmVjdG9yeSBkaXIpCisgICAgKGlmIChudWxsIGFyZ3MpCisgICAgICAgIChzZXRxIGFy Z3MgZGlyKQorICAgICAgKHNldHEgZmluZC1hcmdzIGFyZ3MJICAgICAgOyBzYXZlIGZvciBuZXh0 IGludGVyYWN0aXZlIGNhbGwKKyAgICAgICAgICAgIGFyZ3MgKGNvbmNhdCBmaW5kLXByb2dyYW0g IiAuICIKKwkJICAgICAgICAgKGlmIChzdHJpbmc9IGFyZ3MgIiIpCisJCSAgICAgICAgICAgICAi IgorCQkgICAgICAgICAgIChjb25jYXQKKwkJICAgICAgICAgICAgKHNoZWxsLXF1b3RlLWFyZ3Vt ZW50ICIoIikKKwkJICAgICAgICAgICAgIiAiIGFyZ3MgIiAiCisJCSAgICAgICAgICAgIChzaGVs bC1xdW90ZS1hcmd1bWVudCAiKSIpCisJCSAgICAgICAgICAgICIgIikpCisJCSAgICAgICAgIChp ZiAoc3RyaW5nLW1hdGNoICJcXGBcXCguKlxcKSB7fSBcXChcXFxcO1xcfFxcK1xcKVxcJyIKKwkJ CQkgICAgICAgICAgIChjYXIgZmluZC1scy1vcHRpb24pKQorCQkgICAgICAgICAgICAgKGZvcm1h dCAiJXMgJXMgJXMiCisJCQkgICAgICAgICAgICAgKG1hdGNoLXN0cmluZyAxIChjYXIgZmluZC1s cy1vcHRpb24pKQorCQkJICAgICAgICAgICAgIChzaGVsbC1xdW90ZS1hcmd1bWVudCAie30iKQor CQkJICAgICAgICAgICAgIGZpbmQtZXhlYy10ZXJtaW5hdG9yKQorCQkgICAgICAgICAgIChjYXIg ZmluZC1scy1vcHRpb24pKSkpKQorICAgIChpZiBjb25maXJtCisgICAgICAgIChzZXRxIGFyZ3MK KyAgICAgICAgICAgICAgKHJlYWQtZnJvbS1taW5pYnVmZmVyICJDb25maXJtOiAiCisJCQkgICAg ICAgICAgICBhcmdzIG5pbCBuaWwgJ2ZpbmQtZGlyZWQtaGlzdG9yeSkpCisgICAgICAoYWRkLXRv LWhpc3RvcnkgJ2ZpbmQtZGlyZWQtaGlzdG9yeSBhcmdzKSkKKwogICAgIDs7IFN0YXJ0IHRoZSBm aW5kIHByb2Nlc3MuCiAgICAgKHNoZWxsLWNvbW1hbmQgKGNvbmNhdCBhcmdzICImIikgKGN1cnJl bnQtYnVmZmVyKSkKICAgICAoZGlyZWQtbW9kZSBkaXIgKGNkciBmaW5kLWxzLW9wdGlvbikpCkBA IC0zOTMsNyArNDIyLDcgQEAgZmluZC1kaXJlZC1zZW50aW5lbAogCSAgICAgIDs7IHdpbGwgc3Rh eSBhcm91bmQgdW50aWwgTS14IGBsaXN0LXByb2Nlc3NlcycuCiAJICAgICAgKGRlbGV0ZS1wcm9j ZXNzIHByb2MpCiAJICAgICAgKGZvcmNlLW1vZGUtbGluZS11cGRhdGUpKSkpCi0JICAobWVzc2Fn ZSAiZmluZC1kaXJlZCAlcyBmaW5pc2hlZC4iIGJ1ZikpKSkKKyAgICAgIChtZXNzYWdlICJmaW5k LWRpcmVkICVzIGZpbmlzaGVkLiIgYnVmKSkpKQogCiAoZGVmdW4gZmluZC1kaXJlZC1zb3J0LWJ5 LWZpbGVuYW1lICgpCiAgICJTb3J0IGVudHJpZXMgaW4gKkZpbmQqIGJ1ZmZlciBieSBmaWxlIG5h bWUgbGV4aWNvZ3JhcGhpY2FsbHkuIgotLSAKMi4zMC4yCgo= --000000000000ff991e05bd71d58a--