From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#46884: [PATCH] 27.1; Cannot run find-dired with -maxdepth Date: Wed, 3 Mar 2021 01:20:45 +0000 Message-ID: References: <80k0qpdoqd.fsf@felesatra.moe> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a265b205bc97a9c3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35993"; mail-complaints-to="usenet@ciao.gmane.io" To: 46884@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 03 02:22:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHGDK-0009E2-JX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 02:22:10 +0100 Original-Received: from localhost ([::1]:50224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHGDJ-0007sg-3f for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 20:22:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHGDC-0007sV-G4 for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 20:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHGDC-0003XW-8y for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 20:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHGDC-0005DG-5W for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 20:22:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <80k0qpdoqd.fsf@felesatra.moe> Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Mar 2021 01:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46884 X-GNU-PR-Package: emacs Original-Received: via spool by 46884-submit@debbugs.gnu.org id=B46884.161473446519973 (code B ref 46884); Wed, 03 Mar 2021 01:22:02 +0000 Original-Received: (at 46884) by debbugs.gnu.org; 3 Mar 2021 01:21:05 +0000 Original-Received: from localhost ([127.0.0.1]:54705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHGCG-0005C5-Re for submit@debbugs.gnu.org; Tue, 02 Mar 2021 20:21:05 -0500 Original-Received: from mail-oi1-f177.google.com ([209.85.167.177]:40771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHGCD-0005BF-Dr for 46884@debbugs.gnu.org; Tue, 02 Mar 2021 20:21:03 -0500 Original-Received: by mail-oi1-f177.google.com with SMTP id w65so595610oie.7 for <46884@debbugs.gnu.org>; Tue, 02 Mar 2021 17:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=DyCB9bq+vlcVGZx8wLAddAaOmb2Bgflw7rKPWOSjFZI=; b=R1yb8aZSUXJjIRef4PxK19wFU3aKKA72OB3KMaaNo8UbqQN2tvTk/mGJ7A7iuXgA5B UrW1WbgK/oBFxNdpM6PeBZWLT46G3+9R2cIwHq7ixNC4Qb/LnGnq1ujWabJVOg0wRupN W+EXDpFbEckg5HZO76Z3hV/Jrjm/Ifxjl9qBO15kAvUvq0jAdd/jvE2UiPoxbr6cI8tp a55KIuj9BPPmXARzN61dF1XHUeKtRUd7sAZloMF5KA4TRs7xNE0wQ8xZYezFnwoXY6A6 Y4PVrmqztrJh6j5CstqtW1wdg1fe8SRk/ZYcAAegwwwTMXzFvwhm4OyUDLmHI2IxogQp OE9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=DyCB9bq+vlcVGZx8wLAddAaOmb2Bgflw7rKPWOSjFZI=; b=Wwyd8KUcDCGyD6EAx71U+hMGkdx+yiHgJATcE92cvwev6vHNDj+eHUqEYw+NrXA+dk CMSr51T284Rv4wlZHVKiAKfrn8p0iqlFY8plGq8iYbCXws5v7Vx1BQTA6tLX+2UasJ3I ConqXU4QOgZeESYIfDfoeq4zn3Zi231URw8ImaCrShzWPK7856YdnLKlAVm6TnqAs5/z ndyAsnp24XxCXZ3GeAyJeH4cpHSFJpbVmWSdsL5kx8sOBAb5P/C+qwfNOuIdmwoQ7lGw LQCAI/SmLWr9+RpB7xbi6lNCPGpr8fUfhEinfc+pv3YB9s8BZVOPH9C4vmaevqFVzPBC y+fg== X-Gm-Message-State: AOAM531laUktyxPdL8BKKKhl7BPAoriEAdi2jWZCcjrKkBcVBMDWYfAZ yWPJTvtuszw2z59TnRPZGcRoaPsOSNRsI9W7VATKyjr+ayo= X-Google-Smtp-Source: ABdhPJy8o/HOfXUEpXnAc/ZPZX2tq02A1C+hYQG26EYdQoVjGsGurHLV1Z+r33WVAZbemRkh64zu7WFxthx+UVkb2i4= X-Received: by 2002:a05:6808:2d7:: with SMTP id a23mr5350732oid.144.1614734455613; Tue, 02 Mar 2021 17:20:55 -0800 (PST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201251 Archived-At: --000000000000a265b205bc97a9c3 Content-Type: multipart/alternative; boundary="000000000000a265b005bc97a9c1" --000000000000a265b005bc97a9c1 Content-Type: text/plain; charset="UTF-8" Some additional context: I'm not asking for find-dired to support -maxdepth necessarily, but the way find-dired is structured makes it impossible to reuse any of the code to write a command that could support -maxdepth. I attached a patch pulling most of the find-dired logic into a find-dired-unescaped function so that it can be readily reused. --000000000000a265b005bc97a9c1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Some additional context: I'm not asking for find-= dired to support -maxdepth necessarily, but the way find-dired is structure= d makes it impossible to reuse any of the code to write a command that coul= d support -maxdepth.

I attached a patch pulling most of= the find-dired logic into a find-dired-unescaped function so that it can b= e readily reused.
--000000000000a265b005bc97a9c1-- --000000000000a265b205bc97a9c3 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-find-dired-Split-out-find-dired-unescaped.patch" Content-Disposition: attachment; filename="0001-find-dired-Split-out-find-dired-unescaped.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_klsr71hv0 RnJvbSA3YzIzMzVmZjUxNDBhMTM1NzhiMDNkM2IxNDczODFjMTExYmRkNTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBUdWUsIDIgTWFyIDIwMjEgMTQ6MjQ6MTYgLTA4MDAKU3ViamVjdDogW1BBVENIXSBmaW5k LWRpcmVkOiBTcGxpdCBvdXQgZmluZC1kaXJlZC11bmVzY2FwZWQKClRoZSBvcmlnaW5hbCBmaW5k LWRpcmVkIGRvZXMgbm90IGFsbG93IGZvciBjb25zdHJ1Y3RpbmcgcXVlcmllcyBsaWtlCgogZmlu ZCAuIC1tYXhkZXB0aCAzIFwoIE9USEVSLUFSR1MgXCkgLWxzCgpJdCBhbHNvIG1ha2VzIHRoZSBm aW5kLWRpcmVkIGxvZ2ljIGVzc2VudGlhbCBpbXBvc3NpYmxlIHRvIHJldXNlLgoKVGhlIG5ldyBm aW5kLWRpcmVkLXVuZXNjYXBlZCBjYW4gYnkgdXNlZCB0byBjb25zdHJ1Y3QgbW9yZSBpbnRlcmVz dGluZwpxdWVyaWVzLgoKKiBsaXNwL2ZpbmQtZGlyZWQuZWwgKGZpbmQtZGlyZWQtdW5lc2NhcGVk KTogQWRkZWQgbmV3IGZ1bmN0aW9uLgooZmluZC1kaXJlZCk6IFJld3JpdHRlbiB0byB1c2UgZmlu ZC1kaXJlZC11bmVzY2FwZWQuCi0tLQogZXRjL05FV1MgICAgICAgICAgIHwgIDQgKysrKwogbGlz cC9maW5kLWRpcmVkLmVsIHwgMzAgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiAyIGZp bGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA3M2YxMzZjZmE3Li4zYTNhMDg2MzczIDEwMDY0 NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtNjUzLDYgKzY1MywxMCBAQCBrZXlz LCBhZGQgdGhlIGZvbGxvd2luZyB0byB5b3VyIGluaXQgZmlsZToKIChnbG9iYWwtc2V0LWtleSAi XEMteFxDLWoiIG5pbCkKIChnbG9iYWwtc2V0LWtleSAiXEMteDRcQy1qIiBuaWwpCiAKKy0tLQor KioqIE5ldyBmdW5jdGlvbiAnZmluZC1kaXJlZC11bmVzY2FwZWQnIGVuYWJsZXMgdXNlciBjb2Rl IHRvIHJ1biBtb3JlCitjb21wbGljYXRlZCBmaW5kIGNvbW1hbmRzLgorCiAqKiBDaGFuZ2UgTG9n cyBhbmQgVkMKIAogKioqIE1vcmUgVkMgY29tbWFuZHMgY2FuIGJlIHVzZWQgZnJvbSBub24tZmls ZSBidWZmZXJzLgpkaWZmIC0tZ2l0IGEvbGlzcC9maW5kLWRpcmVkLmVsIGIvbGlzcC9maW5kLWRp cmVkLmVsCmluZGV4IGFkYzU2NzJlY2EuLmYwYWE3NjQ0NzEgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlu ZC1kaXJlZC5lbAorKysgYi9saXNwL2ZpbmQtZGlyZWQuZWwKQEAgLTE3MSw2ICsxNzEsMjUgQEAg ZmluZC1kaXJlZAogICAoaW50ZXJhY3RpdmUgKGxpc3QgKHJlYWQtZGlyZWN0b3J5LW5hbWUgIlJ1 biBmaW5kIGluIGRpcmVjdG9yeTogIiBuaWwgIiIgdCkKIAkJICAgICAocmVhZC1zdHJpbmcgIlJ1 biBmaW5kICh3aXRoIGFyZ3MpOiAiIGZpbmQtYXJncwogCQkJCSAgJyhmaW5kLWFyZ3MtaGlzdG9y eSAuIDEpKSkpCisgIChmaW5kLWRpcmVkLXdpdGgtYXJncyBkaXIgKGlmIChzdHJpbmc9IGFyZ3Mg IiIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIiCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoY29uY2F0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHNo ZWxsLXF1b3RlLWFyZ3VtZW50ICIoIikKKwkJCSAgICAgICAiICIgYXJncyAiICIKKwkJCSAgICAg ICAoc2hlbGwtcXVvdGUtYXJndW1lbnQgIikiKQorCQkJICAgICAgICIgIikpKSkKKworOzs7IyMj YXV0b2xvYWQKKyhkZWZ1biBmaW5kLWRpcmVkLXVuZXNjYXBlZCAoZGlyIGFyZ3MpCisgICJSdW4g YGZpbmQnIGFuZCBnbyBpbnRvIERpcmVkIG1vZGUgb24gYSBidWZmZXIgb2YgdGhlIG91dHB1dC4K K1RoZSBjb21tYW5kIHJ1biAoYWZ0ZXIgY2hhbmdpbmcgaW50byBESVIpIGlzIGVzc2VudGlhbGx5 CisKKyAgICBmaW5kIC4gQVJHUyAtbHMKKworZXhjZXB0IHRoYXQgdGhlIGNhciBvZiB0aGUgdmFy aWFibGUgYGZpbmQtbHMtb3B0aW9uJyBzcGVjaWZpZXMgd2hhdCB0bwordXNlIGluIHBsYWNlIG9m IFwiLWxzXCIgYXMgdGhlIGZpbmFsIGFyZ3VtZW50LgorCitUaGlzIGZ1bmN0aW9uIGNhbiBiZSB1 c2VkIHRvIGJ1aWxkIG1vcmUgc3BlY2lhbGl6ZWQgY29tbWFuZHMgdXNpbmcgYGZpbmQtZGlyZWQn LiIKICAgKGxldCAoKGRpcmVkLWJ1ZmZlcnMgZGlyZWQtYnVmZmVycykpCiAgICAgOzsgRXhwYW5k IERJUiAoIiIgbWVhbnMgZGVmYXVsdC1kaXJlY3RvcnkpLCBhbmQgbWFrZSBzdXJlIGl0IGhhcyBh CiAgICAgOzsgdHJhaWxpbmcgc2xhc2guCkBAIC0yMDAsMTUgKzIxOSw4IEBAIGZpbmQtZGlyZWQK ICAgICAoc2V0cSBidWZmZXItcmVhZC1vbmx5IG5pbCkKICAgICAoZXJhc2UtYnVmZmVyKQogICAg IChzZXRxIGRlZmF1bHQtZGlyZWN0b3J5IGRpcgotCSAgZmluZC1hcmdzIGFyZ3MJICAgICAgOyBz YXZlIGZvciBuZXh0IGludGVyYWN0aXZlIGNhbGwKIAkgIGFyZ3MgKGNvbmNhdCBmaW5kLXByb2dy YW0gIiAuICIKLQkJICAgICAgIChpZiAoc3RyaW5nPSBhcmdzICIiKQotCQkJICAgIiIKLQkJCSAo Y29uY2F0Ci0JCQkgIChzaGVsbC1xdW90ZS1hcmd1bWVudCAiKCIpCi0JCQkgICIgIiBhcmdzICIg IgotCQkJICAoc2hlbGwtcXVvdGUtYXJndW1lbnQgIikiKQotCQkJICAiICIpKQorCQkgICAgICAg YXJncwogCQkgICAgICAgKGlmIChzdHJpbmctbWF0Y2ggIlxcYFxcKC4qXFwpIHt9IFxcKFxcXFw7 XFx8XFwrXFwpXFwnIgogCQkJCQkgKGNhciBmaW5kLWxzLW9wdGlvbikpCiAJCQkgICAoZm9ybWF0 ICIlcyAlcyAlcyIKQEAgLTM5Myw3ICs0MDUsNyBAQCBmaW5kLWRpcmVkLXNlbnRpbmVsCiAJICAg ICAgOzsgd2lsbCBzdGF5IGFyb3VuZCB1bnRpbCBNLXggYGxpc3QtcHJvY2Vzc2VzJy4KIAkgICAg ICAoZGVsZXRlLXByb2Nlc3MgcHJvYykKIAkgICAgICAoZm9yY2UtbW9kZS1saW5lLXVwZGF0ZSkp KSkKLQkgIChtZXNzYWdlICJmaW5kLWRpcmVkICVzIGZpbmlzaGVkLiIgYnVmKSkpKQorICAgICAg KG1lc3NhZ2UgImZpbmQtZGlyZWQgJXMgZmluaXNoZWQuIiBidWYpKSkpCiAKIChkZWZ1biBmaW5k LWRpcmVkLXNvcnQtYnktZmlsZW5hbWUgKCkKICAgIlNvcnQgZW50cmllcyBpbiAqRmluZCogYnVm ZmVyIGJ5IGZpbGUgbmFtZSBsZXhpY29ncmFwaGljYWxseS4iCi0tIAoyLjMwLjEKCg== --000000000000a265b205bc97a9c3--