From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#36243: 26.2; defining inverse abbrevs include space Date: Mon, 17 Jun 2019 12:23:02 -0700 Message-ID: References: <85y320l19n.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000006aa0e5058b89edd9" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="111716"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36243@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 17 21:26:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcxGd-000Swa-Rk for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 21:26:12 +0200 Original-Received: from localhost ([::1]:51480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcxGc-0004Q7-TU for geb-bug-gnu-emacs@m.gmane.org; Mon, 17 Jun 2019 15:26:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50149) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcxGW-0004Ms-AI for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 15:26:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcxGV-0006g1-5E for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 15:26:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcxGU-0006fP-Ki for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 15:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcxGU-0002My-Et for bug-gnu-emacs@gnu.org; Mon, 17 Jun 2019 15:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jun 2019 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36243 X-GNU-PR-Package: emacs Original-Received: via spool by 36243-submit@debbugs.gnu.org id=B36243.15607995119045 (code B ref 36243); Mon, 17 Jun 2019 19:26:02 +0000 Original-Received: (at 36243) by debbugs.gnu.org; 17 Jun 2019 19:25:11 +0000 Original-Received: from localhost ([127.0.0.1]:43351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcxFf-0002Lo-Bb for submit@debbugs.gnu.org; Mon, 17 Jun 2019 15:25:11 -0400 Original-Received: from mail-io1-f46.google.com ([209.85.166.46]:38458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcxFa-0002LA-3o for 36243@debbugs.gnu.org; Mon, 17 Jun 2019 15:25:06 -0400 Original-Received: by mail-io1-f46.google.com with SMTP id d12so15875563iod.5 for <36243@debbugs.gnu.org>; Mon, 17 Jun 2019 12:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ThQEF92fl95eyVNl6aR3NWxFXg7IfWM8FyuN8iI+pp0=; b=M1smUEBm0UObUN4xh5opRikRKu5DvB/HGCGJcu7oFQEHS2KeVKH2UgVqqW47ftFOpM 1ODJhrdHP50yJfL7awd/uWLVIgAaEzjAs4GjcsCf/w1f7AzZz7sYYZB53Xma5LzAlhS+ mgf9MColZE8CobxDlVuLJznr2hl5glElPpp0yTA4JGVhL2Fz0v/jHgj4iCPhF+RSzUuQ 2ce3VPWIai8OuQRHvbgIUCW/jbBsAvy3hTIb6OSdDLqL70OxM9w2UsI/kG0lE0M3/qrj Ofqj/6Rku82iBjY296PgNr7LLdbICUHN7j08XK+FpidmM7XeDQfxJE/2hW4gSa0r8tV/ iBnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ThQEF92fl95eyVNl6aR3NWxFXg7IfWM8FyuN8iI+pp0=; b=SdeS0lSMiLEUPAO2Zx+kJyvu68kGpQhjV7gKnmFvYOv4IEAj2x21IgbxqVVadE4g9x oRbS5QJ3mWD7ceUlaAAloID24xviePBcHoNo8WKgO0OOxSZdMRDt/XwGGKQ5fqClsBkC eiO0yktV7MmhbaIUced3L3r3RpvAqaGKuQ95BFv0nEJt8KBk67GoG3LLNEHRyjnxLZ82 VXxuqWTrCJju2m/khpSG+LMMD4gXWAfKH7k2Pf0e3Vz46jSLqv+3c42lQ5iBetrTnoV5 34HD1vr5X16/YzlMhLOToN64QSW3BFFzZlHIzypFVTwwyVzArVPqj77W6CM7oAX3YzOY p4KQ== X-Gm-Message-State: APjAAAWxnC2zwwyra/7c7EB2MQayPdRQmmqIixzXoFXK2v7llqa8hdrU In5FXC/Y1Ehyn73/+wT6Jej6lZSvmZWHYofXUxW004yqKlM= X-Google-Smtp-Source: APXvYqx/qQtorAdCqDazqWqDB6BGVgeNCezDXz4pkhefVqD4KXyYldPqMVMXbxQdteIIIGxHmrQt7YK2uy5hImGyv0E= X-Received: by 2002:a02:394c:: with SMTP id w12mr624106jae.126.1560799393499; Mon, 17 Jun 2019 12:23:13 -0700 (PDT) In-Reply-To: <85y320l19n.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160745 Archived-At: --0000000000006aa0e5058b89edd9 Content-Type: text/plain; charset="UTF-8" Thanks for suggesting skip-syntax-backward, see new patch. On Mon, Jun 17, 2019 at 7:44 AM Noam Postavsky wrote: > > Allen Li writes: > > > Defining an inverse abbrev in a buffer like so (@ is point): > > > > some text foo @ > > > > C-x a i l find outer otter RET > > > > defines an abbrev "foo " -> "find outer otter" > > > * lisp/abbrev.el (inverse-add-abbrev): Skip trailing nonword > > characters when defining abbrev. > > > (defun inverse-add-abbrev (table type arg) > > (let (name exp start end) > > (save-excursion > > - (forward-word (1+ (- arg))) > > + (if (<= arg 0) > > + (forward-word (1+ (- arg))) > > + (forward-word (- arg)) > > + (forward-word)) > > (setq end (point)) > > (backward-word 1) > > This seems like a somewhat obfuscated way of skipping nonword > characters. How about using skip-syntax-backward instead? --0000000000006aa0e5058b89edd9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-defining-inverse-abbrevs-on-previous-words.patch" Content-Disposition: attachment; filename="0001-Fix-defining-inverse-abbrevs-on-previous-words.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jx0rmi1a0 RnJvbSA5MWQ0YzkzMjhkNmExN2I3N2E4ZDNhODY0OTViMWUxN2ZlMzYzZDFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBTdW4sIDE2IEp1biAyMDE5IDAzOjMyOjAyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IGRlZmluaW5nIGludmVyc2UgYWJicmV2cyBvbiBwcmV2aW91cyB3b3JkcwoKKiBsaXNwL2FiYnJl di5lbCAoaW52ZXJzZS1hZGQtYWJicmV2KTogU2tpcCB0cmFpbGluZyBub253b3JkCmNoYXJhY3Rl cnMgd2hlbiBkZWZpbmluZyBhYmJyZXYuCgoqIHRlc3QvbGlzcC9hYmJyZXYtdGVzdHMuZWwgKGFi YnJldi1lZGl0LXNhdmUtdG8tZmlsZS10ZXN0KTogQWRkCnJlZ3Jlc3Npb24gdGVzdHMuCi0tLQog bGlzcC9hYmJyZXYuZWwgICAgICAgICAgICB8ICAxICsKIHRlc3QvbGlzcC9hYmJyZXYtdGVzdHMu ZWwgfCAyOCArKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI5 IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2FiYnJldi5lbCBiL2xpc3AvYWJicmV2 LmVsCmluZGV4IGFlYmY2NWUwZjcuLmMwODU0Yjk5ZmUgMTAwNjQ0Ci0tLSBhL2xpc3AvYWJicmV2 LmVsCisrKyBiL2xpc3AvYWJicmV2LmVsCkBAIC0zNTQsNiArMzU0LDcgQEAgaW52ZXJzZS1hZGQt YWJicmV2CiAgIChsZXQgKG5hbWUgZXhwIHN0YXJ0IGVuZCkKICAgICAoc2F2ZS1leGN1cnNpb24K ICAgICAgIChmb3J3YXJkLXdvcmQgKDErICgtIGFyZykpKQorICAgICAgKHNraXAtc3ludGF4LWJh Y2t3YXJkICJedyIpCiAgICAgICAoc2V0cSBlbmQgKHBvaW50KSkKICAgICAgIChiYWNrd2FyZC13 b3JkIDEpCiAgICAgICAoc2V0cSBzdGFydCAocG9pbnQpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3Av YWJicmV2LXRlc3RzLmVsIGIvdGVzdC9saXNwL2FiYnJldi10ZXN0cy5lbAppbmRleCA4MDBjOWFh YzMzLi4zM2E1ZWM3ZGFiIDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvYWJicmV2LXRlc3RzLmVsCisr KyBiL3Rlc3QvbGlzcC9hYmJyZXYtdGVzdHMuZWwKQEAgLTI0OSw2ICsyNDksMzQgQEAgc2V0dXAt dGVzdC1hYmJyZXYtdGFibGUKICAgICAgICAgICAgICAgICAgICAgIChhYmJyZXYtZXhwYW5zaW9u ICJzLWEtdCIgZXJ0LXNhdmUtdGVzdC10YWJsZSkpKQogICAgICAgKGRlbGV0ZS1maWxlIHRlbXAt dGVzdC1maWxlKSkpKQogCisoZXJ0LWRlZnRlc3QgaW52ZXJzZS1hZGQtYWJicmV2LXNraXBzLXRy YWlsaW5nLW5vbndvcmQgKCkKKyAgIlRlc3QgdGhhdCBhZGRpbmcgYW4gaW52ZXJzZSBhYmJyZXYg c2tpcHMgdHJhaWxpbmcgbm9ud29yZCBjaGFyYWN0ZXJzLiIKKyAgKGxldCAoKHRhYmxlIChtYWtl LWFiYnJldi10YWJsZSkpKQorICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAoaW5zZXJ0ICJz b21lIHRleHQgZm9vICIpCisgICAgICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ3JlYWQt c3RyaW5nKSAobGFtYmRhICgmcmVzdCBfKSAiYmFyIikpKQorICAgICAgICAoaW52ZXJzZS1hZGQt YWJicmV2IHRhYmxlICJHbG9iYWwiIDEpKSkKKyAgICAoc2hvdWxkIChzdHJpbmc9IChhYmJyZXYt ZXhwYW5zaW9uICJmb28iIHRhYmxlKSAiYmFyIikpKSkKKworKGVydC1kZWZ0ZXN0IGludmVyc2Ut YWRkLWFiYnJldi1za2lwcy10cmFpbGluZy1ub253b3JkL3Bvc3RpaXZlLWFyZyAoKQorICAiVGVz dCB0aGF0IGFkZGluZyBhbiBpbnZlcnNlIGFiYnJldiBza2lwcyB0cmFpbGluZyBub253b3JkIGNo YXJhY3RlcnMuIgorICAobGV0ICgodGFibGUgKG1ha2UtYWJicmV2LXRhYmxlKSkpCisgICAgKHdp dGgtdGVtcC1idWZmZXIKKyAgICAgIChpbnNlcnQgInNvbWUgdGV4dCBmb28gIikKKyAgICAgIChj bC1sZXRmICgoKHN5bWJvbC1mdW5jdGlvbiAncmVhZC1zdHJpbmcpIChsYW1iZGEgKCZyZXN0IF8p ICJiYXIiKSkpCisgICAgICAgIChpbnZlcnNlLWFkZC1hYmJyZXYgdGFibGUgIkdsb2JhbCIgMikp KQorICAgIChzaG91bGQgKHN0cmluZz0gKGFiYnJldi1leHBhbnNpb24gInRleHQiIHRhYmxlKSAi YmFyIikpKSkKKworKGVydC1kZWZ0ZXN0IGludmVyc2UtYWRkLWFiYnJldi1za2lwcy10cmFpbGlu Zy1ub253b3JkL25lZ2F0aXZlLWFyZyAoKQorICAiVGVzdCB0aGF0IGFkZGluZyBhbiBpbnZlcnNl IGFiYnJldiBza2lwcyB0cmFpbGluZyBub253b3JkIGNoYXJhY3RlcnMuIgorICAobGV0ICgodGFi bGUgKG1ha2UtYWJicmV2LXRhYmxlKSkpCisgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgIChp bnNlcnQgInNvbWUgICAgIHRleHQgZm9vIikKKyAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikp CisgICAgICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ3JlYWQtc3RyaW5nKSAobGFtYmRh ICgmcmVzdCBfKSAiYmFyIikpKQorICAgICAgICAoaW52ZXJzZS1hZGQtYWJicmV2IHRhYmxlICJH bG9iYWwiIC0xKSkpCisgICAgKHNob3VsZCAoc3RyaW5nPSAoYWJicmV2LWV4cGFuc2lvbiAidGV4 dCIgdGFibGUpICJiYXIiKSkpKQorCiAocHJvdmlkZSAnYWJicmV2LXRlc3RzKQogCiA7OzsgYWJi cmV2LXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4yMi4wLjQxMC5nZDhmZGJlMjFiNS1nb29nCgo= --0000000000006aa0e5058b89edd9--