From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Allen Li Newsgroups: gmane.emacs.bugs Subject: bug#29923: [PATCH] Skip writing empty abbrev tables Date: Tue, 18 Sep 2018 19:55:38 -0700 Message-ID: References: <87tvmyflla.fsf@gmail.com> <874lemquwr.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000003b5cae0576308b3d" X-Trace: blaine.gmane.org 1537325659 7656 195.159.176.226 (19 Sep 2018 02:54:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Sep 2018 02:54:19 +0000 (UTC) Cc: Allen Li , 29923@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 19 04:54:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Scy-0001o0-IZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 04:54:08 +0200 Original-Received: from localhost ([::1]:43387 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Sf5-0004GS-1t for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Sep 2018 22:56:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2Seu-0004Eu-Pa for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 22:56:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2Seq-0002Id-FL for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 22:56:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40688) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2Seq-0002IH-8u for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 22:56:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g2Seq-00072I-54 for bug-gnu-emacs@gnu.org; Tue, 18 Sep 2018 22:56:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Allen Li Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Sep 2018 02:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29923-submit@debbugs.gnu.org id=B29923.153732576027036 (code B ref 29923); Wed, 19 Sep 2018 02:56:02 +0000 Original-Received: (at 29923) by debbugs.gnu.org; 19 Sep 2018 02:56:00 +0000 Original-Received: from localhost ([127.0.0.1]:44946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Sej-00071y-S5 for submit@debbugs.gnu.org; Tue, 18 Sep 2018 22:55:58 -0400 Original-Received: from mail-io1-f67.google.com ([209.85.166.67]:45606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2Seh-00071i-QP for 29923@debbugs.gnu.org; Tue, 18 Sep 2018 22:55:56 -0400 Original-Received: by mail-io1-f67.google.com with SMTP id e12-v6so3258992iok.12 for <29923@debbugs.gnu.org>; Tue, 18 Sep 2018 19:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NMgwHjR9g9g5Wxc6v/RoYXhqwhzKR0GBLKL2YsJDECc=; b=CMkafM5rTzeyeQR9DtTdpXGw6yUHrK2NWIrmzGibTU84ao5kjdb4aEKLRNd8N0VkWD nqdRmq2j0inV6GrqkgGIuKzsHzfvMjDTJ/y0Jiwmc0s2cUC0noIA4KbYSu7MCheqbFer 1YXvKQBvYAOduYLnQmMpKcZ5oTVwEAr5gZNYe/8qhEs6tV3G2JI5OYmQl7+ImkPi3EnN 1wQW8RMCcXMT/ytN+/uYPvKw+ZM3zfkZdXzuOHirtvmiMBzQjO3N4jCCi1t17j4qdUVN h40R0rbMXBr8W0ay0DkHzbVqGYkPnml/Ig/LT5PxdOO2AhLqtPVplNM+DiWkJdcHJ0AM 9aZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NMgwHjR9g9g5Wxc6v/RoYXhqwhzKR0GBLKL2YsJDECc=; b=rFGAhF4eMj0PgaUsXOqEb3jW0c+NPpRocqVypnojedBss+eXgjoFoVWC1Aue9F4kbF 78Ewg8nIlxPswxExxt97SnY9MEqOmGMiVkByAwloN7tAruFTxcv4QVU4q5iLh0CO3cyl 29y3gJyqOg5j/gNWAuWdqZ0rU4/JskQklu3iJkYPJ81u3JArlFa8RyXwX5CfUPFlU1LQ M3z60E0E+E1HNnSU3i5PmgJPrWyLuUPaVm5jJvF65N+qAAtC1c8NEbORUwmQm1TbulVW 7C/AU/YtOimBgcrLryCsXyWHIEBPUZPqPBgBC5VoqGlqBa9Kdknt0vYyzURVEe8JwgqF VaAg== X-Gm-Message-State: APzg51BoV2k6ecg28kV7KcUdXrTikMEWq5+dREDyVi+SZev1QzhWK0uH RmxbFDR56jiq+ptMJv0Fh3YO20fJ0uhR/xkMg5BzHw== X-Google-Smtp-Source: ANB0VdbmCJ9RTcivf5E9vrLEqE65cqgqTyYkUsmM8K4ajAJmYPqeYq4LnHSjDvt8qnGFdYi8bHxd3gGdG07LTr8ySYY= X-Received: by 2002:a5e:8d18:: with SMTP id m24-v6mr27689775ioj.217.1537325749956; Tue, 18 Sep 2018 19:55:49 -0700 (PDT) In-Reply-To: <874lemquwr.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150427 Archived-At: --0000000000003b5cae0576308b3d Content-Type: text/plain; charset="UTF-8" On Tue, Sep 18, 2018 at 3:53 PM Noam Postavsky wrote: > > Allen Li writes: > > > The system abbrev omitting worked (if readable is nil); it's > > implemented in abbrev--write. > > However, that doesn't allow us to skip writing a table if it only > > contains system abbrevs; > > we'll still see a table with abbrevs, write the opening of the > > define-abbrev-table form, > > and then realize in abbrev-write that all of the abbrevs are system abbrevs. > > Ah, it would be good to have this information in the commit message, as > the patch is a bit confusing to read otherwise. Done. I have also removed the system abbrev check in abbrev--write since it is redundant now and this is the only place it is called. --0000000000003b5cae0576308b3d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Skip-writing-empty-abbrev-tables.patch" Content-Disposition: attachment; filename="0001-Skip-writing-empty-abbrev-tables.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jm8k0jwg0 RnJvbSAyOWI2NGZmZTY4ODkwZWNlMDg5ZDVlMTA1MGM1NWViN2MyNTQ3ZDM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGxlbiBMaSA8ZGFya2ZlbGluZUBmZWxlc2F0cmEubW9lPgpE YXRlOiBTdW4sIDMxIERlYyAyMDE3IDIwOjMzOjIxIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gU2tp cCB3cml0aW5nIGVtcHR5IGFiYnJldiB0YWJsZXMKCkZpeGVzIGJ1ZyMyOTkyMwoKaW5zZXJ0LWFi YnJldi10YWJsZS1kZXNjcmlwdGlvbiB3aXRoIGEgbm9uLW5pbCBSRUFEQUJMRSBpbnNlcnRzIExp c3AKZm9ybXMgc3VpdGFibGUgZm9yIGV2YWx1YXRpb24gdG8gcmVzdG9yZSB0aGUgZGVmaW5lZCBh YmJyZXZzLiAgV2UKZG9uJ3QgaGF2ZSB0byBpbnNlcnQgYSBmb3JtIGZvciB0YWJsZXMgdGhhdCBk byBub3QgaGF2ZSBhbnkgYWJicmV2cy4KClRvIGltcGxlbWVudCB0aGlzLCB3ZSBuZWVkIHRvIGZp bHRlciBvdXQgb3V0IHN5c3RlbSBhYmJyZXZzIGJlZm9yZQpjaGVja2luZyBpZiBhIHRhYmxlIGlz IGVtcHR5LCBiZWNhdXNlIHN5c3RlbSBhYmJyZXZzIHdlcmUgcHJldmlvdXNseQpza2lwcGVkIGlu IHRoZSBhYmJyZXYtLXdyaXRlIGNhbGwsIGF0IHdoaWNoIHBvaW50IHdlIHdvdWxkIGFscmVhZHkK aGF2ZSBzdGFydGVkIGluc2VydGluZyB0aGUgYmVnaW5uaW5nIG9mIGEgdGFibGUgZGVmaW5pdGlv biBmb3JtLgoKKiBsaXNwL2FiYnJldi5lbCAoaW5zZXJ0LWFiYnJldi10YWJsZS1kZXNjcmlwdGlv bik6ClNraXAgaW5zZXJ0aW5nIGVtcHR5IHRhYmxlcyB3aGVuIFJFQURBQkxFIGlzIG5vbi1uaWwu CkNsYXJpZnkgYmVoYXZpb3IgaW4gZG9jdW1lbnRhdGlvbiBzdHJpbmcuCiogbGlzcC9hYmJyZXYu ZWwgKGFiYnJldi0td3JpdGUpOiBSZW1vdmUgc3lzdGVtIGFiYnJldiBjaGVjay4KLS0tCiBsaXNw L2FiYnJldi5lbCB8IDc1ICsrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMzYgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9hYmJyZXYuZWwgYi9saXNwL2FiYnJldi5lbAppbmRleCBj ZGRjZThmNTI5Li5mZDQ0Y2NlNGFlIDEwMDY0NAotLS0gYS9saXNwL2FiYnJldi5lbAorKysgYi9s aXNwL2FiYnJldi5lbApAQCAtODk2LDI0ICs4OTYsMjIgQEAgdW5leHBhbmQtYWJicmV2CiAKIChk ZWZ1biBhYmJyZXYtLXdyaXRlIChzeW0pCiAgICJXcml0ZSB0aGUgYWJicmV2IGluIGEgYHJlYWQn YWJsZSBmb3JtLgotT25seSB3cml0ZXMgdGhlIG5vbi1zeXN0ZW0gYWJicmV2cy4KIFByZXN1bWVz IHRoYXQgYHN0YW5kYXJkLW91dHB1dCcgcG9pbnRzIHRvIGBjdXJyZW50LWJ1ZmZlcicuIgotICAo dW5sZXNzIChvciAobnVsbCAoc3ltYm9sLXZhbHVlIHN5bSkpIChhYmJyZXYtZ2V0IHN5bSA6c3lz dGVtKSkKLSAgICAoaW5zZXJ0ICIgICAgKCIpCi0gICAgKHByaW4xIChzeW1ib2wtbmFtZSBzeW0p KQotICAgIChpbnNlcnQgIiAiKQotICAgIChwcmluMSAoc3ltYm9sLXZhbHVlIHN5bSkpCi0gICAg KGluc2VydCAiICIpCi0gICAgKHByaW4xIChzeW1ib2wtZnVuY3Rpb24gc3ltKSkKLSAgICAoaW5z ZXJ0ICIgOmNvdW50ICIpCi0gICAgKHByaW4xIChhYmJyZXYtZ2V0IHN5bSA6Y291bnQpKQotICAg ICh3aGVuIChhYmJyZXYtZ2V0IHN5bSA6Y2FzZS1maXhlZCkKLSAgICAgIChpbnNlcnQgIiA6Y2Fz ZS1maXhlZCAiKQotICAgICAgKHByaW4xIChhYmJyZXYtZ2V0IHN5bSA6Y2FzZS1maXhlZCkpKQot ICAgICh3aGVuIChhYmJyZXYtZ2V0IHN5bSA6ZW5hYmxlLWZ1bmN0aW9uKQotICAgICAgKGluc2Vy dCAiIDplbmFibGUtZnVuY3Rpb24gIikKLSAgICAgIChwcmluMSAoYWJicmV2LWdldCBzeW0gOmVu YWJsZS1mdW5jdGlvbikpKQotICAgIChpbnNlcnQgIilcbiIpKSkKKyAgKGluc2VydCAiICAgICgi KQorICAocHJpbjEgKHN5bWJvbC1uYW1lIHN5bSkpCisgIChpbnNlcnQgIiAiKQorICAocHJpbjEg KHN5bWJvbC12YWx1ZSBzeW0pKQorICAoaW5zZXJ0ICIgIikKKyAgKHByaW4xIChzeW1ib2wtZnVu Y3Rpb24gc3ltKSkKKyAgKGluc2VydCAiIDpjb3VudCAiKQorICAocHJpbjEgKGFiYnJldi1nZXQg c3ltIDpjb3VudCkpCisgICh3aGVuIChhYmJyZXYtZ2V0IHN5bSA6Y2FzZS1maXhlZCkKKyAgICAo aW5zZXJ0ICIgOmNhc2UtZml4ZWQgIikKKyAgICAocHJpbjEgKGFiYnJldi1nZXQgc3ltIDpjYXNl LWZpeGVkKSkpCisgICh3aGVuIChhYmJyZXYtZ2V0IHN5bSA6ZW5hYmxlLWZ1bmN0aW9uKQorICAg IChpbnNlcnQgIiA6ZW5hYmxlLWZ1bmN0aW9uICIpCisgICAgKHByaW4xIChhYmJyZXYtZ2V0IHN5 bSA6ZW5hYmxlLWZ1bmN0aW9uKSkpCisgIChpbnNlcnQgIilcbiIpKQogCiAoZGVmdW4gYWJicmV2 LS1kZXNjcmliZSAoc3ltKQogICAod2hlbiAoc3ltYm9sLXZhbHVlIHN5bSkKQEAgLTkzOCwyNyAr OTM2LDMyIEBAIGluc2VydC1hYmJyZXYtdGFibGUtZGVzY3JpcHRpb24KIGEgY2FsbCB0byBgZGVm aW5lLWFiYnJldi10YWJsZScsIHdoaWNoIHdvdWxkCiBkZWZpbmUgdGhlIGFiYnJldiB0YWJsZSBO QU1FIGV4YWN0bHkgYXMgaXQgaXMgY3VycmVudGx5IGRlZmluZWQuCiAKLUFiYnJldnMgbWFya2Vk IGFzIFwic3lzdGVtIGFiYnJldnNcIiBhcmUgb21pdHRlZC4iCitJZiBSRUFEQUJMRSBpcyBuaWws IGFiYnJldnMgbWFya2VkIGFzIFwic3lzdGVtIGFiYnJldnNcIiBhbmQKK2VtcHR5IGFiYnJldiB0 YWJsZXMgYXJlIG9taXR0ZWQuIgogICAobGV0ICgodGFibGUgKHN5bWJvbC12YWx1ZSBuYW1lKSkK ICAgICAgICAgKHN5bWJvbHMgKCkpKQotICAgIChtYXBhdG9tcyAobGFtYmRhIChzeW0pIChpZiAo c3ltYm9sLXZhbHVlIHN5bSkgKHB1c2ggc3ltIHN5bWJvbHMpKSkgdGFibGUpCi0gICAgKHNldHEg c3ltYm9scyAoc29ydCBzeW1ib2xzICdzdHJpbmctbGVzc3ApKQotICAgIChsZXQgKChzdGFuZGFy ZC1vdXRwdXQgKGN1cnJlbnQtYnVmZmVyKSkpCi0gICAgICAoaWYgcmVhZGFibGUKLQkgIChwcm9n bgotCSAgICAoaW5zZXJ0ICIoIikKLQkgICAgKHByaW4xIG5hbWUpCi0JICAgIChpbnNlcnQgIilc blxuIikKLQkgICAgKG1hcGMgJ2FiYnJldi0tZGVzY3JpYmUgc3ltYm9scykKLQkgICAgKGluc2Vy dCAiXG5cbiIpKQotCShpbnNlcnQgIihkZWZpbmUtYWJicmV2LXRhYmxlICciKQotCShwcmluMSBu YW1lKQotCShpZiAobnVsbCBzeW1ib2xzKQotCSAgICAoaW5zZXJ0ICIgJygpKVxuXG4iKQotCSAg KGluc2VydCAiXG4gICcoXG4iKQotCSAgKG1hcGMgJ2FiYnJldi0td3JpdGUgc3ltYm9scykKLQkg IChpbnNlcnQgIiAgICkpXG5cbiIpKSkKLSAgICAgIG5pbCkpKQorICAgIChtYXBhdG9tcyAobGFt YmRhIChzeW0pCisgICAgICAgICAgICAgICAgKGlmIChhbmQgKHN5bWJvbC12YWx1ZSBzeW0pIChv ciByZWFkYWJsZSAobm90IChhYmJyZXYtZ2V0IHN5bSA6c3lzdGVtKSkpKQorICAgICAgICAgICAg ICAgICAgICAocHVzaCBzeW0gc3ltYm9scykpKQorICAgICAgICAgICAgICB0YWJsZSkKKyAgICAo d2hlbiBzeW1ib2xzCisgICAgICAoc2V0cSBzeW1ib2xzIChzb3J0IHN5bWJvbHMgJ3N0cmluZy1s ZXNzcCkpCisgICAgICAobGV0ICgoc3RhbmRhcmQtb3V0cHV0IChjdXJyZW50LWJ1ZmZlcikpKQor ICAgICAgICAoaWYgcmVhZGFibGUKKyAgICAgICAgICAgIChwcm9nbgorICAgICAgICAgICAgICAo aW5zZXJ0ICIoIikKKyAgICAgICAgICAgICAgKHByaW4xIG5hbWUpCisgICAgICAgICAgICAgIChp bnNlcnQgIilcblxuIikKKyAgICAgICAgICAgICAgKG1hcGMgJ2FiYnJldi0tZGVzY3JpYmUgc3lt Ym9scykKKyAgICAgICAgICAgICAgKGluc2VydCAiXG5cbiIpKQorICAgICAgICAgIChpbnNlcnQg IihkZWZpbmUtYWJicmV2LXRhYmxlICciKQorICAgICAgICAgIChwcmluMSBuYW1lKQorICAgICAg ICAgIChpZiAobnVsbCBzeW1ib2xzKQorICAgICAgICAgICAgICAoaW5zZXJ0ICIgJygpKVxuXG4i KQorICAgICAgICAgICAgKGluc2VydCAiXG4gICcoXG4iKQorICAgICAgICAgICAgKG1hcGMgJ2Fi YnJldi0td3JpdGUgc3ltYm9scykKKyAgICAgICAgICAgIChpbnNlcnQgIiAgICkpXG5cbiIpKSkK KyAgICAgICAgbmlsKSkpKQogCiAoZGVmdW4gZGVmaW5lLWFiYnJldi10YWJsZSAodGFibGVuYW1l IGRlZmluaXRpb25zCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZvcHRp b25hbCBkb2NzdHJpbmcgJnJlc3QgcHJvcHMpCi0tIAoyLjE5LjAKCg== --0000000000003b5cae0576308b3d--