From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Ralston Newsgroups: gmane.emacs.bugs Subject: bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable Date: Thu, 13 Dec 2012 07:05:08 -0800 Message-ID: References: <50AFB18A.8020806@dogan.se> <50BE7E86.9020601@dogan.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=e89a8ff1cae0aa72ad04d0bd3d73 X-Trace: ger.gmane.org 1355411188 15066 80.91.229.3 (13 Dec 2012 15:06:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 13 Dec 2012 15:06:28 +0000 (UTC) Cc: deniz@dogan.se To: 12857@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 13 16:06:42 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TjAN0-0005QS-Er for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Dec 2012 16:06:42 +0100 Original-Received: from localhost ([::1]:42492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjAMn-0005FJ-74 for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Dec 2012 10:06:29 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjAMd-0005E7-UO for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 10:06:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TjAMT-0004KC-Tt for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 10:06:19 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TjAMT-0004K7-PT for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 10:06:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TjANK-0001oz-21 for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2012 10:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Ralston Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Dec 2012 15:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12857-submit@debbugs.gnu.org id=B12857.13554111726907 (code B ref 12857); Thu, 13 Dec 2012 15:07:01 +0000 Original-Received: (at 12857) by debbugs.gnu.org; 13 Dec 2012 15:06:12 +0000 Original-Received: from localhost ([127.0.0.1]:41076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjAMW-0001nJ-6N for submit@debbugs.gnu.org; Thu, 13 Dec 2012 10:06:12 -0500 Original-Received: from mail-pa0-f44.google.com ([209.85.220.44]:36264) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TjAMS-0001n9-Q9 for 12857@debbugs.gnu.org; Thu, 13 Dec 2012 10:06:10 -0500 Original-Received: by mail-pa0-f44.google.com with SMTP id hz11so1600827pad.3 for <12857@debbugs.gnu.org>; Thu, 13 Dec 2012 07:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ljPunHLDj6sVfUQxBnKIS/3SEZLZ8OQojIvMgoYa6pk=; b=ctdZX3/iY6hAVvjd1IFT+Vg4RKsLUahVtKOonnujQEMWY9iMzk9gVNwfVPLg/dAICo TgNqZZ7LMeudP/LQ9GZQmSVRytvK32p391F+yRr/uyetgrUAc+hmsprWcUExJGz+Z30V BYA0VWDSA5M9UrAM9VpZxoPjr7d3L//c3tXfIWbdMaTKzYLWA0lFfE+ubZUj6aAMW9U+ SvHPtrxZOq77EvQD0HFrOhos3seTwoehGPBgA/3p/pSHvTyFPk49OpRPgJNjzodDUOkr 0qeuCiMu1xpvb7baxELAk3NNLa3GHtX4HjjMU0M3VqUC3cYaiEaEbcP+qfQ3yEl7EMTT /A2g== Original-Received: by 10.68.189.65 with SMTP id gg1mr6318347pbc.57.1355411108819; Thu, 13 Dec 2012 07:05:08 -0800 (PST) Original-Received: by 10.68.5.199 with HTTP; Thu, 13 Dec 2012 07:05:08 -0800 (PST) In-Reply-To: <50BE7E86.9020601@dogan.se> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68456 Archived-At: --e89a8ff1cae0aa72ad04d0bd3d73 Content-Type: multipart/alternative; boundary=e89a8ff1cae0aa72aa04d0bd3d71 --e89a8ff1cae0aa72aa04d0bd3d71 Content-Type: text/plain; charset=ISO-8859-1 Hi Deniz, Sorry for my glacially tardy response. That's a much cleaner way of doing it. I hadn't really looked into composite types before, so thanks for the suggestion! I have attached the new patch file to this message. Let me know what you think, and if you'd like me to tweak it any further. I'll try to respond more promptly next time. Daniel Changelog entry: 2012-11-10 Daniel Ralston * rcirc.el: Make the default PART and QUIT reasons used by rcirc-cmd-part and rcirc-cmd-quit customizable. (rcirc-default-part-reason,rcirc-default-quit-reason): New customizable vars. Subject: Re: rcirc.el: make default PART and QUIT reasons customizable > Date: Fri, 23 Nov 2012 18:25:30 +0100 > From: Deniz Dogan > To: 12857@debbugs.gnu.org > > Hi, Daniel > > This is a good patch! In my opinion it would be nicer if we use a > composite customization type for rcirc-default-part-reason and > rcirc-default-quit-reason, letting the user choose between the default > (rcirc-id-string) and a custom message. > > What do you think about this idea? Would you be willing to write a new > patch implementing this instead? > > Cheers, > Deniz > > > > --e89a8ff1cae0aa72aa04d0bd3d71 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi Deniz,

Sorry for my glacially tardy response.
That's a muc= h cleaner way of doing it. I hadn't really looked into composite types = before, so thanks for the suggestion! I have attached the new patch file to= this message. Let me know what you think, and if you'd like me to twea= k it any further. I'll try to respond more promptly next time.

=A0=A0=A0 Daniel

Changelog entry:

2012-11-10 =A0Daniel Ra= lston =A0<Wubbulous@gmail.com= >

=A0 =A0 * rcirc.el: Make the default PART and QUIT reasons used= by
=A0 =A0 rcirc-cmd-part and rcirc-cmd-quit customizable.
=A0 =A0 (rcirc-default-part-reason,rcirc-default-quit-reason): New
=A0 = =A0 customizable vars.


Subject: Re: rcirc.el: make default PART and QUIT reasons customizable
Date: Fri, 23 Nov 2012 18:25:30 +0100
From: Deniz Dogan <d= eniz@dogan.se>
To: 12857@debbug= s.gnu.org

Hi, Daniel

This is a good patch! In my opinion it would be nicer if we use a
composite customization type for rcirc-default-part-reason and
rcirc-default-quit-reason, letting the user choose between the default
(rcirc-id-string) and a custom message.

What do you think about this idea? =A0Would you be willing to write a new patch implementing this instead?

Cheers,
Deniz




--e89a8ff1cae0aa72aa04d0bd3d71-- --e89a8ff1cae0aa72ad04d0bd3d73 Content-Type: application/octet-stream; name="rcirc-default-part-quit-reasons.patch" Content-Disposition: attachment; filename="rcirc-default-part-quit-reasons.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hao07fdm0 PT09IG1vZGlmaWVkIGZpbGUgJ2xpc3AvbmV0L3JjaXJjLmVsJwoqKiogbGlzcC9uZXQvcmNpcmMu ZWwJMjAxMi0xMC0yMyAxNTowNjowNyArMDAwMAotLS0gbGlzcC9uZXQvcmNpcmMuZWwJMjAxMi0x Mi0xMyAxNDo0MjoyNCArMDAwMAoqKioqKioqKioqKioqKioKKioqIDQ3LDUyICoqKioKLS0tIDQ3 LDU0IC0tLS0KICAocmVxdWlyZSAndGltZS1kYXRlKQogIChldmFsLXdoZW4tY29tcGlsZSAocmVx dWlyZSAnY2wpKQogIAorIChkZWZjb25zdCByY2lyYy1pZC1zdHJpbmcgKGNvbmNhdCAicmNpcmMg b24gR05VIEVtYWNzICIgZW1hY3MtdmVyc2lvbikpCisgCiAgKGRlZmdyb3VwIHJjaXJjIG5pbAog ICAgIlNpbXBsZSBJUkMgY2xpZW50LiIKICAgIDp2ZXJzaW9uICIyMi4xIgoqKioqKioqKioqKioq KiogZm9yIGNvbm5lY3Rpb25zIHVzaW5nIFNTTC9UTFMuIgoqKiogMTM4LDE0MyAqKioqCi0tLSAx NDAsMTU5IC0tLS0KICAgIDp0eXBlICdzdHJpbmcKICAgIDpncm91cCAncmNpcmMpCiAgCisgKGRl ZmN1c3RvbSByY2lyYy1kZWZhdWx0LXBhcnQtcmVhc29uIHJjaXJjLWlkLXN0cmluZworICAgIlRo ZSBkZWZhdWx0IHJlYXNvbiB0byBzZW5kIHdoZW4gcGFydGluZyBmcm9tIGEgY2hhbm5lbCwgd2hl bgorIG5vIHJlYXNvbiBpcyBleHBsaWNpdGx5IGdpdmVuLiIKKyAgIDp0eXBlIGAoY2hvaWNlIChj b25zdCA6dGFnICJWYWx1ZSBvZiBgcmNpcmMtaWQtc3RyaW5nJyIgLHJjaXJjLWlkLXN0cmluZykK KyAgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiQ3VzdG9tIHN0cmluZyIpKQorICAgOmdy b3VwICdyY2lyYykKKyAKKyAoZGVmY3VzdG9tIHJjaXJjLWRlZmF1bHQtcXVpdC1yZWFzb24gcmNp cmMtaWQtc3RyaW5nCisgICAiVGhlIGRlZmF1bHQgcmVhc29uIHRvIHNlbmQgd2hlbiBxdWl0dGlu ZyBhIHNlcnZlciwgd2hlbiBubworIHJlYXNvbiBpcyBleHBsaWNpdGx5IGdpdmVuLiIKKyAgIDp0 eXBlIGAoY2hvaWNlIChjb25zdCA6dGFnICJWYWx1ZSBvZiBgcmNpcmMtaWQtc3RyaW5nJyIgLHJj aXJjLWlkLXN0cmluZykKKyAgICAgICAgICAgICAgICAgIChzdHJpbmcgOnRhZyAiQ3VzdG9tIHN0 cmluZyIpKQorICAgOmdyb3VwICdyY2lyYykKKyAKICAoZGVmY3VzdG9tIHJjaXJjLWZpbGwtZmxh ZyB0CiAgICAiTm9uLW5pbCBtZWFucyBsaW5lLXdyYXAgbWVzc2FnZXMgcHJpbnRlZCBpbiBjaGFu bmVsIGJ1ZmZlcnMuIgogICAgOnR5cGUgJ2Jvb2xlYW4KKioqKioqKioqKioqKioqIHdpbGwgYmUg a2lsbGVkLiIKKioqIDQxMiw0MTkgKioqKgogIChkZWZ2YXIgcmNpcmMtdGltZW91dC1zZWNvbmRz IDYwMAogICAgIktpbGwgY29ubmVjdGlvbiBhZnRlciB0aGlzIG1hbnkgc2Vjb25kcyBpZiB0aGVy ZSBpcyBubyBhY3Rpdml0eS4iKQogIAotIChkZWZjb25zdCByY2lyYy1pZC1zdHJpbmcgKGNvbmNh dCAicmNpcmMgb24gR05VIEVtYWNzICIgZW1hY3MtdmVyc2lvbikpCi0gDAogIChkZWZ2YXIgcmNp cmMtc3RhcnR1cC1jaGFubmVscyBuaWwpCiAgCiAgKGRlZnZhciByY2lyYy1zZXJ2ZXItbmFtZS1o aXN0b3J5IG5pbAotLS0gNDI4LDQzMyAtLS0tCioqKioqKioqKioqKioqKiBDSEFOTkVMUyBpcyBh IGNvbW1hLSBvciBzcGFjZS1zZXBhcmF0ZWQKKioqIDIxOTksMjIwNSAqKioqCiAgICAiUGFydCBD SEFOTkVMLiIKICAgIChpbnRlcmFjdGl2ZSAic1BhcnQgY2hhbm5lbDogIikKICAgIChsZXQgKChj aGFubmVsIChpZiAoPiAobGVuZ3RoIGNoYW5uZWwpIDApIGNoYW5uZWwgdGFyZ2V0KSkpCiEgICAg IChyY2lyYy1zZW5kLXN0cmluZyBwcm9jZXNzIChjb25jYXQgIlBBUlQgIiBjaGFubmVsICIgOiIg cmNpcmMtaWQtc3RyaW5nKSkpKQogIAogIChkZWZ1bi1yY2lyYy1jb21tYW5kIHF1aXQgKHJlYXNv bikKICAgICJTZW5kIGEgcXVpdCBtZXNzYWdlIHRvIHNlcnZlciB3aXRoIFJFQVNPTi4iCi0tLSAy MjEzLDIyMjAgLS0tLQogICAgIlBhcnQgQ0hBTk5FTC4iCiAgICAoaW50ZXJhY3RpdmUgInNQYXJ0 IGNoYW5uZWw6ICIpCiAgICAobGV0ICgoY2hhbm5lbCAoaWYgKD4gKGxlbmd0aCBjaGFubmVsKSAw KSBjaGFubmVsIHRhcmdldCkpKQohICAgICAocmNpcmMtc2VuZC1zdHJpbmcgcHJvY2VzcyAoY29u Y2F0ICJQQVJUICIgY2hhbm5lbCAiIDoiCiEgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmNpcmMtZGVmYXVsdC1wYXJ0LXJlYXNvbikpKSkKICAKICAoZGVmdW4tcmNpcmMt Y29tbWFuZCBxdWl0IChyZWFzb24pCiAgICAiU2VuZCBhIHF1aXQgbWVzc2FnZSB0byBzZXJ2ZXIg d2l0aCBSRUFTT04uIgoqKioqKioqKioqKioqKiogQ0hBTk5FTFMgaXMgYSBjb21tYS0gb3Igc3Bh Y2Utc2VwYXJhdGVkCioqKiAyMjA3LDIyMTMgKioqKgogICAgKHJjaXJjLXNlbmQtc3RyaW5nIHBy b2Nlc3MgKGNvbmNhdCAiUVVJVCA6IgogIAkJCQkgICAgIChpZiAobm90ICh6ZXJvcCAobGVuZ3Ro IHJlYXNvbikpKQogIAkJCQkJIHJlYXNvbgohIAkJCQkgICAgICAgcmNpcmMtaWQtc3RyaW5nKSkp KQogIAogIChkZWZ1bi1yY2lyYy1jb21tYW5kIG5pY2sgKG5pY2spCiAgICAiQ2hhbmdlIG5pY2sg dG8gTklDSy4iCi0tLSAyMjIyLDIyMjggLS0tLQogICAgKHJjaXJjLXNlbmQtc3RyaW5nIHByb2Nl c3MgKGNvbmNhdCAiUVVJVCA6IgogIAkJCQkgICAgIChpZiAobm90ICh6ZXJvcCAobGVuZ3RoIHJl YXNvbikpKQogIAkJCQkJIHJlYXNvbgohIAkJCQkgICAgICAgcmNpcmMtZGVmYXVsdC1xdWl0LXJl YXNvbikpKSkKICAKICAoZGVmdW4tcmNpcmMtY29tbWFuZCBuaWNrIChuaWNrKQogICAgIkNoYW5n ZSBuaWNrIHRvIE5JQ0suIgoK --e89a8ff1cae0aa72ad04d0bd3d73--