unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#38701: [PATCH] fix documentation for goto-line
@ 2019-12-21 15:00 Nikolaos Bezirgiannis
  2019-12-21 17:49 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Nikolaos Bezirgiannis @ 2019-12-21 15:00 UTC (permalink / raw)
  To: 38701


[-- Attachment #1.1: Type: text/plain, Size: 131 bytes --]

Hello,

I think there is a typo in the docstring of the `goto-line` function.
I attach a fix.

Kind regards,
Nikolaos Bezirgiannis

[-- Attachment #1.2: Type: text/html, Size: 220 bytes --]

[-- Attachment #2: 0001-fix-documentation-for-goto-line.patch --]
[-- Type: text/x-patch, Size: 813 bytes --]

From 11d3c0189fee91aa09b83bca4093dd774e92fc07 Mon Sep 17 00:00:00 2001
From: Nikolaos Bezirgiannis <bezirg@users.noreply.github.com>
Date: Sat, 21 Dec 2019 15:54:30 +0100
Subject: [PATCH] fix documentation for goto-line

---
 lisp/simple.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/simple.el b/lisp/simple.el
index 6d5030073b..3830845838 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -1229,7 +1229,7 @@ mark is already active.
 This function is usually the wrong thing to use in a Lisp program.
 What you probably want instead is something like:
   (goto-char (point-min))
-  (forward-line (1- N))
+  (forward-line (N - 1))
 If at all possible, an even better solution is to use char counts
 rather than line counts."
   (declare (interactive-only forward-line))
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#38701: [PATCH] fix documentation for goto-line
  2019-12-21 15:00 bug#38701: [PATCH] fix documentation for goto-line Nikolaos Bezirgiannis
@ 2019-12-21 17:49 ` Eli Zaretskii
  2019-12-21 21:57   ` Nikolaos Bezirgiannis
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2019-12-21 17:49 UTC (permalink / raw)
  To: Nikolaos Bezirgiannis; +Cc: 38701

> From: Nikolaos Bezirgiannis <bezirg@gmail.com>
> Date: Sat, 21 Dec 2019 16:00:39 +0100
> 
> I think there is a typo in the docstring of the `goto-line` function.
> I attach a fix.

Why did you think it was a typo?  What does (N - 1) does in Lisp?

Thanks.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#38701: [PATCH] fix documentation for goto-line
  2019-12-21 17:49 ` Eli Zaretskii
@ 2019-12-21 21:57   ` Nikolaos Bezirgiannis
  0 siblings, 0 replies; 3+ messages in thread
From: Nikolaos Bezirgiannis @ 2019-12-21 21:57 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 38701

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

My mistake. I have closed this as notabug.

On Sat, 21 Dec 2019, 18:50 Eli Zaretskii, <eliz@gnu.org> wrote:

> > From: Nikolaos Bezirgiannis <bezirg@gmail.com>
> > Date: Sat, 21 Dec 2019 16:00:39 +0100
> >
> > I think there is a typo in the docstring of the `goto-line` function.
> > I attach a fix.
>
> Why did you think it was a typo?  What does (N - 1) does in Lisp?
>
> Thanks.
>

[-- Attachment #2: Type: text/html, Size: 759 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-21 21:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-21 15:00 bug#38701: [PATCH] fix documentation for goto-line Nikolaos Bezirgiannis
2019-12-21 17:49 ` Eli Zaretskii
2019-12-21 21:57   ` Nikolaos Bezirgiannis

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).