From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Fussner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52734: 28.0.90; [PATCH] xref-backend-definitions in etags.el duplicates list Date: Wed, 22 Dec 2021 15:01:54 +0000 Message-ID: Reply-To: David Fussner Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000942dd005d3bd685a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15824"; mail-complaints-to="usenet@ciao.gmane.io" To: 52734@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 22 16:03:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n039I-0003y1-M5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Dec 2021 16:03:24 +0100 Original-Received: from localhost ([::1]:52738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n039G-0004Xy-V7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Dec 2021 10:03:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n038w-0004UY-45 for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 10:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n038v-0008OP-OR for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 10:03:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n038v-0007l8-MY for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 10:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Fussner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Dec 2021 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52734 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164018534529780 (code B ref -1); Wed, 22 Dec 2021 15:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Dec 2021 15:02:25 +0000 Original-Received: from localhost ([127.0.0.1]:59498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n038L-0007kG-6i for submit@debbugs.gnu.org; Wed, 22 Dec 2021 10:02:25 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:53694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n038K-0007k9-4T for submit@debbugs.gnu.org; Wed, 22 Dec 2021 10:02:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n038J-00041u-Ux for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 10:02:23 -0500 Original-Received: from [2607:f8b0:4864:20::72c] (port=39771 helo=mail-qk1-x72c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n038H-0008K2-W5 for bug-gnu-emacs@gnu.org; Wed, 22 Dec 2021 10:02:23 -0500 Original-Received: by mail-qk1-x72c.google.com with SMTP id 69so2533350qkd.6 for ; Wed, 22 Dec 2021 07:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=iB/0QPMmRMf8iFBJxXv3+1wHhy6YnYoXplKwNqHY59A=; b=V8yQlBSNgaOtQxMkwBrlTKH36cdDLzNTl05nSWauQZxTsQZOm6aNHfkQJNgCPSG3uk u4OBfP8R/IbMHvt1rjmoDQdWAmFmupZjkOQE3SuC41Z/s0xY8rVT0yTWoKzZ0SSHd0xQ ZVXEeQNqaBULlakSVGx3p15IvddjNXIbOtO0obzg34501PUI5M4trtvcWAZEabDQHcuj Og2UodG4HAGTEZtbLH5Xdd1H8IYmN+bBtszJfaGrOYo6KwmZUaZ9XlOXa8Sg0cH2mHtF DGE62/KBgoQicqjRV8OZey782xS/k5dQYBPj9J8iB6pM6pfxWnSyivoFcSqBz5gTFYol QYBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=iB/0QPMmRMf8iFBJxXv3+1wHhy6YnYoXplKwNqHY59A=; b=OKJ2fuoWA0W8Z/CqQG0jN/NeKLfk0P+mrOpoay5Pu8LgEB1rtEpgzlseNOA8r0uojE NCHS2WWzLDmzAJGsWEE7jXrFz8BeEMfbop1Gh0BCxSpl5Pokqzxn3i3ifEzGRl4PLa9H knoJDj/u7k6dc2K79Hm4jX12/TuBxorl7ErRMXTMDKVlN5lC0d07ykuP8P7Rk/AFb2J/ 4W/NF7i93Z1JxWHXq6Lf+cyGCYRpuaRs3bdar4wHe1scP06PjOCRuM9X5Ynilnp27sya lQSHtwbs1g2SQYhWvr6ga0VuOul/sFtkg9y8+zi5dGTqZJMe/YcJvImCg/bzOb1FDPB5 Qv3g== X-Gm-Message-State: AOAM532NdQNOTTsNsz7H/WDAmUzCHP5epQS9qoQTNtQsS2Ouv/Gqh+rm 0UCeM4WDC2oXg8ZqwRLoSfZ1AFBOF15XpemTnoziQq9Q7zl+HA== X-Google-Smtp-Source: ABdhPJwkDPhGRjSrhmuCU3XMXUPfsMueWnxUVuUWXcECElE7qnVojTWYgun65p89zGGRbsz+snRBr8jh63sFyFLhi74= X-Received: by 2002:a37:9b82:: with SMTP id d124mr968734qke.487.1640185340361; Wed, 22 Dec 2021 07:02:20 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::72c (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::72c; envelope-from=dfussner@googlemail.com; helo=mail-qk1-x72c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222947 Archived-At: --000000000000942dd005d3bd685a Content-Type: text/plain; charset="UTF-8" When `etags-xref-prefer-current-file' is t and only the current file contains (multiple) definitions of the same function, the list returns each tag twice. To reproduce: cd src/ ../lib-src/etags term.c ./emacs -Q term.c C-s tty_free_frame_resources RTN M-. RTN src/term.c 3786: tty_free_frame_resources 3798: tty_free_frame_resources (setq etags-xref-prefer-current-file t) M-. src/term.c 3786: tty_free_frame_resources 3798: tty_free_frame_resources 3786: tty_free_frame_resources 3798: tty_free_frame_resources The variable is new in 28.1, so I thought the bug might want fixing on this branch. In my testing, cl-delete appears not to delete ITEMs from SEQ if such deletion would leave SEQ empty. I can't find this behavior documented anywhere, but I may be looking in the wrong places. Patch attached, which just tests for equality of the two lists of definitions, and only returns one of them in that case. Thanks, David. In GNU Emacs 28.0.90 (build 3, i686-pc-linux-gnu, GTK+ Version 3.18.9, cairo version 1.14.6) of 2021-12-22 built on newfont Repository revision: ce7ec828f15446c1218614d083da489c76e9b37d Repository branch: cl-del-again Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: Slackware 14.2 Configured using: 'configure PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/local/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: en_US.ISO8859-1 locale-coding-system: iso-latin-1-unix Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Load-path shadows: /home/dfussner/.emacs.d/elpa/transient-20210426.2141/transient hides /home/dfussner/src/emacs/emacs/lisp/transient Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date help-fns radix-tree help-mode misearch multi-isearch vc-git diff-mode easy-mmode vc-dispatcher bug-reference doom-opera-theme doom-themes doom-themes-base edmacro kmacro server preview-latex auto-loads tex-site finder-inf info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 275188 34213) (symbols 24 15726 0) (strings 16 79597 3815) (string-bytes 1 2052213) (vectors 8 24263) (vector-slots 4 365962 27260) (floats 8 208 168) (intervals 28 819 0) (buffers 564 14) (heap 1024 25437 912)) --000000000000942dd005d3bd685a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-xref-backend-definitions-in-etags.el.patch" Content-Disposition: attachment; filename="0001-Fix-xref-backend-definitions-in-etags.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kxhnxwxt0 RnJvbSBjZTdlYzgyOGYxNTQ0NmMxMjE4NjE0ZDA4M2RhNDg5Yzc2ZTliMzdkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBGdXNzbmVyIDxkZnVzc25lckBnb29nbGVtYWlsLmNv bT4KRGF0ZTogVHVlLCAyMSBEZWMgMjAyMSAxNzozODo1MiArMDAwMApTdWJqZWN0OiBbUEFUQ0hd IEZpeCB4cmVmLWJhY2tlbmQtZGVmaW5pdGlvbnMgaW4gZXRhZ3MuZWwKCiogbGlzcC9wcm9nbW9k ZXMvZXRhZ3MuZWwgKHhyZWYtYmFja2VuZC1kZWZpbml0aW9ucyk6IFdoZW4KJ2V0YWdzLXhyZWYt cHJlZmVyLWN1cnJlbnQtZmlsZScgaXMgdCwgdGVzdCB3aGV0aGVyICdkZWZpbml0aW9ucycgYW5k CidzYW1lLWZpbGUtZGVmaW5pdGlvbnMnIGFyZSBlcXVhbCBiZWZvcmUgY29uY2F0ZW5hdGluZyB0 aGVtLgotLS0KIGxpc3AvcHJvZ21vZGVzL2V0YWdzLmVsIHwgNSArKystLQogMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3By b2dtb2Rlcy9ldGFncy5lbCBiL2xpc3AvcHJvZ21vZGVzL2V0YWdzLmVsCmluZGV4IGY1M2IwOWQ5 ZTguLjBlNzBlN2VlN2EgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2V0YWdzLmVsCisrKyBi L2xpc3AvcHJvZ21vZGVzL2V0YWdzLmVsCkBAIC0yMDkyLDggKzIwOTIsOSBAQCB4cmVmLWJhY2tl bmQtZGVmaW5pdGlvbnMKICAgICAgICAgICAgKHB1c2ggZGVmaW5pdGlvbiBzYW1lLWZpbGUtZGVm aW5pdGlvbnMpCiAgICAgICAgICAgIHQpKQogICAgICAgIGRlZmluaXRpb25zKQotICAgICAgKHNl dHEgZGVmaW5pdGlvbnMgKG5jb25jIChucmV2ZXJzZSBzYW1lLWZpbGUtZGVmaW5pdGlvbnMpCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmaW5pdGlvbnMpKSkKKyAgICAgIChzZXRx IHNhbWUtZmlsZS1kZWZpbml0aW9ucyAobnJldmVyc2Ugc2FtZS1maWxlLWRlZmluaXRpb25zKSkK KyAgICAgICh1bmxlc3MgKGVxdWFsIGRlZmluaXRpb25zIHNhbWUtZmlsZS1kZWZpbml0aW9ucykK KyAgICAgICAgKHNldHEgZGVmaW5pdGlvbnMgKG5jb25jIHNhbWUtZmlsZS1kZWZpbml0aW9ucyBk ZWZpbml0aW9ucykpKSkKICAgICBkZWZpbml0aW9ucykpCiAKIChjbC1kZWZtZXRob2QgeHJlZi1i YWNrZW5kLWFwcm9wb3MgKChfYmFja2VuZCAoZXFsICdldGFncykpIHBhdHRlcm4pCi0tIAoyLjE3 LjYKCg== --000000000000942dd005d3bd685a--