From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Fussner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#44794: 28.0.50; Frame creation broken with (tool-bar-mode -1) Date: Sun, 22 Nov 2020 18:54:04 +0000 Message-ID: References: <838satxufx.fsf@gnu.org> <83o8jpw813.fsf@gnu.org> Reply-To: David Fussner Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16238"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , 44794@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 22 19:57:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kguXv-00047i-MK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Nov 2020 19:57:11 +0100 Original-Received: from localhost ([::1]:54946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kguXu-0005IH-NP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Nov 2020 13:57:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kguXn-0005Hj-EP for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 13:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kguXm-0003vN-Lt for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 13:57:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kguXm-0004N7-GD for bug-gnu-emacs@gnu.org; Sun, 22 Nov 2020 13:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: David Fussner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Nov 2020 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44794 X-GNU-PR-Package: emacs Original-Received: via spool by 44794-submit@debbugs.gnu.org id=B44794.160607140416768 (code B ref 44794); Sun, 22 Nov 2020 18:57:02 +0000 Original-Received: (at 44794) by debbugs.gnu.org; 22 Nov 2020 18:56:44 +0000 Original-Received: from localhost ([127.0.0.1]:48287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kguXT-0004MO-MS for submit@debbugs.gnu.org; Sun, 22 Nov 2020 13:56:43 -0500 Original-Received: from mail-qt1-f178.google.com ([209.85.160.178]:39918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kguXP-0004M9-HM for 44794@debbugs.gnu.org; Sun, 22 Nov 2020 13:56:42 -0500 Original-Received: by mail-qt1-f178.google.com with SMTP id f27so1879903qtv.6 for <44794@debbugs.gnu.org>; Sun, 22 Nov 2020 10:56:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GvLF2lHPtj0nfNyrK6db6VkD34nksy9kGomcQZU5zfc=; b=tmTbdN6GTphQgkB816q95RRjG/Q6rnRVCUB9sY/We5T/xL8xxWoj5D5UHjjizf0QmY NVpfF10WFV19FqaU80hI+uWn54s2Mg7NTxB+YCT9wBrUHnU85dFdKhRT4KeqgmMPhRGw OKYoLNGuvuzr5htSW4cwbu04iREPblbsjLNuRgvPCgl/t9LatUlF+Dahd0yukzSqBZzk zWqhFZWJEdrsyEoh5oVOE3NRYrhcF7pWP6aPmFfrLw7ADtnEfPMJzVbL6j4hWLFamvA6 MvLJbLgNs6Vu6k3WQAzJSVfjWhPW7WIFwtE5kyoIuiMZxdL4rh8/VO1/tS9+HRDg6upT EO7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GvLF2lHPtj0nfNyrK6db6VkD34nksy9kGomcQZU5zfc=; b=BN9U7ChC37w9lVVbK+JVP6AOqMVBoFMtFztpkmBu2G2GlEPkYer2H2pRTRS4kdFVkw IBNgS3LbczrEUn+sDaK77bgeCI5V5m2VtR9jIVYDsZa/pwbNbbdQLHVKSqhXqiUXOnbM +cUVRz5WGVo7JiB4bBdC3QpMjlZ1oorFk2jYDBxDbYwS7kO4PY92vjSi8dYTNYGfK7XN oxyWmtXsU3WkMc85UjhaAHYaz0fB9/V2cFEIw4/K3uKdwihm1t6eSXOoHzXheX6I1l01 OZQVimz1NSvAn5G9582VWT9yhNBvEettCTZrZE73ZpGgK0WmS7XLuNjtF9oXN/YRqR57 VQYg== X-Gm-Message-State: AOAM533nkFFABb51CUg8ca3Q9FMbiSpEze6hnUNWjhmWxhKi7n7QXBSX qkJBiH6ndFnlmKRYw/XOx0yNzbkAE3Fo8e439w0= X-Google-Smtp-Source: ABdhPJzjnl5UoTO6VTiycE7ZtQ+KaczqgJCjxFUIg6gfS6HTANvIC6w6of/PmX/SOY7sA/mlTO/bCVbz/nclfRwDbA4= X-Received: by 2002:a05:622a:291:: with SMTP id z17mr25659475qtw.180.1606071393919; Sun, 22 Nov 2020 10:56:33 -0800 (PST) In-Reply-To: <83o8jpw813.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193864 Archived-At: Forgive my incompetence, but my idea for how to do that appears to be faulty -- what would be the simplest way to detect which branch the code takes? On Sun, 22 Nov 2020 at 18:39, Eli Zaretskii wrote: > > > From: David Fussner > > Date: Sun, 22 Nov 2020 18:08:59 +0000 > > Cc: Stefan Kangas , 44794@debbugs.gnu.org > > > > Strange that the issue just turned up after that commit, though. My > > .emacs hasn't changed in quite a while. Is there anything I can do to > > help debug this? With some guidance from you both I can run emacs > > under gdb if that might produce useful information. > > I'd begin by establishing which of the two if/else branches of the > offending code your Emacs takes: > > Lisp_Object system_name = Fsystem_name (); > static char const title[] = "GNU Emacs"; > if (STRINGP (system_name)) > { > static char const at[] = " at "; > ptrdiff_t nbytes = sizeof (title) + sizeof (at); > if (INT_ADD_WRAPV (nbytes, SBYTES (system_name), &nbytes)) > memory_full (SIZE_MAX); > dpyinfo->x_id_name = xmalloc (nbytes); > sprintf (dpyinfo->x_id_name, "%s%s%s", title, at, SDATA (system_name)); > } > else > { > dpyinfo->x_id_name = xmalloc (sizeof (title)); > strcpy (dpyinfo->x_id_name, title); > }