From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nathan Moreau Newsgroups: gmane.emacs.bugs Subject: bug#40967: 27.0.50; vc-diff in indirect buffers Date: Wed, 29 Apr 2020 20:01:17 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000dc07a805a471bc96" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="50273"; mail-complaints-to="usenet@ciao.gmane.io" To: 40967@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 29 20:02:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jTr2Y-000Cyo-7Y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 20:02:34 +0200 Original-Received: from localhost ([::1]:37032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTr2W-0004EM-0t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Apr 2020 14:02:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60438) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTr23-0004ED-4A for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 14:02:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTr22-0000aG-9D for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 14:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTr21-0000aB-Si for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 14:02:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTr21-0000Zw-Q7 for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 14:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nathan Moreau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Apr 2020 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40967 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15881833102205 (code B ref -1); Wed, 29 Apr 2020 18:02:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Apr 2020 18:01:50 +0000 Original-Received: from localhost ([127.0.0.1]:44500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTr1e-0000ZJ-HW for submit@debbugs.gnu.org; Wed, 29 Apr 2020 14:01:50 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jTr1c-0000ZB-EL for submit@debbugs.gnu.org; Wed, 29 Apr 2020 14:01:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60336) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTr1b-0004AQ-JU for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 14:01:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTr1Y-0000DJ-WF for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 14:01:35 -0400 Original-Received: from mail-vs1-f45.google.com ([209.85.217.45]:43722) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTr1Y-0000DA-6I for bug-gnu-emacs@gnu.org; Wed, 29 Apr 2020 14:01:32 -0400 Original-Received: by mail-vs1-f45.google.com with SMTP id m24so2000986vsq.10 for ; Wed, 29 Apr 2020 11:01:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=gT6Xm0+tnVlN8PxMI4UDe88KD1ZSQcPtni8tKWDnkWY=; b=gJ+qG7LFHZPzhbsuTDhSKYndGwb9VbcygDI6LY+eSrnQCUIDYA9WOL0dliHWp1lsva wYttg28/N7JAuzCKwyxdaxEwkYvmIKu1hBq4gdtzgSa0EIl1I04NYMx0l8MkpByDocSF giliuVV8dnyL48hMO1mx9dLik7S5Pjx+bLe1P3dBZb+AGrI8bkM2KP+3La2wo+SbSIk6 HF1+sCKQO5u8psiiNapZAsLUQGoBOzrB8Cmkk1+pRxWw9aQs2Kzgktt/X17QnApHPZzw +Ja4ztEAAhYuOECqmCMJSoX+3th+8on2XFy/VV0Zr/OViPnFdW3M1XCnYSRIOwPEuH8W sBdg== X-Gm-Message-State: AGi0PuZg8Vfc2yBuKo0Yk9dhkEzqyYGnyHlG1y+YqC4o3o66GydZYfVQ AhvrpnQRL289WsoEVu7jEWxxYk0zyfbjG4gN3IqbqNk8us4= X-Google-Smtp-Source: APiQypJPtIZdR6lfT40KG6KhaiP2616A3MFwf+2hOZHFpNMTOVuCwu6U0XSyi4gaNfwqnpAflMVCBsAwXl8dbLtoldw= X-Received: by 2002:a05:6102:3005:: with SMTP id s5mr24396131vsa.237.1588183290321; Wed, 29 Apr 2020 11:01:30 -0700 (PDT) Received-SPF: pass client-ip=209.85.217.45; envelope-from=nathanjmoreau@gmail.com; helo=mail-vs1-f45.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/29 14:01:31 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179337 Archived-At: --000000000000dc07a805a471bc96 Content-Type: text/plain; charset="UTF-8" Calling vc-diff does not work in indirect buffers. If the base buffer visits a file under version control, I expect it to behave as if called from the base buffer. The attached patch is a possible fix in that direction. I don't know if other commands in vc should have the same fix, should that kind of patch be applied. Reproduction steps: =============== run emacs -Q open any file-under-version-control M-x clone-indirect-buffer In the new buffer, run vc-diff fails with `vc-deduce-fileset: Buffer [...] is not associated with a file` Details about the machine: ==================== Configured using: 'configure --without-dbus --host=x86_64-w64-mingw32 --without-compress-install -C 'CFLAGS=-O2 -static -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY W32NOTIFY ACL GNUTLS LIBXML2 HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS MODULES THREADS PDUMPER LCMS2 GMP Important settings: value of $LANG: ENU locale-coding-system: cp65001 Major mode: Messages Minor modes in effect: global-subword-mode: t subword-mode: t save-place-mode: t minibuffer-depth-indicate-mode: t global-undo-tree-mode: t recentf-mode: t show-paren-mode: t global-auto-revert-mode: t savehist-mode: t delete-selection-mode: t override-global-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t global-visual-line-mode: t visual-line-mode: t transient-mark-mode: t Load-path shadows: ~/.emacs.d/swiper/elpa hides ~/.emacs.d/lispy/elpa Features: (shadow sort mail-extr emacsbug message rmc puny format-spec rfc822 mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils bookmark text-property-search pp smerge-mode tabify multiple-cursors-core rect eieio-opt speedbar sb-image ezimage dframe counsel xdg dired dired-loaddefs apropos go-mode url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap find-file ffap compile cl-print debug cus-start cus-load diff-hl face-remap vc-hg vc-dir vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs ewoc vc vc-dispatcher vc-git diff-mode lispy swiper lispy-inline noutline outline etags fileloop generator edebug backtrace help-fns radix-tree lispy-tags mode-local find-func rainbow-delimiters hl-todo pcase my-color-theme init my-init highlight-symbol thingatpt cap-words superword subword saveplace ace-link mb-depth hl-line battery undo-tree diff avy rx ivy-hydra ivy-xref ivy colir color ivy-overlay xref project recentf tree-widget wid-edit hydra lv hippie-exp comint ansi-color ring key-chord benchmark-init-modes paren elec-pair autorevert filenotify savehist delsel dabbrev cl-extra help-mode edmacro kmacro diminish cl use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core derived benchmark-init advice info package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 311030 114283) (symbols 48 21138 1) (strings 32 60774 2776) (string-bytes 1 1941284) (vectors 16 26613) (vector-slots 8 306017 10984) (floats 8 293 480) (intervals 56 3804 12) (buffers 1000 24)) --000000000000dc07a805a471bc96 Content-Type: application/octet-stream; name="vc-diff-indirect-buffers.diff" Content-Disposition: attachment; filename="vc-diff-indirect-buffers.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k9ln9xds0 ZGlmZiAtLWdpdCBhL2xpc3AvdmMvdmMuZWwgYi9saXNwL3ZjL3ZjLmVsDQppbmRleCAxMzIyNzhl ODIzLi5kMWMzMzljNWI1IDEwMDY0NA0KLS0tIGEvbGlzcC92Yy92Yy5lbA0KKysrIGIvbGlzcC92 Yy92Yy5lbA0KQEAgLTE4NzQsOSArMTg3NCwxMCBAQCBzYXZpbmcgdGhlIGJ1ZmZlci4iDQogICAo aW50ZXJhY3RpdmUgKGxpc3QgY3VycmVudC1wcmVmaXgtYXJnIHQpKQ0KICAgKGlmIGhpc3Rvcmlj DQogICAgICAgKGNhbGwtaW50ZXJhY3RpdmVseSAndmMtdmVyc2lvbi1kaWZmKQ0KLSAgICAod2hl biBidWZmZXItZmlsZS1uYW1lICh2Yy1idWZmZXItc3luYyBub3QtdXJnZW50KSkNCi0gICAgKHZj LWRpZmYtaW50ZXJuYWwgdCAodmMtZGVkdWNlLWZpbGVzZXQgdCkgbmlsIG5pbA0KLQkJICAgICAg KGNhbGxlZC1pbnRlcmFjdGl2ZWx5LXAgJ2ludGVyYWN0aXZlKSkpKQ0KKyAgICAod2l0aC1jdXJy ZW50LWJ1ZmZlciAob3IgKGJ1ZmZlci1iYXNlLWJ1ZmZlcikgKGN1cnJlbnQtYnVmZmVyKSkNCisg ICAgICAod2hlbiBidWZmZXItZmlsZS1uYW1lICh2Yy1idWZmZXItc3luYyBub3QtdXJnZW50KSkN CisgICAgICAodmMtZGlmZi1pbnRlcm5hbCB0ICh2Yy1kZWR1Y2UtZmlsZXNldCB0KSBuaWwgbmls DQorICAgICAgICAgICAgICAgICAgICAgICAgKGNhbGxlZC1pbnRlcmFjdGl2ZWx5LXAgJ2ludGVy YWN0aXZlKSkpKSkNCiANCiA7OzsjIyNhdXRvbG9hZA0KIChkZWZ1biB2Yy1kaWZmLW1lcmdlYmFz ZSAoX2ZpbGVzIHJldjEgcmV2MikNCg== --000000000000dc07a805a471bc96--