From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ahmed Khanzada Newsgroups: gmane.emacs.bugs Subject: bug#46111: Reverting fns.c hash function due to OpenBSD/SPARC64 compile breaking Date: Mon, 25 Jan 2021 22:57:18 -0800 Message-ID: References: <87sg6oyzi6.wl-me@enzu.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000059e5b05b9c82bfd" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11675"; mail-complaints-to="usenet@ciao.gmane.io" To: 46111@debbugs.gnu.org, me@enzu.ru Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 26 10:25:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l4Kb8-0002ur-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Jan 2021 10:25:18 +0100 Original-Received: from localhost ([::1]:59626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4Kb7-0007gc-0N for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 26 Jan 2021 04:25:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41374) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4Kau-0007fJ-Tf for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 04:25:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4Kas-0002vv-6b for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 04:25:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l4Kas-0002H6-1g for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 04:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ahmed Khanzada Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jan 2021 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46111 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Ahmed Khanzada Original-Received: via spool by submit@debbugs.gnu.org id=B.16116530908717 (code B ref -1); Tue, 26 Jan 2021 09:25:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jan 2021 09:24:50 +0000 Original-Received: from localhost ([127.0.0.1]:40744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4Kaf-0002GX-P8 for submit@debbugs.gnu.org; Tue, 26 Jan 2021 04:24:50 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l4IIB-0004zq-Fc for submit@debbugs.gnu.org; Tue, 26 Jan 2021 01:57:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4IIA-0006LS-BQ for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:57:35 -0500 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:34417) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l4II8-0003sP-0K for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2021 01:57:33 -0500 Original-Received: by mail-ot1-x332.google.com with SMTP id a109so15353305otc.1 for ; Mon, 25 Jan 2021 22:57:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enzu-ru.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LOOUlt0J0iDlM6a1uOn4WkBpOYkHcGKcWsRKRDsk9lU=; b=QV0ll3Zz/oax7xnhGNcJo+szTcP7xe718IMGW1wEsWVAq7hSjHkBJ6SuZ7SI5yi4Ya OX0WLiX9CdXQni8bK4kJuX1jH8DIzrKIR0XLFAxXb6Fk/nQ8SI4Kbh7lzJ9w94ci5djm vG6W3ktdr+WVfICA5hnMCcLdunlXbIPwSLr8pgdJTdrwxkfhyeYdkjsNGfK52xTeEgwT qEXo2GC2/h8X3LqglOLxYKbMC6RaOdVpcSA3Gx9ezKQ3RPb7SuRCYDIiDG2sQq5rlVM5 DTBshlU+Ho/KVfPMIGaAPrTsV5EhL6HxmBFIoFAa+DV7+m9uG2se4F04ip0OiaRf4IWh vehQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LOOUlt0J0iDlM6a1uOn4WkBpOYkHcGKcWsRKRDsk9lU=; b=XWrYcGjhaMlN5hOFuxGDRYT+YoDVYigDfpPnP0QXY/A/zDXuWenENretm36bzBtPkE TSCNATjBD3CTzQbSR3fGN4S5ZQIsv5Vz0vbrIyaWDEG53eleIi9jKGk62GAhVAwD4fnM DHEnaNPePwSwjvB6lkpHhLCC4VwCy0gpl6Cn6Kf84ymLcBEv9gihmaFZcDNx1IqKB+vG CHz+VASjCJATfY11aJE7BQ/10j1KvntZgC6W5tc5lvohL+/jGzvkGQJW75Dy7Qnf0+eZ qu3EbBvvvNG87lFPTskLWteoxM2kVEQLj2ftYjsdpGp7ATCgnyHewW0/9oAwcQZwZtNy Ly2g== X-Gm-Message-State: AOAM530+jSbmdaAIbNr7d1MDZWm7k4vd8yHtcTpUwNld5UbMw5ku8vj1 ZFPiS2KKtdAG6SYaJaff45eTDpRKYfylGlDChn1Ro5PYrgg= X-Google-Smtp-Source: ABdhPJzXPhANG0JWL3D0VXlyYDRlbdQR8wjBevzBLzqWgBWFt6otOvQVCSDO1iJLtXvvglhkRSBnzEvj4pwbCylVQD8= X-Received: by 2002:a9d:7a4a:: with SMTP id z10mr3137110otm.206.1611644249927; Mon, 25 Jan 2021 22:57:29 -0800 (PST) In-Reply-To: <87sg6oyzi6.wl-me@enzu.ru> Received-SPF: none client-ip=2607:f8b0:4864:20::332; envelope-from=me@enzu.ru; helo=mail-ot1-x332.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 26 Jan 2021 04:24:48 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198613 Archived-At: --000000000000059e5b05b9c82bfd Content-Type: text/plain; charset="UTF-8" Not sure if the patch attached correctly. Trying again. On Mon, Jan 25, 2021 at 10:37 PM Ahmed Khanzada wrote: > > I'm not an expert on C, OpenBSD, or SPARC64, but I did notice > emacs-current was not compiling. > > During a gmake, bootstrap-emacs would get a SIGBUS and fail. Running > gdb led me to the hash_string function where it seemed to be failing. > > Reverting the hash_string function to a previous version seems to have > fixed the issue. > > If I had to guess, it may have something to do with SPARC64 alignment. > > I don't have an updated AMD64 OpenBSD box running at the moment, but if you > would like me to test there, I could find a way. > > I understand that reverting this function might not be the best way > forward, but wrote a patch just in case that reverts hash_string to an > earlier version that compiles on OpenBSD/SPARC64. > > I am already signed all my GNU contributor docs. > > --[[text/plain; type=patch; name="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" > Content-Disposition: attachment; filename="0001-Reverting-hasattach filh_string-function-due-to-problem-on-Ope.patch"][base64]] > RnJvbSBkOTM4NzQ1Y2U1NjA1OGJlMjQwNzhlYzUyZDk3Mzk4Njk3ZGI0Yjc2IE1vbiBTZXAgMTcg > MDA6MDA6MDAgMjAwMQpGcm9tOiBBaG1lZCBLaGFuemFkYSA8bWVAZW56dS5ydT4KRGF0ZTogTW9u > LCAyNSBKYW4gMjAyMSAyMToxNjo0OCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVydGluZyBo > YXNoX3N0cmluZyBmdW5jdGlvbiBkdWUgdG8gcHJvYmxlbSBvbgogT3BlbkJTRC9TUEFSQzY0Cgot > LS0KIHNyYy9mbnMuYyB8IDMyICsrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZp > bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg > YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggN2FiMmU4ZjFhMC4uMDEyN2ZlM2Y0OCAxMDA2 > NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDU5OSwzNCArNDU5OSwxNiBA > QCAjZGVmaW5lIFNYSEFTSF9NQVhfTEVOICAgNwogRU1BQ1NfVUlOVAogaGFzaF9zdHJpbmcgKGNo > YXIgY29uc3QgKnB0ciwgcHRyZGlmZl90IGxlbikKIHsKLSAgRU1BQ1NfVUlOVCBjb25zdCAqcCAg > ID0gKEVNQUNTX1VJTlQgY29uc3QgKikgcHRyOwotICBFTUFDU19VSU5UIGNvbnN0ICplbmQgPSAo > RU1BQ1NfVUlOVCBjb25zdCAqKSAocHRyICsgbGVuKTsKLSAgRU1BQ1NfVUlOVCBoYXNoID0gbGVu > OwotICAvKiBBdCBtb3N0IDggc3RlcHMuICBXZSBjb3VsZCByZXVzZSBTWEhBU0hfTUFYX0xFTiwg > b2YgY291cnNlLAotICAgKiBidXQgZGl2aWRpbmcgYnkgOCBpcyBjaGVhcGVyLiAgKi8KLSAgcHRy > ZGlmZl90IHN0ZXAgPSAxICsgKChlbmQgLSBwKSA+PiAzKTsKLQotICAvKiBCZXdhcmU6IGBlbmRg > IG1pZ2h0IGJlIHVuYWxpZ25lZCwgc28gYHAgPCBlbmRgIGlzIG5vdCBhbHdheXMgdGhlIHNhbWUK > LSAgICogYXMgYHAgPD0gZW5kIC0gMWAuICAqLwotICB3aGlsZSAocCA8PSBlbmQgLSAxKQorICBj > aGFyIGNvbnN0ICpwID0gcHRyOworICBjaGFyIGNvbnN0ICplbmQgPSBwICsgbGVuOworICB1bnNp > Z25lZCBjaGFyIGM7CisgIEVNQUNTX1VJTlQgaGFzaCA9IDA7CisKKyAgd2hpbGUgKHAgIT0gZW5k > KQogICAgIHsKLSAgICAgIEVNQUNTX1VJTlQgYyA9ICpwOwotICAgICAgcCArPSBzdGVwOworICAg > ICAgYyA9ICpwKys7CiAgICAgICBoYXNoID0gc3hoYXNoX2NvbWJpbmUgKGhhc2gsIGMpOwogICAg > IH0KLSAgaWYgKHAgPCBlbmQpCi0gICAgeyAvKiBBIGZldyBsYXN0IGJ5dGVzIHJlbWFpbiAoc21h > bGxlciB0aGFuIGFuIEVNQUNTX1VJTlQpLiAgKi8KLSAgICAgIC8qIEZJWE1FOiBXZSBjb3VsZCBk > byB0aGlzIHdpdGhvdXQgYSBsb29wLCBidXQgaXQnZCByZXF1aXJlCi0gICAgICAgICBlbmRpYW4t > ZGVwZW5kZW50IGNvZGUgOi0oICAqLwotICAgICAgY2hhciBjb25zdCAqcDEgPSAoY2hhciBjb25z > dCAqKXA7Ci0gICAgICBjaGFyIGNvbnN0ICplbmQxID0gKGNoYXIgY29uc3QgKillbmQ7Ci0gICAg > ICBkbwotICAgICAgICB7Ci0gICAgICAgICAgdW5zaWduZWQgY2hhciBjID0gKnAxKys7Ci0gICAg > ICAgICAgaGFzaCA9IHN4aGFzaF9jb21iaW5lIChoYXNoLCBjKTsKLSAgICAgICAgfQotICAgICAg > d2hpbGUgKHAxIDwgZW5kMSk7Ci0gICAgfQogCiAgIHJldHVybiBoYXNoOwogfQotLSAKMi4yOC4w > Cgo= --000000000000059e5b05b9c82bfd Content-Type: application/octet-stream; name="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" Content-Disposition: attachment; filename="0001-Reverting-hash_string-function-due-to-problem-on-Ope.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kkdnchls0 RnJvbSBkOTM4NzQ1Y2U1NjA1OGJlMjQwNzhlYzUyZDk3Mzk4Njk3ZGI0Yjc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBaG1lZCBLaGFuemFkYSA8bWVAZW56dS5ydT4KRGF0ZTogTW9u LCAyNSBKYW4gMjAyMSAyMToxNjo0OCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJldmVydGluZyBo YXNoX3N0cmluZyBmdW5jdGlvbiBkdWUgdG8gcHJvYmxlbSBvbgogT3BlbkJTRC9TUEFSQzY0Cgot LS0KIHNyYy9mbnMuYyB8IDMyICsrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAyNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9zcmMvZm5zLmMgYi9zcmMvZm5zLmMKaW5kZXggN2FiMmU4ZjFhMC4uMDEyN2ZlM2Y0OCAxMDA2 NDQKLS0tIGEvc3JjL2Zucy5jCisrKyBiL3NyYy9mbnMuYwpAQCAtNDU5OSwzNCArNDU5OSwxNiBA QCAjZGVmaW5lIFNYSEFTSF9NQVhfTEVOICAgNwogRU1BQ1NfVUlOVAogaGFzaF9zdHJpbmcgKGNo YXIgY29uc3QgKnB0ciwgcHRyZGlmZl90IGxlbikKIHsKLSAgRU1BQ1NfVUlOVCBjb25zdCAqcCAg ID0gKEVNQUNTX1VJTlQgY29uc3QgKikgcHRyOwotICBFTUFDU19VSU5UIGNvbnN0ICplbmQgPSAo RU1BQ1NfVUlOVCBjb25zdCAqKSAocHRyICsgbGVuKTsKLSAgRU1BQ1NfVUlOVCBoYXNoID0gbGVu OwotICAvKiBBdCBtb3N0IDggc3RlcHMuICBXZSBjb3VsZCByZXVzZSBTWEhBU0hfTUFYX0xFTiwg b2YgY291cnNlLAotICAgKiBidXQgZGl2aWRpbmcgYnkgOCBpcyBjaGVhcGVyLiAgKi8KLSAgcHRy ZGlmZl90IHN0ZXAgPSAxICsgKChlbmQgLSBwKSA+PiAzKTsKLQotICAvKiBCZXdhcmU6IGBlbmRg IG1pZ2h0IGJlIHVuYWxpZ25lZCwgc28gYHAgPCBlbmRgIGlzIG5vdCBhbHdheXMgdGhlIHNhbWUK LSAgICogYXMgYHAgPD0gZW5kIC0gMWAuICAqLwotICB3aGlsZSAocCA8PSBlbmQgLSAxKQorICBj aGFyIGNvbnN0ICpwID0gcHRyOworICBjaGFyIGNvbnN0ICplbmQgPSBwICsgbGVuOworICB1bnNp Z25lZCBjaGFyIGM7CisgIEVNQUNTX1VJTlQgaGFzaCA9IDA7CisKKyAgd2hpbGUgKHAgIT0gZW5k KQogICAgIHsKLSAgICAgIEVNQUNTX1VJTlQgYyA9ICpwOwotICAgICAgcCArPSBzdGVwOworICAg ICAgYyA9ICpwKys7CiAgICAgICBoYXNoID0gc3hoYXNoX2NvbWJpbmUgKGhhc2gsIGMpOwogICAg IH0KLSAgaWYgKHAgPCBlbmQpCi0gICAgeyAvKiBBIGZldyBsYXN0IGJ5dGVzIHJlbWFpbiAoc21h bGxlciB0aGFuIGFuIEVNQUNTX1VJTlQpLiAgKi8KLSAgICAgIC8qIEZJWE1FOiBXZSBjb3VsZCBk byB0aGlzIHdpdGhvdXQgYSBsb29wLCBidXQgaXQnZCByZXF1aXJlCi0gICAgICAgICBlbmRpYW4t ZGVwZW5kZW50IGNvZGUgOi0oICAqLwotICAgICAgY2hhciBjb25zdCAqcDEgPSAoY2hhciBjb25z dCAqKXA7Ci0gICAgICBjaGFyIGNvbnN0ICplbmQxID0gKGNoYXIgY29uc3QgKillbmQ7Ci0gICAg ICBkbwotICAgICAgICB7Ci0gICAgICAgICAgdW5zaWduZWQgY2hhciBjID0gKnAxKys7Ci0gICAg ICAgICAgaGFzaCA9IHN4aGFzaF9jb21iaW5lIChoYXNoLCBjKTsKLSAgICAgICAgfQotICAgICAg d2hpbGUgKHAxIDwgZW5kMSk7Ci0gICAgfQogCiAgIHJldHVybiBoYXNoOwogfQotLSAKMi4yOC4w Cgo= --000000000000059e5b05b9c82bfd--