bug#15137: python mode patch

bug#15137: python mode patch

[Daniel Elliott]

Hello,

I'm submitting a patch that has been tremendously helpful to me.
Please consider this for addition into the next release of the world's
most excellent editor.

2013-08-19  Dan Elliott  <danelliottster@gmail.com>

        * progmodes/python.el (python-shell-send-region): added fix
suggested by Barry Warsaw for python-mode.el to fix unexpected
indentation error w\
hen sending region to interpreter



=== modified file 'lisp/progmodes/python.el'
*** lisp/progmodes/python.el    2013-08-16 05:15:51 +0000
--- lisp/progmodes/python.el    2013-08-19 21:14:34 +0000
*************** Returns the output.  See `python-shell-s
*** 2128,2134 ****
        ;; When sending a region, add blank lines for non sent code so
        ;; backtraces remain correct.
        (make-string (1- line-num) ?\n))
!     (buffer-substring start end))
     nil t))

  (defun python-shell-send-buffer (&optional arg)
--- 2128,2137 ----
        ;; When sending a region, add blank lines for non sent code so
        ;; backtraces remain correct.
        (make-string (1- line-num) ?\n))
!     ;; wrap with a conditional to avoid errors about python
unexpected indentation
!     "if True:\n"
!     (buffer-substring start end)
!     "\n")
     nil t))

  (defun python-shell-send-buffer (&optional arg)

Thank you for all of your hard work.

- dan

bug#15137: python mode patch

[Stefan Monnier]

> !     (buffer-substring start end))
[...]
> !     ;; wrap with a conditional to avoid errors about python unexpected indentation
> !     "if True:\n"
> !     (buffer-substring start end)
> !     "\n")

That looks pretty good, thank you.
Fabián, could you take a look?


        Stefan

bug#15137: python mode patch

[fabian]

monnier@iro.umontreal.ca writes:

>> !     (buffer-substring start end))
> [...]
>> !     ;; wrap with a conditional to avoid errors about python unexpected indentation
>> !     "if True:\n"
>> !     (buffer-substring start end)
>> !     "\n")
>
> That looks pretty good, thank you.
> Fabián, could you take a look?
>

The idea is good but the patch needs bit more of work -- this approach
will work when an indented region is sent but won't when sending a
region which starts with no indentation at all. Also backtraces numbers
will be wrong for a -1 offset.

I'll push something for this soon.


Regards,
Fabián.

bug#15137: python mode patch

[Andreas Röhler]

Am 31.08.2013 14:44, schrieb fabian@anue.biz:
>
> monnier@iro.umontreal.ca writes:
>
>>> !     (buffer-substring start end))
>> [...]
>>> !     ;; wrap with a conditional to avoid errors about python unexpected indentation
>>> !     "if True:\n"
>>> !     (buffer-substring start end)
>>> !     "\n")
>>
>> That looks pretty good, thank you.
>> Fabián, could you take a look?
>>
>
> The idea is good but the patch needs bit more of work -- this approach
> will work when an indented region is sent but won't when sending a
> region which starts with no indentation at all.

Right. Current python-mode.el shifts region-or-whatever-delivered left until it starts at column 0.

> Also backtraces numbers
> will be wrong for a -1 offset.
>

Correct. BTW there is still the Emacs count-lines bug: at BOL it counts one less than from secoond column.


> I'll push something for this soon.
>
>
> Regards,
> Fabián.
>
>
>
>

bug#15137: python mode patch

[fgallina]

Solved this in revno 114108.


Regards,
Fabián.

bug#15137: python mode patch

[Daniel Elliott]

Fabian,

You are correct on both counts.  Please let me know if I can be of
assistance to you.  Thanks for your time and effort.

- dan

On Sat, Aug 31, 2013 at 7:44 AM,  <fabian@anue.biz> wrote:
>
> monnier@iro.umontreal.ca writes:
>
>>> !     (buffer-substring start end))
>> [...]
>>> !     ;; wrap with a conditional to avoid errors about python unexpected indentation
>>> !     "if True:\n"
>>> !     (buffer-substring start end)
>>> !     "\n")
>>
>> That looks pretty good, thank you.
>> Fabián, could you take a look?
>>
>
> The idea is good but the patch needs bit more of work -- this approach
> will work when an indented region is sent but won't when sending a
> region which starts with no indentation at all. Also backtraces numbers
> will be wrong for a -1 offset.
>
> I'll push something for this soon.
>
>
> Regards,
> Fabián.