From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Boris Buliga Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Mon, 29 Oct 2018 19:41:45 +0200 Message-ID: References: <7BCD942D-621D-4C91-AA8E-6C38908C03EE@d12frosted.io> <20181019184828.GA2041@breton.holly.idiocy.org> <20181020200444.GA2501@breton.holly.idiocy.org> <20181024104242.GA40431@breton.holly.idiocy.org> <20181029160943.GA60662@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000de95b705796195b9" X-Trace: blaine.gmane.org 1540834874 11338 195.159.176.226 (29 Oct 2018 17:41:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2018 17:41:14 +0000 (UTC) Cc: 32932@debbugs.gnu.org, Aaron Jensen To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 29 18:41:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHBXG-0002nA-J5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Oct 2018 18:41:06 +0100 Original-Received: from localhost ([::1]:47648 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHBZM-0007bm-Tq for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Oct 2018 13:43:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHBZC-0007an-DG for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 13:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHBZ9-0005bp-35 for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 13:43:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHBZ8-0005bh-RK for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 13:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gHBZ8-0003pr-I4 for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2018 13:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boris Buliga Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Oct 2018 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154083492514681 (code B ref 32932); Mon, 29 Oct 2018 17:43:02 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 29 Oct 2018 17:42:05 +0000 Original-Received: from localhost ([127.0.0.1]:52121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHBYC-0003oj-UD for submit@debbugs.gnu.org; Mon, 29 Oct 2018 13:42:05 -0400 Original-Received: from mail-oi1-f172.google.com ([209.85.167.172]:34027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHBYA-0003oE-OP for 32932@debbugs.gnu.org; Mon, 29 Oct 2018 13:42:03 -0400 Original-Received: by mail-oi1-f172.google.com with SMTP id f21-v6so4723107oig.1 for <32932@debbugs.gnu.org>; Mon, 29 Oct 2018 10:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d12frosted-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gTN30tJhzBCQmtK/o6V+MFqyc5XcT0zm/AEZKr4P8Ik=; b=NpT7+fGuX2nPIXcjc3Fhb6o7j2qnAr+/gHLvNIgfxtM2WQhLVOthmbG45En9cXUbSv 8v6zDupqD1A6PpYvZm2eMhvCm5z9oVyxid0uo8kJxUQ/hZROPzBH2Pfm1XkIMTybyV89 5zet9Tw6Xb+LUrxrfjwT5LLMhmsNruR/6+W7qPxH2QlGY+GIlmpDblqNrsE4PBLeI+X5 I6sKDbj+qU7+/a1J3IxEqKULJb8vH2oOdZAYhWLtV9Jpa04D60yKlRikVbm4w0IQiRRX 3EHfKNm8Ljp3XJgN+N5H+lCddTVT6aqqw6L9If136x2H/qtVnl0D2ugQNwSTHhmQ9zBb Wiqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gTN30tJhzBCQmtK/o6V+MFqyc5XcT0zm/AEZKr4P8Ik=; b=ubU+AbaiBd5TuN1BILSqHFZdUTouHuuwJtJaEk73yjF1Oza/8IYVhfBXXwn8QSkTrC OVJkTdLuDyiV+HjsKb1UqT2k+Ed2TO2p0afoNMQWlNr8rSk6LBBPXVKNvOxujFlV03ar jwY8PpA6r3oc0pFmOMZKv5lH4MlGHrWOReICTxhsAARgeQiyouVlyCtTVXDVVKJszgjN KV+XVi9canD2PUW87dA6gXkMmw2hDGU/vf9N3wsvGuROulCiSN9CCp4Hm7k8IKmx55yu tR+fcoH9mvTdUSRn06Y2TlOw00Bstf4EmEq6NbAuD6764iTK+Q1aViLnAIrlhq0BoYON LWoA== X-Gm-Message-State: AGRZ1gKO8b7mnkwbXieLiqHysrg1gi3FmlsJTQFVXm7q2Wnk1/nZZHmu k6s6di9DG9276ibUdFvPlBUPjuRcGPKcgRWtKtfRrQ== X-Google-Smtp-Source: AJdET5faYEC2Bje05d9G55RAKrxjD3p/JYxC2v7rek27TRxWok0elpBmFej+l39q4rCor3iPTFBcMVy8RVOuMu3fVTE= X-Received: by 2002:aca:3646:: with SMTP id d67-v6mr8613296oia.327.1540834916726; Mon, 29 Oct 2018 10:41:56 -0700 (PDT) In-Reply-To: <20181029160943.GA60662@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151780 Archived-At: --000000000000de95b705796195b9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Alan, Thank you for the patch. I will also give it a try because I experience flickering from time to time. On Mon, 29 Oct 2018 at 18:09, Alan Third wrote: > On Sun, Oct 28, 2018 at 07:18:04PM -0700, Aaron Jensen wrote: > > On October 24, 2018 at 3:42:47 AM, Alan Third > > (alan@idiocy.org(mailto:alan@idiocy.org)) wrote: > > > > > I=E2=80=99ve pushed a slight variant of this change to emacs-26. I=E2= =80=99ve > > > witnessed a very rare flicker of the modeline and the line containing > > > the cursor in other windows while scrolling, but I can=E2=80=99t repl= icate it > > > consistently. > > > > I am definitely seeing the flicker on the current line. It happens > > occasionally when my emacs is idle (probably not truly idle). I see it > > sometimes when I tell emacs to do something that is a thread blocking > > operation (like loading some autoloaded lisp for the first time). It=E2= =80=99s > > as if it clears the current line and then immediately blocks the > > rendering thread before it gets a chance to rerender the line. As soon > > as Emacs is done doing whatever it was doing, the line rerenders. > > > > No clue if that helps, but if there=E2=80=99s anything you want to try,= I=E2=80=99ll > > be able to let you know if it fixes it :) > > One more go. I don=E2=80=99t think I=E2=80=99ve seen the cursor line flic= ker after > installing this. > > Simply, all I=E2=80=99ve done is stop making it redraw the entire line th= e > cursor is on. That should stop any flicker of the line text caused by > redrawing the cursor, but won=E2=80=99t stop any flicker of the cursor it= self, > although I=E2=80=99ve not seen it flicker. > > There=E2=80=99s a bit more in here to do with drawing the fringe bitmaps, > because that was the only other place ns_clip_to_row was being used, > so I=E2=80=99ve removed it from there too. > -- > Alan Third > --=20 Cheers, Boris --000000000000de95b705796195b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Alan,

Thank you for the patch. I will a= lso give it a try because I experience flickering from time to time.
<= /div>
On Mon, 29 Oct 2018 at= 18:09, Alan Third <alan@idiocy.org> wrote:
On Sun, Oct 28, 2018 = at 07:18:04PM -0700, Aaron Jensen wrote:
> On October 24, 2018 at 3:42:47 AM, Alan Third
> (alan@idiocy.org<= /a>(mailto:alan@idiocy= .org)) wrote:
>
> > I=E2=80=99ve pushed a slight variant of this change to emacs-26. = I=E2=80=99ve
> > witnessed a very rare flicker of the modeline and the line contai= ning
> > the cursor in other windows while scrolling, but I can=E2=80=99t = replicate it
> > consistently.
>
> I am definitely seeing the flicker on the current line. It happens
> occasionally when my emacs is idle (probably not truly idle). I see it=
> sometimes when I tell emacs to do something that is a thread blocking<= br> > operation (like loading some autoloaded lisp for the first time). It= =E2=80=99s
> as if it clears the current line and then immediately blocks the
> rendering thread before it gets a chance to rerender the line. As soon=
> as Emacs is done doing whatever it was doing, the line rerenders.
>
> No clue if that helps, but if there=E2=80=99s anything you want to try= , I=E2=80=99ll
> be able to let you know if it fixes it :)

One more go. I don=E2=80=99t think I=E2=80=99ve seen the cursor line flicke= r after
installing this.

Simply, all I=E2=80=99ve done is stop making it redraw the entire line the<= br> cursor is on. That should stop any flicker of the line text caused by
redrawing the cursor, but won=E2=80=99t stop any flicker of the cursor itse= lf,
although I=E2=80=99ve not seen it flicker.

There=E2=80=99s a bit more in here to do with drawing the fringe bitmaps, because that was the only other place ns_clip_to_row was being used,
so I=E2=80=99ve removed it from there too.
--
Alan Third


--
Cheers,
Boris
--000000000000de95b705796195b9--