From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Boris Buliga Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Thu, 1 Nov 2018 08:13:41 +0200 Message-ID: References: <20181019184828.GA2041@breton.holly.idiocy.org> <20181020200444.GA2501@breton.holly.idiocy.org> <20181024104242.GA40431@breton.holly.idiocy.org> <20181029160943.GA60662@breton.holly.idiocy.org> <20181031171253.GA69712@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a6b04005799452ea" X-Trace: blaine.gmane.org 1541052729 6805 195.159.176.226 (1 Nov 2018 06:12:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Nov 2018 06:12:09 +0000 (UTC) Cc: Alan Third , 32932@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 01 07:12:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gI6D6-0001g9-Vc for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 07:12:05 +0100 Original-Received: from localhost ([::1]:35577 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI6FD-0000X0-G3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 02:14:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gI6F6-0000Wp-CG for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:14:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gI6F1-00068z-28 for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:14:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53422) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gI6F0-00067l-5z for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gI6Ez-00058V-Rq for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 02:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boris Buliga Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Nov 2018 06:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154105284019729 (code B ref 32932); Thu, 01 Nov 2018 06:14:01 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 1 Nov 2018 06:14:00 +0000 Original-Received: from localhost ([127.0.0.1]:57680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gI6Ey-000589-Iv for submit@debbugs.gnu.org; Thu, 01 Nov 2018 02:14:00 -0400 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:40246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gI6Ew-00057v-8m for 32932@debbugs.gnu.org; Thu, 01 Nov 2018 02:13:58 -0400 Original-Received: by mail-oi1-f180.google.com with SMTP id u130-v6so10994320oie.7 for <32932@debbugs.gnu.org>; Wed, 31 Oct 2018 23:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d12frosted-io.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RcQ3O61O+57c5KIRnd84roAihW9iRAp9ia33qAX9ytw=; b=u4KsVS2PHAGczHc3O9GhgxMUvSmQjYyCoYUPvX8REZit7/wEhr+2sRb18kEb1OL3J9 7g9SL9ngw9KFoKBe9i8UHuSrcEH60gpIEhK588+JCqxTls+p4IYe1afjXvcR1VTDOPby RjG0LSBpHEeOdXfmj1aGK+htW6lkplCzw03XXTBMHYxXCecJLH2NEkHTrm9DRAOq6g1C kSuWlfaSDsbyAcPmNIohxDxy3a6HAWcPLQezZ+pYj3Edl29Z0WrVW+O46CGL77LIU7V0 wBt6HTGy1aTntmszcQ7EUj5gYVYRiOdGmZ0ttROdMQloemqAaNzc+QVaCB67eQCkQpps lFgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RcQ3O61O+57c5KIRnd84roAihW9iRAp9ia33qAX9ytw=; b=bvwmy0pS+Edq/OGyELKsAn3oi8g5HC+zD2oIVI0pBv2VbB1RVqWpHAehD79VfGgnJh na9x+SY5DCg7aqIXtX4BVlVaJqmDhuNu6lEuR6wKLkSbzAa24i2wR+brid2paTRk2TgV cVnhoL9EghQD3bOkCs8ZF+FWN3aUVLPgRRPjTZKnxpNuj626BpTr/EU9svNXkfya+l/g Pw1lDYpRgDEmBjZedbUMb5YChDlS18rELu7h+oGhS6hF0aSDwt6qOOPx5rhL2l/+a48l BQyAothlr5ZYYvwBnQTflmCzmP9rCEgxT1PxRS+45m3JwUgeOlX1trYehKL8ukvCxZV1 GinA== X-Gm-Message-State: AGRZ1gJFOIoE7jjW7rJNeQze7PbVu3n0fFKSy/TdYGMubwWbBVbDzzFD 2u7GcmbsOq2aQ/Z+X4ncCSPd+lCcUdwC7U0fqH4cgg== X-Google-Smtp-Source: AJdET5cdYH1kCDRDK0U985wdTHRvhPCXKtaDjl4/OKYTVJIwjX5rT88gPKGX3xyYpqjwJROtRzZIXRic4dLNTcv6kP0= X-Received: by 2002:aca:4ce:: with SMTP id 197-v6mr3422415oie.272.1541052832324; Wed, 31 Oct 2018 23:13:52 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151883 Archived-At: --000000000000a6b04005799452ea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, I've also noticed blanks with ivy. But for sure this patch is a HUGE improvement. I had to work a little bit on a machine where I didn't install this patch and I have encountered a lot of random blanks. ---------------------------------------------------------------------------= ----- Aaron, I will hopefully be able to test with the following line commented out. w->phys_cursor_on_p =3D on_p; On Thu, 1 Nov 2018 at 07:11, Aaron Jensen wrote: > On October 31, 2018 at 9:58:59 PM, Aaron Jensen > (aaronjensen@gmail.com(mailto:aaronjensen@gmail.com)) wrote: > > > > On October 31, 2018 at 10:13:01 AM, Alan Third (alan@idiocy.org > (mailto:alan@idiocy.org)) wrote: > > > > Something is blanking the line. There are only so many places where > > > > that happens so in theory it should be relatively straight=E2=80=90= forward to > > > > find the place in question. Perhaps start by commenting out the > > > > NSRectFill commands in ns_clear_frame and ns_clear_frame_area. > > > > > > I commented out every single NSRectFill and it still did it. It=E2=80= =99s > fast, but gif attached. > > > > > > I tried commenting out the setNeedsDisplay but that breaks rendering > entirely. > > > Okay, the blank does not occur if I comment out this line: > > w->phys_cursor_on_p =3D on_p; > > Hopefully that=E2=80=99s a helpful clue :) > > The other place this blank happens is when opening a buffer from ivy. > The mini buffer blanks. It seems that has something to do w/ clearing > cursors from the non-active windows, perhaps it=E2=80=99s being a little > overzealous in its clearing and it doesn=E2=80=99t get a chance to paint > before the cpu starts churning. > > Aaron > --=20 Cheers, Boris --000000000000a6b04005799452ea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, I&= #39;ve also noticed blanks with ivy.

But for sure t= his patch is a HUGE improvement. I had to work a little bit on a
= machine where I didn't install this patch and I have encountered a lot = of random
blanks.

----------------= ----------------------------------------------------------------
<= div>
Aaron,

I will hopefully be able= to test with the following line commented out.

w-= >phys_cursor_on_p =3D on_p;


On Thu, 1 Nov 2018 at 0= 7:11, Aaron Jensen <aaronjensen= @gmail.com> wrote:
On Octob= er 31, 2018 at 9:58:59 PM, Aaron Jensen
(aaronjensen@gma= il.com(mailto:aaronjensen@gmail.com)) wrote:

> > On October 31, 2018 at 10:13:01 AM, Alan Third (alan@idiocy.org(mailto:alan@idiocy.org)) wrote:
> > > Something is blanking the line. There are only so many place= s where
> > > that happens so in theory it should be relatively straight= =E2=80=90forward to
> > > find the place in question. Perhaps start by commenting out = the
> > > NSRectFill commands in ns_clear_frame and ns_clear_frame_are= a.
> >
> > I commented out every single NSRectFill and it still did it. It= =E2=80=99s fast, but gif attached.
> >
> > I tried commenting out the setNeedsDisplay but that breaks render= ing entirely.


Okay, the blank does not occur if I comment out this line:

=C2=A0 w->phys_cursor_on_p =3D on_p;

Hopefully that=E2=80=99s a helpful clue :)

The other place this blank happens is when opening a buffer from ivy.
The mini buffer blanks. It seems that has something to do w/ clearing
cursors from the non-active windows, perhaps it=E2=80=99s being a little overzealous in its clearing and it doesn=E2=80=99t get a chance to paint before the cpu starts churning.

Aaron


--
Cheers,
Boris
--000000000000a6b04005799452ea--