unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#15500: 24.3.50; NS variant does not build 32-bit on Snow Leopard due to parameter of incompatible type 'CGRect'
@ 2013-10-01 11:02 Peter Dyballa
  2013-10-01 15:27 ` Alp Aker
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Dyballa @ 2013-10-01 11:02 UTC (permalink / raw)
  To: 15500

Hello!

This is the error:

	clang -c  -Demacs  -I. -I.../emacs-24.3.50/src -I../lib -I.../emacs-24.3.50/src/../lib   -I/usr/X11/include   -I/sw/include/librsvg-2 -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/include/gtk-2.0 -I/sw/include/cairo -I/sw/include -I/sw/include/freetype2 -I/usr/X11/include  -I/sw/include/libxml2 -I/sw/include         -MMD -MF deps/macfont.d -MP -I/sw/include    -Wno-switch -Wno-pointer-sign  -g -H -pipe -fPIC -fno-common -Os -march=core2 -mtune=core2 -m32 -fomit-frame-pointer -msse4.2   macfont.m
	macfont.m:2711:5: error: passing 'NSRect' (aka 'struct _NSRect') to parameter of incompatible type 'CGRect'
	      (aka 'struct CGRect')
	                         NSMakeRect (x, y,
	                         ^~~~~~~~~~~~~~~~~
	In file included from macfont.m:25:
	In file included from ./dispextern.h:76:
	In file included from ./nsgui.h:34:
	In file included from /System/Library/Frameworks/AppKit.framework/Headers/AppKit.h:10:
	In file included from /System/Library/Frameworks/Foundation.framework/Headers/Foundation.h:114:
	In file included from /System/Library/Frameworks/Foundation.framework/Headers/NSAppleEventDescriptor.h:8:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Headers/ApplicationServices.h:30:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/QD.framework/Headers/QD.h:25:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreGraphics.framework/Headers/CoreGraphics.h:11:
	In file included from /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreGraphics.framework/Headers/CGBitmapContext.h:9:
	/System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreGraphics.framework/Headers/CGContext.h:402:57: note: 
	      passing argument to parameter 'rect' here
	CG_EXTERN void CGContextFillRect(CGContextRef c, CGRect rect)
	                                                        ^
	1 error generated.
	make[2]: *** [macfont.o] Error 1
	make[1]: *** [src] Error 2
	make: *** [bootstrap] Error 2

At bzr revno: 114488

--
Greetings

  Pete

My sister opened a computer store in Hawaii.  She sells C shells down by the seashore.






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#15500: 24.3.50; NS variant does not build 32-bit on Snow Leopard due to parameter of incompatible type 'CGRect'
  2013-10-01 11:02 bug#15500: 24.3.50; NS variant does not build 32-bit on Snow Leopard due to parameter of incompatible type 'CGRect' Peter Dyballa
@ 2013-10-01 15:27 ` Alp Aker
  2013-10-02  3:30   ` Alp Aker
  0 siblings, 1 reply; 3+ messages in thread
From: Alp Aker @ 2013-10-01 15:27 UTC (permalink / raw)
  To: Peter Dyballa; +Cc: 15500

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

Does the following patch fix that?

=== modified file 'src/macfont.m'
--- src/macfont.m 2013-09-22 09:31:55 +0000
+++ src/macfont.m 2013-10-01 15:21:23 +0000
@@ -2708,7 +2708,7 @@
     {
       CG_SET_FILL_COLOR_WITH_GC_BACKGROUND (context, s);
       CGContextFillRect (context,
-  NSMakeRect (x, y,
+  CGRectMake (x, y,
                                      s->width, FONT_HEIGHT (s->font)));
     }

[-- Attachment #2: Type: text/html, Size: 935 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#15500: 24.3.50; NS variant does not build 32-bit on Snow Leopard due to parameter of incompatible type 'CGRect'
  2013-10-01 15:27 ` Alp Aker
@ 2013-10-02  3:30   ` Alp Aker
  0 siblings, 0 replies; 3+ messages in thread
From: Alp Aker @ 2013-10-02  3:30 UTC (permalink / raw)
  To: Peter Dyballa; +Cc: 15500-done

[-- Attachment #1: Type: text/plain, Size: 18 bytes --]

Fixed in r114493.

[-- Attachment #2: Type: text/html, Size: 39 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-02  3:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-01 11:02 bug#15500: 24.3.50; NS variant does not build 32-bit on Snow Leopard due to parameter of incompatible type 'CGRect' Peter Dyballa
2013-10-01 15:27 ` Alp Aker
2013-10-02  3:30   ` Alp Aker

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).