From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Elijah G Newsgroups: gmane.emacs.bugs Subject: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert Date: Thu, 6 Jun 2024 23:10:54 -0600 Message-ID: References: <86v82smc49.fsf@gmail.com> <8634pvoq56.fsf@gnu.org> <86mso23eg5.fsf@gmail.com> <8634pumezc.fsf@gnu.org> <86wmn4ky4k.fsf@gmail.com> <86le3jk4k9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d59f3b061a45d340" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38718"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71313@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 07 07:13:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFRue-0009sQ-2a for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jun 2024 07:13:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFRuE-0002EY-7N; Fri, 07 Jun 2024 01:12:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFRuC-0002Db-06 for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 01:12:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFRuB-0004U8-Oq for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 01:12:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFRuQ-0004kY-Ek for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2024 01:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Elijah G Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2024 05:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71313-submit@debbugs.gnu.org id=B71313.171773715318178 (code B ref 71313); Fri, 07 Jun 2024 05:13:02 +0000 Original-Received: (at 71313) by debbugs.gnu.org; 7 Jun 2024 05:12:33 +0000 Original-Received: from localhost ([127.0.0.1]:47904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFRtw-0004j7-Kh for submit@debbugs.gnu.org; Fri, 07 Jun 2024 01:12:33 -0400 Original-Received: from mail-qt1-f195.google.com ([209.85.160.195]:50222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFRtu-0004id-4B for 71313@debbugs.gnu.org; Fri, 07 Jun 2024 01:12:30 -0400 Original-Received: by mail-qt1-f195.google.com with SMTP id d75a77b69052e-44025bb945dso9123631cf.0 for <71313@debbugs.gnu.org>; Thu, 06 Jun 2024 22:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717737069; x=1718341869; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0crT2dGkKPXFK48+/e/PmEJ8srgQipsRL86bKuWr1XU=; b=V+SyUz6eu0/c8qVEEo7EEg8sTCvdEZWz/QT+c/Jx68aIGpH1mJtTafNVcEUOXoHTBc TRzPHvuIKBkTZ9vbNBR4iXjDxsCyjP8I5S1aBYVIl9jiQPzQR5nYf1XRjYRFpGx/FYIw hBWatpyxE9lhJeG/DqFh4sn0NSwM9E6fNAN6Ql7VLT/C4W5i9L6xwe8n97DKvhoymM6Z ak3iaSzSOYndslLhCtFszXf3Wql32qsr8GwC8/pq9maFWAB5JlI3Dhu5tUbHIVVWwxG8 1fTfh3lHc7xuZ3h5zOcaWQBURko23KvrPrqMeibIiPSzVMDmJJVOuzA9mVbPIRAWOQBg 9Wvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717737069; x=1718341869; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0crT2dGkKPXFK48+/e/PmEJ8srgQipsRL86bKuWr1XU=; b=F1bT6EJ7fdb8/x9lN/bHMTDyZwLtqinMUNa5FpNKyK7fGLVrqHIhj438dmIa4shwT6 h+fakwyHhyZKWF1uANBjFGWwn1vfrIHbDgWaAzYINcvu8EjzQFvGwIDJx2khTn8ShYNs JL2p6XK/7mny22sfqWruxs4mOW94BDh17cDLOG/tFyayG+rim8eqU/OfrqsHog3ckoVd 3OTV+fZ+Xy+NOTOM5Eq7sYtQl+C+rybu/+w7/WXwT2LWOwF9YM+CG5+4LJY93cj0Uj4O C3tz4/86OP7uV+j0fiZcQiqq3bJjQmSzB/xVkybqvrbVuzq1y09l/FFBWbWvW8WxvnSh CUyw== X-Forwarded-Encrypted: i=1; AJvYcCVcvJsSwY57MjEZZuAfwCMINlxw182bKGoHMCLUqbkRaxH3pTYo19iyRq4Ca800zIlwIiJRgBqRaf1ZbHcpXRXAKbnkYg8= X-Gm-Message-State: AOJu0Yy08iQ6lfM9RN7cMLEanPhPm0Mf0gGXIYHAo0SYFf38xkD2MByI LJJpxDyohyrZkINccs1AkZT8ukv3Kn2in0fHm+OtD4JrxqUrB2QJswOobLaZLUPGEHwi3lM95cB jwNDhSYyOuI4dPke/1EywDC9Zcrs= X-Google-Smtp-Source: AGHT+IG/ywcPai71vebI7D+xmRRQVPCJW4OqZRQBGW6TmC22DhzJv9YYJSL8yn3dGSrw+7MYLal2JzWX64U4hPapfi8= X-Received: by 2002:a05:622a:180b:b0:440:28b3:450e with SMTP id d75a77b69052e-44041c28441mr19880601cf.12.1717737069319; Thu, 06 Jun 2024 22:11:09 -0700 (PDT) In-Reply-To: <86le3jk4k9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286731 Archived-At: --000000000000d59f3b061a45d340 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El mi=C3=A9., 5 de junio de 2024 5:32 a. m., Eli Zaretskii escribi=C3=B3: > > From: "Elijah G." > > Cc: Stefan Monnier , 71313@debbugs.gnu.org > > Date: Tue, 04 Jun 2024 18:54:19 -0600 > > > > Eli Zaretskii writes: > > > > > Thanks, but how will an empty string "fix bugs from 3rd-party > > > completion UI"? What am I missing here? > > > > When using Completions UI such as Vertico or Helm, there is no way to > > exit from Keyword Section to go to next auto-insert Sections unless the > > user press a key sequense, for auto-insert input a empty string allow > > close Keyword section without cancelling the next auto-insert actions. > > But why would the user want to exit the Keyword Section without > inputting keywords? And why are Vertico and Helm special in this > regard? > I didn't mean to exit without input any keyword, after inserting the keyword it will ask again for add more keywords, the problem is that It's an infinite loop that it's not possible exit without pressing any keybinding for insert an empty string (e.g. M-RET in Vertico), AFAIK Vertico (and helm according to some commentaries) have this problem because they use strictly the completing-read completion table for their candidates when require-match is non-nil, the patch can be applied since it is just a little change without any side-effect. I think i will need to change the commit message for the patch, because it can misunderstand. > --000000000000d59f3b061a45d340 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
El mi=C3=A9., 5 de junio de 2024 5:32 a. m., Eli Zaretskii <= ;eliz@gnu.org> escribi=C3=B3:
> From: "Elijah G." <eg64= 2616@gmail.com>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,=C2=A0 <= a href=3D"mailto:71313@debbugs.gnu.org" target=3D"_blank" rel=3D"noreferrer= ">71313@debbugs.gnu.org
> Date: Tue, 04 Jun 2024 18:54:19 -0600
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Thanks, but how will an empty string "fix bugs from 3rd-part= y
> > completion UI"?=C2=A0 What am I missing here?
>
> When using Completions UI such as Vertico or Helm, there is no way to<= br> > exit from Keyword Section to go to next auto-insert Sections unless th= e
> user press a key sequense, for auto-insert input a empty string allow<= br> > close Keyword section without cancelling the next auto-insert actions.=

But why would the user want to exit the Keyword Section without
inputting keywords?=C2=A0 And why are Vertico and Helm special in this
regard?

I didn't mean to exit without input any keyword, after inserting= the keyword it will ask again for add more keywords, the problem is that I= t's an infinite loop that it's not possible exit without pressing a= ny keybinding for insert an empty string (e.g. M-RET in Vertico), AFAIK Ver= tico (and helm according to some commentaries) have this problem because th= ey use strictly the completing-read completion table for their candidates w= hen require-match is non-nil, the patch can be applied since it is just a l= ittle change without any side-effect.

I think i will need to change the commit message for the patc= h, because it can misunderstand.
--000000000000d59f3b061a45d340--