unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Elijah G <eg642616@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 71313@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert
Date: Thu, 6 Jun 2024 23:10:54 -0600	[thread overview]
Message-ID: <CACnP4NK9RTPgeiqeMpPOaKJauuhOfeWpJJepUSs4TQZ=96eWSg@mail.gmail.com> (raw)
In-Reply-To: <86le3jk4k9.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

El mié., 5 de junio de 2024 5:32 a. m., Eli Zaretskii <eliz@gnu.org>
escribió:

> > From: "Elijah G." <eg642616@gmail.com>
> > Cc: Stefan Monnier <monnier@iro.umontreal.ca>,  71313@debbugs.gnu.org
> > Date: Tue, 04 Jun 2024 18:54:19 -0600
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > > Thanks, but how will an empty string "fix bugs from 3rd-party
> > > completion UI"?  What am I missing here?
> >
> > When using Completions UI such as Vertico or Helm, there is no way to
> > exit from Keyword Section to go to next auto-insert Sections unless the
> > user press a key sequense, for auto-insert input a empty string allow
> > close Keyword section without cancelling the next auto-insert actions.
>
> But why would the user want to exit the Keyword Section without
> inputting keywords?  And why are Vertico and Helm special in this
> regard?
>

I didn't mean to exit without input any keyword, after inserting the
keyword it will ask again for add more keywords, the problem is that It's
an infinite loop that it's not possible exit without pressing any
keybinding for insert an empty string (e.g. M-RET in Vertico), AFAIK
Vertico (and helm according to some commentaries) have this problem because
they use strictly the completing-read completion table for their candidates
when require-match is non-nil, the patch can be applied since it is just a
little change without any side-effect.

I think i will need to change the commit message for the patch, because it
can misunderstand.

>

[-- Attachment #2: Type: text/html, Size: 2465 bytes --]

  reply	other threads:[~2024-06-07  5:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-02  0:17 bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert Elijah G.
2024-06-02  5:44 ` Eli Zaretskii
2024-06-03  3:14   ` Elijah G.
2024-06-03 11:40     ` Eli Zaretskii
2024-06-05  0:54       ` Elijah G.
2024-06-05  5:24         ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-05 11:32         ` Eli Zaretskii
2024-06-07  5:10           ` Elijah G [this message]
2024-06-07  5:48             ` Thierry Volpiatto
2024-06-08  4:32             ` Elijah G
2024-06-08 13:26               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACnP4NK9RTPgeiqeMpPOaKJauuhOfeWpJJepUSs4TQZ=96eWSg@mail.gmail.com' \
    --to=eg642616@gmail.com \
    --cc=71313@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).