From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Elijah G Newsgroups: gmane.emacs.bugs Subject: bug#70711: 30.0.50; Issue with flymake indicators Date: Thu, 2 May 2024 11:03:14 -0600 Message-ID: References: <87v83w8wp4.fsf@fastmail.com> <86o79olbk6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000000bf12d06177b9582" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27817"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70711@debbugs.gnu.org To: Eli Zaretskii , Roman Rudakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 03 06:42:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2kkL-000719-0d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 May 2024 06:42:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2kjw-0001pI-5p; Fri, 03 May 2024 00:41:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2kjt-0001oB-HR for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 00:41:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2kjt-0006C6-8V for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 00:41:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2kkF-0003ix-DI for bug-gnu-emacs@gnu.org; Fri, 03 May 2024 00:42:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Elijah G Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 04:42:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70711 X-GNU-PR-Package: emacs Original-Received: via spool by 70711-submit@debbugs.gnu.org id=B70711.171471129314276 (code B ref 70711); Fri, 03 May 2024 04:42:03 +0000 Original-Received: (at 70711) by debbugs.gnu.org; 3 May 2024 04:41:33 +0000 Original-Received: from localhost ([127.0.0.1]:46113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2kjh-0003iA-V4 for submit@debbugs.gnu.org; Fri, 03 May 2024 00:41:33 -0400 Original-Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]:53685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Zqe-0008FU-Pm for 70711@debbugs.gnu.org; Thu, 02 May 2024 13:03:58 -0400 Original-Received: by mail-qt1-x843.google.com with SMTP id d75a77b69052e-437c32af2efso50549351cf.3 for <70711@debbugs.gnu.org>; Thu, 02 May 2024 10:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714669409; x=1715274209; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LcSoB+hhRmZLjxWl7FlOADeVcaastTcsyxKu1AJld3o=; b=X0veN9HZCWHMDJgJgMlrVGe0c4ncmRpPTeNCxNYCrjOuvSy2lEe+I29scLXlex/TyJ EO1QmS7Z74AyYTsL5KvBDKLcXkpwwhtLJMguusrbnFNdfk+r+g8ijfG3PJnFtyKAaxmD o/yb/APGfENtAMsaB+z2N19LEjq41zv26AG9RunujOH/FxndVgO5X5dSbFi9TBRytP4v NXJ6Irja2X69nD7UNiTKy7cGqmUvQ61wyi5eQ4BlKkzhaS4QswxhFKF0S6Oqg7ovHUd8 NkuxPkgWXl3F0mYxRVRKpmW4F1YlWrC14Ogz29N527AOkvEbK+T486oub6K7ilySHDix OwwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714669409; x=1715274209; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LcSoB+hhRmZLjxWl7FlOADeVcaastTcsyxKu1AJld3o=; b=QpSZv+0jHMQRBXJEEszZSQq13pjL03J/3Vl9uWS8scaULbG5jML+JH/rEmc6rEqy7W l5Vd07oxO4d8vhfzuxSgA3ns44BJBkmlFwsCH5vn1L+O8VqWDbsN9pT/PX83iFgNS0fr PpgEsfAx26RJIlYvlP2Mpje4Q8ZKwpMwkG80EwFSON0XDjce01Dq276aSkMN+4ed8NQ1 6oRsg1qhJAkmDEL+j8LjVmwtr1bVM6JIEL25EL8r+AdfKUl2cP+WbBXBm62ke0E8aDyW dLvUWz0QhRe+Cswp1blbnQOjjU7DMsYncBBxEWleEC0SGg43GNuKVXyYHYk5PQdAlJpU RmLQ== X-Gm-Message-State: AOJu0Yy1DiHDr7NfWB/0Rmn0rjWkjzqC7cXYaPoXe5WDKLlbEb0Fqsrv LYx2TVHPt5kGL3/wopkkAqhoQLbCTScoIlXwkrad58a6+tsAzIk1ljNEpBSwnqiHAG1Q4iF4uv7 0pgTusL0p5PKnPA+hiIxa94p12k0= X-Google-Smtp-Source: AGHT+IFsl8/oTOc5iqYhDw87Ckml3Xl29TPHJeTnxyvGKf7DB37OpxPq1YstTeun8cqiImfR/FXkyrFUho9LqPTSLq4= X-Received: by 2002:a05:622a:95:b0:437:c024:73f3 with SMTP id o21-20020a05622a009500b00437c02473f3mr112074qtw.44.1714669409249; Thu, 02 May 2024 10:03:29 -0700 (PDT) In-Reply-To: <86o79olbk6.fsf@gnu.org> X-Mailman-Approved-At: Fri, 03 May 2024 00:41:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284357 Archived-At: --0000000000000bf12d06177b9582 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 2, 2024 at 5:04=E2=80=AFAM Eli Zaretskii wrote: > > > From: Roman Rudakov > > Date: Thu, 02 May 2024 10:06:15 +0200 > > > > After the latest update of flymake I started experiencing an issue > > with indicators. The problem occurs if I try to disable indicators > > completely. > > > > Steps to reproduce from "emacs -q": > > 1. Evaluate the following forms: > > > > (setopt flymake-fringe-indicator-position nil > > flymake-margin-indicator-position nil) > > (flymake-mode) > > > > 2. Type some invalid expression to trigger flymake. > > > > Expected result: No indicators. > > > > Actual result: Exclamation mark is shown right before the faulty > > expression (not even on fringe or margin). > > Elijah, could you please look into this? > > Thanks. Hi Eli, below you can find the attached patch that should fix this issue. Roman Can you eval this defun and tell if the bug is fixed? Thanks. ``` elisp (defun flymake--indicator-overlay-spec (indicator) "Return INDICATOR as propertized string to use in error indicators." (let* ((value (if (symbolp indicator) (symbol-value indicator) indicator)) (indicator-car (if (listp value) (car value) value)) (indicator-cdr (if (listp value) (cdr value)))) (cond ((and (symbolp indicator-car) flymake-fringe-indicator-position) (propertize "!" 'display (cons flymake-fringe-indicator-position (if (listp value) value (list value))))) ((and (stringp indicator-car) flymake-margin-indicator-position) (propertize "!" 'display `((margin ,flymake-margin-indicator-position) ,(propertize indicator-car 'face `(:inherit (,indicator-cdr default))))))))) ```` --0000000000000bf12d06177b9582 Content-Type: application/octet-stream; name="0001-Fix-bug-70711.patch" Content-Disposition: attachment; filename="0001-Fix-bug-70711.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lvphma9a0 RnJvbSBmNDc4NDBkZmExN2UyN2NlZGUyYjEwMDM5ZjhjZDM2Zjk0Mzg0YzY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAiRWxpYXMgRy4gUGVyZXoiIDxlZzY0MjYxNkBnbWFpbC5jb20+ CkRhdGU6IFRodSwgMiBNYXkgMjAyNCAxMDozMzo0MyAtMDYwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBidWcjNzA3MTEKCiogbGlzcC9wcm9nbW9kZXMvZmx5bWFrZS5lbCAoZmx5bWFrZS0taW5kaWNh dG9yLW92ZXJsYXktc3BlYyk6CkNoZWNrIGlmIGBmbHltYWtlLWZyaW5nZS1pbmRpY2F0b3ItcG9z aXRpb24nIG9yCmBmbHltYWtlLW1hcmdpbi1pbmRpY2F0b3ItcG9zaXRpb24nIGFyZSBub24tbmls IGZvciBhbGxvdyBubwppbmRpY2F0b3JzLgotLS0KIGxpc3AvcHJvZ21vZGVzL2ZseW1ha2UuZWwg fCA2ICsrKystLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9mbHltYWtlLmVsIGIvbGlzcC9wcm9nbW9k ZXMvZmx5bWFrZS5lbAppbmRleCAyMmExMzlkMzA0NS4uZjM1NzgxNTJiMzYgMTAwNjQ0Ci0tLSBh L2xpc3AvcHJvZ21vZGVzL2ZseW1ha2UuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZmx5bWFrZS5l bApAQCAtNzU0LDEzICs3NTQsMTUgQEAgZmx5bWFrZS0taW5kaWNhdG9yLW92ZXJsYXktc3BlYwog ICAgICAgICAgKGluZGljYXRvci1jZHIgKGlmIChsaXN0cCB2YWx1ZSkKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoY2RyIHZhbHVlKSkpKQogICAgIChjb25kCi0gICAgICgoc3ltYm9scCBp bmRpY2F0b3ItY2FyKQorICAgICAoKGFuZCAoc3ltYm9scCBpbmRpY2F0b3ItY2FyKQorICAgICAg ICAgICBmbHltYWtlLWZyaW5nZS1pbmRpY2F0b3ItcG9zaXRpb24pCiAgICAgICAocHJvcGVydGl6 ZSAiISIgJ2Rpc3BsYXkKICAgICAgICAgICAgICAgICAgIChjb25zIGZseW1ha2UtZnJpbmdlLWlu ZGljYXRvci1wb3NpdGlvbgogICAgICAgICAgICAgICAgICAgICAgICAgKGlmIChsaXN0cCB2YWx1 ZSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZQogICAgICAgICAgICAgICAgICAg ICAgICAgICAobGlzdCB2YWx1ZSkpKSkpCi0gICAgICgoc3RyaW5ncCBpbmRpY2F0b3ItY2FyKQor ICAgICAoKGFuZCAoc3RyaW5ncCBpbmRpY2F0b3ItY2FyKQorICAgICAgICAgICBmbHltYWtlLW1h cmdpbi1pbmRpY2F0b3ItcG9zaXRpb24pCiAgICAgICAocHJvcGVydGl6ZSAiISIKICAgICAgICAg ICAgICAgICAgICdkaXNwbGF5CiAgICAgICAgICAgICAgICAgICBgKChtYXJnaW4gLGZseW1ha2Ut bWFyZ2luLWluZGljYXRvci1wb3NpdGlvbikKLS0gCjIuNDQuMC53aW5kb3dzLjEKCg== --0000000000000bf12d06177b9582--