From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tak Ota Newsgroups: gmane.emacs.bugs Subject: bug#62792: Emacs 29.0.90 build fails Date: Wed, 12 Apr 2023 12:54:45 -0700 Message-ID: References: <83bkjt6rpk.fsf@gnu.org> <8335556oqc.fsf@gnu.org> <83ttxl571n.fsf@gnu.org> <83sfd553ns.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000058305305f928fb71" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7273"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62792@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 12 21:56:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmga0-0001ie-PS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Apr 2023 21:56:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmgZj-0000yf-Gd; Wed, 12 Apr 2023 15:56:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmgZY-0000tk-RC for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 15:56:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmgZX-0000ra-2t for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 15:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmgZW-0007DE-IH for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 15:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tak Ota Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2023 19:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62792 X-GNU-PR-Package: emacs Original-Received: via spool by 62792-submit@debbugs.gnu.org id=B62792.168132930327609 (code B ref 62792); Wed, 12 Apr 2023 19:56:02 +0000 Original-Received: (at 62792) by debbugs.gnu.org; 12 Apr 2023 19:55:03 +0000 Original-Received: from localhost ([127.0.0.1]:41838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmgYY-0007BD-Th for submit@debbugs.gnu.org; Wed, 12 Apr 2023 15:55:03 -0400 Original-Received: from mail-oi1-f172.google.com ([209.85.167.172]:42715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmgYW-0007AE-BA for 62792@debbugs.gnu.org; Wed, 12 Apr 2023 15:55:02 -0400 Original-Received: by mail-oi1-f172.google.com with SMTP id z16so8218179oib.9 for <62792@debbugs.gnu.org>; Wed, 12 Apr 2023 12:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681329294; x=1683921294; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pv6GOY6sv3zESgyRU1c2rJPMeoVEwADQYDn1aIFDCLE=; b=dyig5l00Hvv9f9c3xCq7He1bUuMl6ahcybwZf1KtOwwuH3buaAIevPmm9RW6oSYNuO Z0/qOkaseiQMBmL+eXVvnFuGXO+2Fx3fYQDfQKuY5089BPcSGTf45aWiWm8wFvdJtv00 JF8VNUt+kcJsqwLyu+tpRtU5UEvPC8lqUsSwSiyFBhcogFac+tJz9lG72GAEhbfvQgMk 0jU7Ght1vXDtEw8y5m31IAfo9zFL4+wIljfPsz1abvTyXrqSc4rtEs/CzUZknGCEw9Xi QMlp3CsmtFyRkD2RLjU444rm9nqclGpsDm7Tz04/xuHFpo2uG6aKLqD4rm9h5k93NcM8 3bbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681329294; x=1683921294; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pv6GOY6sv3zESgyRU1c2rJPMeoVEwADQYDn1aIFDCLE=; b=AnqNX+Gr637y248hyJADlpjlCb9uuOhNo064MFx8WDOlXEB9T/4qhbulqDZTe06JqU TPMEQuDgQTBhJHaQExfdfV6NSh4WdC13jFAo0sGhPHfH/SgvQP2/+yeWvQr9TaOVx7Yx bfoEbzcAF5laW5xRyho63vCdSxseos6VadbtQOVkG9ikwlcw0XJnA8BLgzowvC9jOHCS 6UnlBVMv5erQv5FNUb/KnIE2o3dOrIg8WFe+Y2QM/2IpsyxvJc+kLI+sD9g+BsKvTy50 Ga6IrNCbPRNbuo1EjDFJEtRX3/84GYp31tV6sZmbevh7eFXuWodfuOqdSaH9UuuXCNB2 NcBQ== X-Gm-Message-State: AAQBX9dyaLpkBM/7y1fVVFVvPX81azygNE00asXL7MwDUr3DK4Po+xnd ZisNcj3NeXK2GaAYHxJdjF5lrEgY5OnmTMorytt5xHvn6pg= X-Google-Smtp-Source: AKy350Z874du9HxoIDBdRkZlzSTG+kq7NQANgca+ZQdhV4fhwsW8fhpjgU6hU/8A2ZC/C0Zp0PEzkgor8UHhbGTrscI= X-Received: by 2002:a05:6808:1:b0:384:6607:401 with SMTP id u1-20020a056808000100b0038466070401mr1009127oic.0.1681329294420; Wed, 12 Apr 2023 12:54:54 -0700 (PDT) In-Reply-To: <83sfd553ns.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259808 Archived-At: --00000000000058305305f928fb71 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, this patch averts the error. Thank you. -Tak On Wed, Apr 12, 2023 at 11:57=E2=80=AFAM Eli Zaretskii wrote= : > > From: Tak Ota > > Date: Wed, 12 Apr 2023 11:45:58 -0700 > > Cc: 62792@debbugs.gnu.org > > > > #define __MINGW32_VERSION 3022004L > > #define __MINGW32_MAJOR_VERSION 3 > > #define __MINGW32_MINOR_VERSION 22 > > #define __MINGW32_PATCHLEVEL 4 > > OK, thanks. I think I see the reason now. Please try the patch below > and tell if it solves the problem. > > diff --git a/src/w32.c b/src/w32.c > index 8d344d2..bb3b35f 100644 > --- a/src/w32.c > +++ b/src/w32.c > @@ -543,7 +543,13 @@ int (WINAPI > *pWideCharToMultiByte)(UINT,DWORD,LPCWSTR,int,LPSTR,int,LPCSTR,LPBOO > > typedef COORD (WINAPI *GetConsoleFontSize_Proc) (HANDLE, DWORD); > > -#if _WIN32_WINNT < 0x0501 > +/* Old versions of mingw.org's MinGW, before v5.2.0, don't have a > + _WIN32_WINNT guard for CONSOLE_FONT_INFO in wincon.h, which causes > + compilation errors. Note: MinGW64 sets _WIN32_WINNT to a higher > + version, and its w32api.h version stays fixed at 3.14. */ > +#if _WIN32_WINNT < 0x0501 \ > + && (__W32API_MAJOR_VERSION > 5 \ > + || (__W32API_MAJOR_VERSION =3D=3D 5 && __W32API_MINOR_VERSION >= =3D 2)) > typedef struct > { > DWORD nFont; > --00000000000058305305f928fb71 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, this patch averts the error.=C2=A0 Thank you.
-Tak

On Wed, Apr 12, 2023 at 11:57=E2=80=AFAM Eli Zaretski= i <eliz@gnu.org> wrote:
=
> From: Tak Ota <takaaki.ota@gmail.= com>
> Date: Wed, 12 Apr 2023 11:45:58 -0700
> Cc: 62792@d= ebbugs.gnu.org
>
> #define __MINGW32_VERSION=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A03022= 004L
> #define __MINGW32_MAJOR_VERSION=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A03
> #define __MINGW32_MINOR_VERSION=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 22 > #define __MINGW32_PATCHLEVEL=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 4

OK, thanks.=C2=A0 I think I see the reason now.=C2=A0 Please try the patch = below
and tell if it solves the problem.

diff --git a/src/w32.c b/src/w32.c
index 8d344d2..bb3b35f 100644
--- a/src/w32.c
+++ b/src/w32.c
@@ -543,7 +543,13 @@ int (WINAPI *pWideCharToMultiByte)(UINT,DWORD,LPCWSTR,= int,LPSTR,int,LPCSTR,LPBOO

=C2=A0typedef COORD (WINAPI *GetConsoleFontSize_Proc) (HANDLE, DWORD);

-#if _WIN32_WINNT < 0x0501
+/* Old versions of mingw.org's MinGW, before v5.2.0, don't have a
+=C2=A0 =C2=A0_WIN32_WINNT guard for CONSOLE_FONT_INFO in wincon.h, which c= auses
+=C2=A0 =C2=A0compilation errors.=C2=A0 Note: MinGW64 sets _WIN32_WINNT to = a higher
+=C2=A0 =C2=A0version, and its w32api.h version stays fixed at 3.14.=C2=A0 = */
+#if _WIN32_WINNT < 0x0501 \
+=C2=A0 =C2=A0 && (__W32API_MAJOR_VERSION > 5 \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0|| (__W32API_MAJOR_VERSION =3D=3D 5 && = __W32API_MINOR_VERSION >=3D 2))
=C2=A0typedef struct
=C2=A0{
=C2=A0 =C2=A0DWORD nFont;
--00000000000058305305f928fb71--