From: Tak Ota <takaaki.ota@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62792@debbugs.gnu.org
Subject: bug#62792: Emacs 29.0.90 build fails
Date: Wed, 12 Apr 2023 12:54:45 -0700 [thread overview]
Message-ID: <CACehZKJYsAy-R1MAu03XVu=g0FRyH96NWk-KuMseMVFYcES6DQ@mail.gmail.com> (raw)
In-Reply-To: <83sfd553ns.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]
Yes, this patch averts the error. Thank you.
-Tak
On Wed, Apr 12, 2023 at 11:57 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Tak Ota <takaaki.ota@gmail.com>
> > Date: Wed, 12 Apr 2023 11:45:58 -0700
> > Cc: 62792@debbugs.gnu.org
> >
> > #define __MINGW32_VERSION 3022004L
> > #define __MINGW32_MAJOR_VERSION 3
> > #define __MINGW32_MINOR_VERSION 22
> > #define __MINGW32_PATCHLEVEL 4
>
> OK, thanks. I think I see the reason now. Please try the patch below
> and tell if it solves the problem.
>
> diff --git a/src/w32.c b/src/w32.c
> index 8d344d2..bb3b35f 100644
> --- a/src/w32.c
> +++ b/src/w32.c
> @@ -543,7 +543,13 @@ int (WINAPI
> *pWideCharToMultiByte)(UINT,DWORD,LPCWSTR,int,LPSTR,int,LPCSTR,LPBOO
>
> typedef COORD (WINAPI *GetConsoleFontSize_Proc) (HANDLE, DWORD);
>
> -#if _WIN32_WINNT < 0x0501
> +/* Old versions of mingw.org's MinGW, before v5.2.0, don't have a
> + _WIN32_WINNT guard for CONSOLE_FONT_INFO in wincon.h, which causes
> + compilation errors. Note: MinGW64 sets _WIN32_WINNT to a higher
> + version, and its w32api.h version stays fixed at 3.14. */
> +#if _WIN32_WINNT < 0x0501 \
> + && (__W32API_MAJOR_VERSION > 5 \
> + || (__W32API_MAJOR_VERSION == 5 && __W32API_MINOR_VERSION >= 2))
> typedef struct
> {
> DWORD nFont;
>
[-- Attachment #2: Type: text/html, Size: 2013 bytes --]
next prev parent reply other threads:[~2023-04-12 19:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 18:16 bug#62792: Emacs 29.0.90 build fails Tak Ota
2023-04-12 15:33 ` Eli Zaretskii
2023-04-12 16:18 ` Tak Ota
2023-04-12 16:36 ` Corwin Brust
2023-04-12 18:36 ` Tak Ota
2023-04-12 18:42 ` Tak Ota
2023-04-12 19:01 ` Eli Zaretskii
2023-04-12 18:48 ` Tak Ota
2023-04-12 18:59 ` Eli Zaretskii
2023-04-12 19:56 ` Tak Ota
2023-04-12 16:37 ` Eli Zaretskii
2023-04-12 17:44 ` Eli Zaretskii
2023-04-12 18:45 ` Tak Ota
2023-04-12 18:57 ` Eli Zaretskii
2023-04-12 19:54 ` Tak Ota [this message]
2023-04-13 5:20 ` Eli Zaretskii
2023-04-13 16:17 ` Tak Ota
2023-04-12 18:16 ` Tak Ota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACehZKJYsAy-R1MAu03XVu=g0FRyH96NWk-KuMseMVFYcES6DQ@mail.gmail.com' \
--to=takaaki.ota@gmail.com \
--cc=62792@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).